On 22/04/2020 11:23 pm, Kim Barrett wrote:
Please review this change to undo the (small) portion of JDK-8238281
[1] related to the HotSpot offset_of macro for gcc/clang. That change
should not have been made. See CR for details.
I did not reinstate the redefinition of offsetof; we shouldn't be
Hi,
Could I please get a review of this 11u backport of a build fix? The
jdk/jdk patch does not apply cleanly since JDK-8222510[1] isn't in
OpenJDK 11u. I.e. this makes the context different and the patch
failing to apply. I've manually ported the patch. The gist is:
$(VERSION_CFLAGS) => $$(VERSI
On 2020-04-21 16:39, Erik Joelsson wrote:
On 2020-04-21 00:51, Magnus Ihse Bursie wrote:
On 2020-04-21 00:29, Erik Joelsson wrote:
With Nashorn removed, the bootcycle build is now broken for builds
that process markdown files for docs or man pages. Same goes for
building with with a recent
On 2020-04-22 15:23, Kim Barrett wrote:
Please review this change to undo the (small) portion of JDK-8238281
[1] related to the HotSpot offset_of macro for gcc/clang. That change
should not have been made. See CR for details.
I did not reinstate the redefinition of offsetof; we shouldn't be
us
Build change looks good.
/Erik
On 2020-04-22 06:23, Kim Barrett wrote:
Please review this change to undo the (small) portion of JDK-8238281
[1] related to the HotSpot offset_of macro for gcc/clang. That change
should not have been made. See CR for details.
I did not reinstate the redefinitio
Please review this change to undo the (small) portion of JDK-8238281
[1] related to the HotSpot offset_of macro for gcc/clang. That change
should not have been made. See CR for details.
I did not reinstate the redefinition of offsetof; we shouldn't be
using that macro, and having the warning ena
