Re: RFR(T) : 8245870 : GTEST_FRAMEWORK_SRC should go thought UTIL_FIXUP_PATH

thanks Erik, pushed. -- Igor > On May 26, 2020, at 2:52 PM, Erik Joelsson wrote: > > Looks good. > > /Erik > > On 2020-05-26 14:48, Igor Ignatyev wrote: >> Hi all, >> >> could you please review this trivial one-liner? >> >> JBS: https://bugs.openjdk.java.net/browse/JDK-8245870 >> webrev: ht

Re: RFR(T) : 8245870 : GTEST_FRAMEWORK_SRC should go thought UTIL_FIXUP_PATH

Looks good. /Erik On 2020-05-26 14:48, Igor Ignatyev wrote: Hi all, could you please review this trivial one-liner? JBS: https://bugs.openjdk.java.net/browse/JDK-8245870 webrev: http://cr.openjdk.java.net/~iignatyev//8245870/webrev.00 testing: build on linux-x64,windows-x64 (in progress) Tha

RFR(T) : 8245870 : GTEST_FRAMEWORK_SRC should go thought UTIL_FIXUP_PATH

Hi all, could you please review this trivial one-liner? JBS: https://bugs.openjdk.java.net/browse/JDK-8245870 webrev: http://cr.openjdk.java.net/~iignatyev//8245870/webrev.00 testing: build on linux-x64,windows-x64 (in progress) Thanks, -- Igor

Re: suggesting fix: cross-compilation is requiring write permissions to bootstrap jdk

Hi, I think the proposed flags should do the right thing here. It should be straightforward to verify since the contents of the generated files should ideally not change at all on a standard build. /Claes On 2020-05-26 17:25, Erik Joelsson wrote: Hello, On 2020-05-26 08:00, Magnus Ihse Bursie

Re: suggesting fix: cross-compilation is requiring write permissions to bootstrap jdk

On 2020-05-26 08:09, Magnus Ihse Bursie wrote: On 2020-05-26 17:00, Magnus Ihse Bursie wrote: On 2020-05-26 15:32, David Holmes wrote: Re-directing to the build-dev list. David On 26/05/2020 11:14 pm, Fedor wrote: Hello all! I've tried to crossbuild jdk using current http://hg.openjdk.ja

Re: suggesting fix: cross-compilation is requiring write permissions to bootstrap jdk

Hello, On 2020-05-26 08:00, Magnus Ihse Bursie wrote: On 26/05/2020 11:14 pm, Fedor wrote: Hello all! I've tried to crossbuild jdk using current http://hg.openjdk.java.net/jdk/jdk/ sources and noticed that build requires write permissions to bootstrap jdk. Your patch seems to be doing the

Re: suggesting fix: cross-compilation is requiring write permissions to bootstrap jdk

On 2020-05-26 17:00, Magnus Ihse Bursie wrote: On 2020-05-26 15:32, David Holmes wrote: Re-directing to the build-dev list. David On 26/05/2020 11:14 pm, Fedor wrote: Hello all! I've tried to crossbuild jdk using current http://hg.openjdk.java.net/jdk/jdk/ sources and noticed that build re

Re: suggesting fix: cross-compilation is requiring write permissions to bootstrap jdk

On 2020-05-26 15:32, David Holmes wrote: Re-directing to the build-dev list. David On 26/05/2020 11:14 pm, Fedor wrote: Hello all! I've tried to crossbuild jdk using current http://hg.openjdk.java.net/jdk/jdk/ sources and noticed that build requires write permissions to bootstrap jdk. Say

Re: suggesting fix: cross-compilation is requiring write permissions to bootstrap jdk

Re-directing to the build-dev list. David On 26/05/2020 11:14 pm, Fedor wrote: Hello all! I've tried to crossbuild jdk using current http://hg.openjdk.java.net/jdk/jdk/ sources and noticed that build requires write permissions to bootstrap jdk. The problem is it tries to write/rewrite class

Re: RFR(S) : 8245610 : remove in-tree copy on gtest

On 2020-05-25 19:53, Igor Ignatyev wrote: Hi Magnus, On May 25, 2020, at 7:46 AM, Magnus Ihse Bursie > wrote: Looks basically good to me. thanks for your review! We need to document the dependency on gtest, and how to retrieve it. I recommend you a