Re: [OpenJDK 2D-Dev] RFR: 8246032: Implementation of JEP 347: Adopt C++14 Language Features in HotSpot

2020-06-09 Thread Kim Barrett
> On Jun 8, 2020, at 4:07 PM, Philip Race wrote: > > Hi Kim, > > Can we amend the JEP itself to be not solely about hotspot. > Since it affects other areas I think that > 1) They may need to be compiled with C++14 enabled whether they use new > features or not > 2) They may want - or need - to

Re: RFR(S) : 8246387 : switch to jtreg 5.1

2020-06-09 Thread David Holmes
Hi Igor, All of these changes seem okay to me. Thanks, David On 10/06/2020 1:56 am, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev/8246387/webrev.00/ 110 lines changed: 6 ins; 89 del; 15 mod; Hi all, could you please review the patch which switches jtreg used in jdk/jdk to the

Re: RFR(S) : 8246387 : switch to jtreg 5.1

2020-06-09 Thread Erik Joelsson
Looks good to me. /Erik On 2020-06-09 08:56, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev/8246387/webrev.00/ 110 lines changed: 6 ins; 89 del; 15 mod; Hi all, could you please review the patch which switches jtreg used in jdk/jdk to the newly promoted jtreg5.1? as before, the

RFR(S) : 8246387 : switch to jtreg 5.1

2020-06-09 Thread Igor Ignatyev
http://cr.openjdk.java.net/~iignatyev/8246387/webrev.00/ > 110 lines changed: 6 ins; 89 del; 15 mod; Hi all, could you please review the patch which switches jtreg used in jdk/jdk to the newly promoted jtreg5.1? as before, the patch changes 'requiredVersion' property in all jtreg test suites to

Re: RFR: JDK-8246751 Mac OS build settings should use -O3

2020-06-09 Thread Magnus Ihse Bursie
On 2020-06-09 08:59, David Holmes wrote: On 9/06/2020 8:26 am, Claes Redestad wrote: On 2020-06-09 00:12, Sergey Bylokhov wrote: On 6/8/20 3:06 pm, Claes Redestad wrote: Right, -O3 is now likely the default for most files. I'm not sure you suggest the reported ~2% difference between -Os and -

Re: RFR: JDK-8236469: macOS devkit needs 64-bit SetFile for Catalina

2020-06-09 Thread Magnus Ihse Bursie
On 2020-06-08 22:37, Erik Joelsson wrote: Hello, When building JDK 15 with the current devkit on a Catalina host, the build fails. This is because the SetFile command is picked up from the devkit and in the Xcode version the devkit is based on, that executable is 32bit. I had expected to upda

Re: RFR: JDK-8246751 Mac OS build settings should use -O3

2020-06-09 Thread David Holmes
On 9/06/2020 8:26 am, Claes Redestad wrote: On 2020-06-09 00:12, Sergey Bylokhov wrote: On 6/8/20 3:06 pm, Claes Redestad wrote: Right, -O3 is now likely the default for most files. I'm not sure you suggest the reported ~2% difference between -Os and -O2/-O3 as an argument against changing to