On 16/06/2020 12:34 am, Magnus Ihse Bursie wrote:
On 2020-06-15 15:15, David Holmes wrote:
Hi Magnus,
On 15/06/2020 10:57 pm, Magnus Ihse Bursie wrote:
On 2020-06-12 15:09, Erik Joelsson wrote:
Looks good to me at least.
Thank you Erik.
Any hotspotters who care to comment?
I'd like a litt
Hi Magnus,
Great to see this getting fixed! Thanks!
On 16/06/2020 1:56 am, Magnus Ihse Bursie wrote:
It turned out that it was not possible to send arguments directly to the
java that launches jtreg, something that was needed, especially to
change the output limit using Djavatest.maxOutputSize
Thanks; I'll link to that page from the jtreg FAQ.
-- Jon
On 6/15/20 2:23 PM, Erik Joelsson wrote:
The makefile test documentation is in the repo, so you could link
directly to it:
https://hg.openjdk.java.net/jdk/jdk/raw-file/87828d2e32fe/doc/testing.html
Which reminds me that Magnus shou
@David, Erik, Magnus,
please find the answers to your comments at the bottom of this email.
@all,
David's and Erik's comments made me realize that some parts of the original
patch were stashed away and didn't make it to webrev.00. I'm truly sorry for
the confusion and inconvenience. I also agr
The makefile test documentation is in the repo, so you could link
directly to it:
https://hg.openjdk.java.net/jdk/jdk/raw-file/87828d2e32fe/doc/testing.html
Which reminds me that Magnus should update that documentation with these
new options.
/Erik
On 2020-06-15 14:19, Jonathan Gibbons wrot
Magnus,
Would it be worth while adding something to the jtreg documentation,
such as a new page describing these options for the JDK makefile
support, giving due deference to the makefile (like "If in doubt,
consult `make test JTREG=help`")
I can write the page, with your help, if you think
Looks good.
/Erik
On 2020-06-15 08:56, Magnus Ihse Bursie wrote:
It turned out that it was not possible to send arguments directly to
the java that launches jtreg, something that was needed, especially to
change the output limit using Djavatest.maxOutputSize.
This patch adds JTREG=LAUNCHER_O
Looks good.
/Erik
On 2020-06-15 06:39, Magnus Ihse Bursie wrote:
This is an old web bug. Our implementation of version parsing do not
match the latest changes to JEP 223. Specifically, the PRE tag can now
also include numbers, not only letters.
And yes, this is horribly unreadable.
Some peo
On 2020-06-15 08:12, Magnus Ihse Bursie wrote:
A few comments:
This seems like code copied from elsewhere:
57 # This evaluation is expensive and should only be done if this
target was
58 # explicitly called.
59 ifneq ($(filter build-test-libtest-jtreg-native, $(MAKECMDGOALS)), )
I do
It turned out that it was not possible to send arguments directly to the
java that launches jtreg, something that was needed, especially to
change the output limit using Djavatest.maxOutputSize.
This patch adds JTREG=LAUNCHER_OPTIONS=xxx to pass generic options to
the launcher. Also, for the s
A few comments:
This seems like code copied from elsewhere:
57 # This evaluation is expensive and should only be done if this target was
58 # explicitly called.
59 ifneq ($(filter build-test-libtest-jtreg-native, $(MAKECMDGOALS)), )
I don't agree that this is an expensive evaluation. Furt
On 2020-06-15 15:15, David Holmes wrote:
Hi Magnus,
On 15/06/2020 10:57 pm, Magnus Ihse Bursie wrote:
On 2020-06-12 15:09, Erik Joelsson wrote:
Looks good to me at least.
Thank you Erik.
Any hotspotters who care to comment?
I'd like a little more assurance that nothing is broken than just:
This is an old web bug. Our implementation of version parsing do not
match the latest changes to JEP 223. Specifically, the PRE tag can now
also include numbers, not only letters.
And yes, this is horribly unreadable.
Some people, when confronted with a problem, think “I know,
I'll use regular
Hi Magnus,
On 15/06/2020 10:57 pm, Magnus Ihse Bursie wrote:
On 2020-06-12 15:09, Erik Joelsson wrote:
Looks good to me at least.
Thank you Erik.
Any hotspotters who care to comment?
I'd like a little more assurance that nothing is broken than just:
"I've done some quick tests (debugging,
Hello Igor,
In JtretNativeLibTest.gmk, lines 51-55 should probably be removed (or
adjusted if linking to libjvm is actually needed).
/Erik
On 2020-06-12 21:10, Igor Ignatyev wrote:
testing revealed that LingeredAppTest.java required some love, incremental
webrev w/ the fixes for LingeredApp
On 2020-06-12 15:09, Erik Joelsson wrote:
Looks good to me at least.
Thank you Erik.
Any hotspotters who care to comment?
/Magnus
/Erik
On 2020-06-12 05:21, Magnus Ihse Bursie wrote:
From Volker's bug report:
"We are building and linking the libjvm.so on Linux with
-fnoexceptions because
> On Jun 14, 2020, at 12:45 AM, Philip Race wrote:
>
> Kim,
>
>
> Until it says in "the JDK" and not "in HotSpot" you have not addressed my
> main point.
> Please rename the JEP.
I think this JEP is primarily about updating the HotSpot-specific
subset of C++ and usage guidance to include some
Hi Erik,
I'm not sure what made this fall through the cracks. I've been pushing
the bug ahead of me, unaware that a patch already existed. (Which still
applied, not cleanly, but with the help of wiggle.)
Anyway, in a record-breaking slow time to review, I pronounce this patch
OK. :-)
And,
On 2020-06-15 07:46, David Holmes wrote:
Hi Magnus,
On 13/06/2020 1:42 am, Magnus Ihse Bursie wrote:
When support for gnu hash tables were added to the gcc toolchains,
the OpenJDK build system added a hack to change --hash-style=gnu to
--hash-style=both unconditionally, citing compatibility co
19 matches
Mail list logo
