Re: RFR: JDK-8213214: Set -Djava.io.tmpdir= when running tests

2020-06-17 Thread Alan Bateman
On 16/06/2020 18:44, Erik Joelsson wrote: There are a lot of jtreg tests that use temporary files. These temporary files add up over time and fill up the global temp directories on our test systems. To tackle this, we should try to redirect these temporary files into a directory controlled by t

Re: RFR: JDK-8213214: Set -Djava.io.tmpdir= when running tests

2020-06-17 Thread Erik Joelsson
On 2020-06-16 15:53, Jonathan Gibbons wrote: It would also be good to identify the tests that are using temporary directories in this manner and have them use the jtreg scratch directory where possible. I completely agree that tests should be fixed to behave better. Using scratch instead of t

Re: RFR: JDK-8213214: Set -Djava.io.tmpdir= when running tests

2020-06-17 Thread Erik Joelsson
On 2020-06-16 23:25, Sergey Bylokhov wrote: As far as I understand this new temp folder will be cleaned after every tests run, doesn't it look like a workaround for problematic tests and product bugs? This new tmp folder is created in the jtreg test-support dir (which is where we direct the jtre

Re: RFR: JDK-8213214: Set -Djava.io.tmpdir= when running tests

2020-06-17 Thread Erik Joelsson
On 2020-06-17 01:24, Alan Bateman wrote: On 16/06/2020 18:44, Erik Joelsson wrote: There are a lot of jtreg tests that use temporary files. These temporary files add up over time and fill up the global temp directories on our test systems. To tackle this, we should try to redirect these temp

Re: RFR: JDK-8213214: Set -Djava.io.tmpdir= when running tests

2020-06-17 Thread Alan Bateman
On 17/06/2020 14:47, Erik Joelsson wrote: I've tried to make this clearer in the comment. http://cr.openjdk.java.net/~erikj/8213214/webrev.02/ I would prefer if you could move the notes/comment from L125-157 to the bug report to avoid cluttering the test. Instead, the test just needs a one l

Re: RFR: JDK-8213214: Set -Djava.io.tmpdir= when running tests

2020-06-17 Thread Erik Joelsson
On 2020-06-17 07:43, Alan Bateman wrote: On 17/06/2020 14:47, Erik Joelsson wrote: I've tried to make this clearer in the comment. http://cr.openjdk.java.net/~erikj/8213214/webrev.02/ I would prefer if you could move the notes/comment from L125-157 to the bug report to avoid cluttering the

Re: RFR: JDK-8213214: Set -Djava.io.tmpdir= when running tests

2020-06-17 Thread Jonathan Gibbons
On 6/17/20 5:55 AM, Erik Joelsson wrote: On 2020-06-16 15:53, Jonathan Gibbons wrote: It would also be good to identify the tests that are using temporary directories in this manner and have them use the jtreg scratch directory where possible. I completely agree that tests should be fixed t

Re: JDK 16 RFR of JDK-8245588: Update --release 15 symbol information for JDK 15 build 27

2020-06-17 Thread Jonathan Gibbons
+1 -- Jon On 6/14/20 1:25 PM, Joe Darcy wrote: Hello, Please review updating JDK 16's --release 15 information for JDK 15 b27:     http://cr.openjdk.java.net/~darcy/8245588.0/ Thanks, -Joe

Re: RFR: JDK-8213214: Set -Djava.io.tmpdir= when running tests

2020-06-17 Thread Alan Bateman
On 17/06/2020 16:38, Erik Joelsson wrote: Ah, misunderstood you then. I added a comment to JDK-8213216 with more details and shortened the comment in the test: http://cr.openjdk.java.net/~erikj/8213214/webrev.03/ Looks okay as a workaround until we figure out what to do with subst. -Alan.

RFR: 8246436: JFR: Avoid parsing metadata.xml during startup

2020-06-17 Thread Erik Gahlin
Hi, Could I have review of an enhancement that will avoid parsing the XML metadata for the JVM events during startup/runtime. Thanks to Magnus for helping out with changes to the make files. Bug: https://bugs.openjdk.java.net/browse/JDK-8246436 Webrev: http://cr.openjdk.java.net/~egahlin/8246

Re: RFR: JDK-8213214: Set -Djava.io.tmpdir= when running tests

2020-06-17 Thread Sergey Bylokhov
On 6/17/20 6:11 am, Erik Joelsson wrote: On 2020-06-16 23:25, Sergey Bylokhov wrote: As far as I understand this new temp folder will be cleaned after every tests run, doesn't it look like a workaround for problematic tests and product bugs? This new tmp folder is created in the jtreg test-supp

Re: [OpenJDK 2D-Dev] RFR: 8246032: Implementation of JEP 347: Adopt C++14 Language Features in HotSpot

2020-06-17 Thread Kim Barrett
> On Jun 15, 2020, at 7:41 AM, Kim Barrett wrote: > >> On Jun 14, 2020, at 12:45 AM, Philip Race wrote: >> >> Kim, >> >> >> Until it says in "the JDK" and not "in HotSpot" you have not addressed my >> main point. >> Please rename the JEP. After some off-list discussions I have a better idea