Re: RFR: 8250876: Build system preparation to macos on aarch64

2020-08-10 Thread Erik Joelsson
Looks good. /Erik On 2020-08-10 07:14, Vladimir Kempik wrote: Hello Please check the updated webrev - http://cr.openjdk.java.net/~vkempik/8250876/webrev.02/ Thanks, Vladimir 10 авг. 2020 г., в 16:11, Erik Joelsson написал(а): On 2020-08-10 03:47, Vladimir Kempik wrote: Hello Renamed the

Re: RFR: 8250876: Build system preparation to macos on aarch64

2020-08-10 Thread Vladimir Kempik
Hello Please check the updated webrev - http://cr.openjdk.java.net/~vkempik/8250876/webrev.02/ Thanks, Vladimir > 10 авг. 2020 г., в 16:11, Erik Joelsson написал(а): > > On 2020-08-10 03:47, Vladimir Kempik wrote: >> Hello >> >> Renamed the bug to "Fix issues with cross-compile on macos" >> >

Re: RFR: 8250876: Build system preparation to macos on aarch64

2020-08-10 Thread Erik Joelsson
Yes, exactly. /Erik On 2020-08-10 06:16, Vladimir Kempik wrote: Hello Erik It’s not clear to me, what exactly you want to change in BUILD_CC, add clang to list for macos ? Thanks, Vladimir 10 авг. 2020 г., в 16:11, Erik Joelsson > написал(а): On 2020-08-10

Re: RFR: 8250876: Build system preparation to macos on aarch64

2020-08-10 Thread Vladimir Kempik
Hello Erik It’s not clear to me, what exactly you want to change in BUILD_CC, add clang to list for macos ? Thanks, Vladimir > 10 авг. 2020 г., в 16:11, Erik Joelsson написал(а): > > On 2020-08-10 03:47, Vladimir Kempik wrote: >> Hello >> >> Renamed the bug to "Fix issues with cross-compile o

Re: RFR: 8250876: Build system preparation to macos on aarch64

2020-08-10 Thread Erik Joelsson
On 2020-08-10 03:47, Vladimir Kempik wrote: Hello Renamed the bug to "Fix issues with cross-compile on macos" Please check updated webrev: http://cr.openjdk.java.net/~vkempik/8250876/webrev.01/ Adlc is fine with cross-compiling now. While not strictly needed for ADLC, I would like to see BU

Re: RFR: 8250876: Build system preparation to macos on aarch64

2020-08-10 Thread Vladimir Kempik
Hello Renamed the bug to "Fix issues with cross-compile on macos" Please check updated webrev: http://cr.openjdk.java.net/~vkempik/8250876/webrev.01/ Adlc is fine with cross-compiling now. Regards, Vladimir > 10 авг. 2020 г., в 12:52, M

Re: RFR: 8250876: Build system preparation to macos on aarch64

2020-08-10 Thread Magnus Ihse Bursie
So, basically, what this patch is about is not so much "preparation for aarch64" as "allow cross-compile on macos"?  If I understand you correctly, maybe you should rename the bug? /Magnus On 2020-08-04 16:09, Erik Joelsson wrote: That's a good find! You are correct in that we haven't cross co

Re: RFR(XS): 8251316: Sanity check the JDK under test before running tests

2020-08-10 Thread Magnus Ihse Bursie
On 2020-08-08 14:25, David Holmes wrote: Seems reasonable - at least until jtreg is fixed. I agree; when jtreg is fixed we should revert this, since it's writing output that's not strictly needed, something I've been trying hard to fight. But until then: looks good. /Magnus Where does the h