Hi Erik, Magnus, Mikael, Nick, David, and Alan,
thank you for looking into it. I grouped together all the comments in
one response to avoid polluting the mailing lists. Here is an updated
version of the patch which addresses the comments:
http://cr.openjdk.java.net/~avoitylov/webrev.8247589.06/
On 04/09/2020 08:55, Aleksei Voitylov wrote:
:
Tests tools/launcher/Test7029048.java and
tools/launcher/ExecutionEnvironment.java need to change behavior on
systems that alter LD_LIBRARY_PATH (AIX and musl). The alternative we
first considered was to detect the libc of the OS with ldd in the test
On 04/09/2020 10:00, Alan Bateman wrote:
On 04/09/2020 08:55, Aleksei Voitylov wrote:
:
Tests tools/launcher/Test7029048.java and
tools/launcher/ExecutionEnvironment.java need to change behavior on
systems that alter LD_LIBRARY_PATH (AIX and musl). The alternative we
first considered was to dete
Alan,
in this case I'm leaning towards a new class jdk.test.lib.LibcHelper
with a native implementation which calls (*env)->NewStringUTF(env,
libc), which will be used by the tests which require it. Otherwise we'd
have to specify nativepath for all tests which use
jdk.test.lib.Platform. What do yo
Alan,
here is a simpler version which, for the two tests in question, refers
to a local helper class with a native method:
http://cr.openjdk.java.net/~avoitylov/webrev.8247589.07/
If there is a preference to avoid JNI, there is yet another alternative:
split the two launcher tests in question in