Re: RFR: 8138732: Rename @HotSpotIntrinsicCandidate to @IntrinsicCandidate and move it to the jdk.internal.vm.annotation package

2020-09-07 Thread David Holmes
On Mon, 7 Sep 2020 09:44:09 GMT, Philippe Marschall wrote: > Hello, newbie here > > I picked JDK-8138732 to work on because it has a "starter" label and I > believe I understand what to do. > > - I tried to update the copyright year to 2020 in every file. > - I decided to change `@since` from

Re: RFR: 8138732: Rename @HotSpotIntrinsicCandidate to @IntrinsicCandidate and move it to the jdk.internal.vm.annotation package

2020-09-07 Thread David Holmes
Hi Philippe, On 8/09/2020 3:08 am, Philippe Marschall wrote: Hello, newbie here Welcome aboard! I picked JDK-8138732 to work on because it has a "starter" label and I believe I understand what to do. - I tried to update the copyright year to 2020 in every file. - I decided to change `@sinc

Re: jdk14 build failed cause "The header is deprecated and will be removed."

2020-09-07 Thread David Holmes
Hi, On 5/08/2020 5:46 pm, 451541695 wrote: Hello,  Thanks for providing java for developers.   I am trying to build jdk-14 to use, but failed to build.   The error is following:    My environment:       Linux: Ubuntu 20.04.1 LTS       autoconfig:  I don't know what happened to sysctl.h is on

Re: RFR: 8138732: Rename @HotSpotIntrinsicCandidate to @IntrinsicCandidate and move it to the jdk.internal.vm.annotation package

2020-09-07 Thread Alan Bateman
On Mon, 7 Sep 2020 09:44:09 GMT, Philippe Marschall wrote: > Hello, newbie here > > I picked JDK-8138732 to work on because it has a "starter" label and I > believe I understand what to do. > > - I tried to update the copyright year to 2020 in every file. > - I decided to change `@since` from

RFR: 8138732: Rename @HotSpotIntrinsicCandidate to @IntrinsicCandidate and move it to the jdk.internal.vm.annotation package

2020-09-07 Thread Philippe Marschall
Hello, newbie here I picked JDK-8138732 to work on because it has a "starter" label and I believe I understand what to do. - I tried to update the copyright year to 2020 in every file. - I decided to change `@since` from 9 to 16 since it is a new annotation name in a new package. - I tried to k

Re: RFR: JDK-8251193 bin/idea.sh generating wrong source folders for JVMCI modules

2020-09-07 Thread Maurizio Cimadamore
I've approved - seems to me that you can now just integrate. (otherwise, I could have just typed "/sponsor" if the author did not have commit rights) Maurizio On 07/09/2020 17:00, Severin Gehwolf wrote: Hi, On Thu, 2020-09-03 at 16:48 +0100, Maurizio Cimadamore wrote: Sorry for the delay,

Re: RFR: JDK-8251193 bin/idea.sh generating wrong source folders for JVMCI modules

2020-09-07 Thread Severin Gehwolf
Hi, On Thu, 2020-09-03 at 16:48 +0100, Maurizio Cimadamore wrote: > Sorry for the delay, > overall this looks like a good improvement, so I'll approve. > > Is there some colleague that can help you do the push? > > Let me know if you need help. I'll sponsor the patch for Galder. Yet, sponsoring

jdk14 build failed cause "The header is deprecated and will be removed."

2020-09-07 Thread 451541695
Hello,  Thanks for providing java for developers.   I am trying to build jdk-14 to use, but failed to build.   The error is following:    My environment:       Linux: Ubuntu 20.04.1 LTS       autoconfig:  I don't know what happened to

RE: Crashes on ppc/s390 after 8231441: AArch64: Initial SVE backend support

2020-09-07 Thread Lindenmaier, Goetz
HI, Thanks for the hint! Sounds good, I'll give it a try. ... I removed some emails to reduce traffic. Best regads, Goetz. -Original Message- From: Ningsheng Jian Sent: Montag, 7. September 2020 08:51 To: Lindenmaier, Goetz ; Andrew Dinn ; hotspot-compiler-...@openjdk.java.net;

Re: RFR: JDK-8247589: Implementation of Alpine Linux/x64 Port

2020-09-07 Thread Alan Bateman
On Mon, 7 Sep 2020 11:23:28 GMT, Aleksei Voitylov wrote: > continuing the review thread from here > https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-September/068546.html > >> The download side of using JNI in these tests is that it complicates the >> setup a bit for those that run jt

RFR: JDK-8247589: Implementation of Alpine Linux/x64 Port

2020-09-07 Thread Aleksei Voitylov
continuing the review thread from here https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-September/068546.html > The download side of using JNI in these tests is that it complicates the > setup a bit for those that run jtreg directly and/or just build the JDK > and not the test libraries

Re: RFR: 8251549: Update docs on building for Git

2020-09-07 Thread Sergey Bylokhov
On Mon, 7 Sep 2020 07:20:02 GMT, Magnus Ihse Bursie wrote: >> 8251549: Update docs on building for Git > > doc/building.md line 92: > >> 90: spaces and/or mixed upper and lower case letters. >> 91: >> 92: * Clone the JDK repository using [Git for >> Windows](https://gitforwindows.

Integrated: 8252844: Update check configuration to Skara format

2020-09-07 Thread Robin Westberg
On Mon, 7 Sep 2020 07:19:50 GMT, Robin Westberg wrote: > Now that the JDK main-line repository is using the Skara tooling, the jcheck > configuration file should be updated to > the new format. > Best regards, > Robin This pull request has now been integrated. Changeset: e0c8d442 Author:Ro

Re: RFR: 8252844: Update check configuration to Skara format [v2]

2020-09-07 Thread Robin Westberg
On Mon, 7 Sep 2020 08:01:54 GMT, Erik Helin wrote: >> Robin Westberg has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Apply review suggestion >> >> Co-authored-by: Erik Duveblad > > Looks good! Thanks for reviewing Erik! As this is

Re: RFR: 8252844: Update check configuration to Skara format [v2]

2020-09-07 Thread Erik Helin
On Mon, 7 Sep 2020 08:03:25 GMT, Robin Westberg wrote: >> Now that the JDK main-line repository is using the Skara tooling, the jcheck >> configuration file should be updated to >> the new format. >> Best regards, >> Robin > > Robin Westberg has updated the pull request incrementally with one ad

Re: RFR: 8252844: Update check configuration to Skara format [v2]

2020-09-07 Thread Robin Westberg
> Now that the JDK main-line repository is using the Skara tooling, the jcheck > configuration file should be updated to > the new format. > Best regards, > Robin Robin Westberg has updated the pull request incrementally with one additional commit since the last revision: Apply review suggest

RFR: 8252844: Update check configuration to Skara format

2020-09-07 Thread Robin Westberg
Now that the JDK main-line repository is using the Skara tooling, the jcheck configuration file should be updated to the new format. Best regards, Robin - Commit messages: - Initial update Changes: https://git.openjdk.java.net/jdk/pull/39/files Webrev: https://webrevs.openjdk.jav

Re: RFR: 8251549: Update docs on building for Git

2020-09-07 Thread Magnus Ihse Bursie
On Sat, 5 Sep 2020 20:13:18 GMT, Joe Darcy wrote: > 8251549: Update docs on building for Git Overall looks good, but please restore the recommendation to stick with Cygwin tools. doc/building.md line 92: > 90: spaces and/or mixed upper and lower case letters. > 91: > 92: * Clon