> Hello, newbie here
>
> I picked JDK-8138732 to work on because it has a "starter" label and I
> believe I understand what to do.
>
> - I tried to update the copyright year to 2020 in every file.
> - I decided to change `@since` from 9 to 16 since it is a new annotation name
> in a new package
On Tue, 22 Sep 2020 00:18:07 GMT, Anthony Scarpino
wrote:
>> This change removes the native elliptic curves library code; as well as, and
>> calls to that code, tests, and files
>> associated with those libraries. The makefiles have been changed to remove
>> from all source builds of the ec c
> This change removes the native elliptic curves library code; as well as, and
> calls to that code, tests, and files
> associated with those libraries. The makefiles have been changed to remove
> from all source builds of the ec code. The
> SunEC system property is removed and java.security co
On Mon, 21 Sep 2020 23:50:07 GMT, Erik Joelsson wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> remove JDKOPT_DETECT_INTREE_EC from configure.ac
>
> make/autoconf/jdk-options.m4 line 234:
>
>> 232: # Enable or
On Mon, 21 Sep 2020 21:10:58 GMT, Anthony Scarpino
wrote:
> This change removes the native elliptic curves library code; as well as, and
> calls to that code, tests, and files
> associated with those libraries. The makefiles have been changed to remove
> from all source builds of the ec code.
This change removes the native elliptic curves library code; as well as, and
calls to that code, tests, and files
associated with those libraries. The makefiles have been changed to remove
from all source builds of the ec code. The
SunEC system property is removed and java.security configuratio
> With more CDS related code added to VM, it is time to move CDS code to a
> separate class. CDS is the new class which is
> specific to CDS.
> Tests: tier1-4
Yumin Qi has updated the pull request incrementally with one additional commit
since the last revision:
8253208: Move CDS related code
On Mon, 21 Sep 2020 18:17:55 GMT, Yumin Qi wrote:
>> With more CDS related code added to VM, it is time to move CDS code to a
>> separate class. CDS is the new class which is
>> specific to CDS.
>> Tests: tier1-4
>
> Yumin Qi has updated the pull request incrementally with one additional
> comm
On Mon, 21 Sep 2020 18:17:55 GMT, Yumin Qi wrote:
>> With more CDS related code added to VM, it is time to move CDS code to a
>> separate class. CDS is the new class which is
>> specific to CDS.
>> Tests: tier1-4
>
> Yumin Qi has updated the pull request incrementally with one additional
> comm
On Mon, 21 Sep 2020 18:17:55 GMT, Yumin Qi wrote:
>> With more CDS related code added to VM, it is time to move CDS code to a
>> separate class. CDS is the new class which is
>> specific to CDS.
>> Tests: tier1-4
>
> Yumin Qi has updated the pull request incrementally with one additional
> comm
On Sun, 20 Sep 2020 06:10:53 GMT, Ioi Lam wrote:
>> Yumin Qi has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8253208: Move CDS related code to a separate class
>
> src/java.base/share/native/libjava/CDS.c line 49:
>
>> 47: JNIEXPORT jbo
> With more CDS related code added to VM, it is time to move CDS code to a
> separate class. CDS is the new class which is
> specific to CDS.
> Tests: tier1-4
Yumin Qi has updated the pull request incrementally with one additional commit
since the last revision:
8253208: Move CDS related code
On Mon, 21 Sep 2020 15:30:41 GMT, Robin Westberg wrote:
>> Is there any way to derive the version strings for dependencies from a
>> different source? Once pushed, this file will
>> require updating whenever the bootjdk, jtreg version or gtest version is
>> updated.
>
> Certainly, the prerequis
On Fri, 18 Sep 2020 12:44:13 GMT, Erik Joelsson wrote:
>> A change made to ModuleWrapper.gmk as part of JDK-8244044 means that an
>> included makefile is found in the current
>> directory, so Make doesn't check the include dirs for overriding gmk files.
>> Recommend a minor, partial reversion of
On Mon, 21 Sep 2020 13:59:06 GMT, Erik Joelsson wrote:
>> A few days ago I posted an initial version of the necessary configuration
>> required to run pre-submit build and tests
>> for JDK main-line contributions using GitHub Actions [2] and the free tier
>> [3] available to everyone working wi
On Mon, 21 Sep 2020 08:15:20 GMT, Bernhard Urban-Forster
wrote:
>> Hey @erikj79, thank you so much for giving it a try!
>>
>>> Our linux-aarch64 build fails with this:
>>> cc: error: unrecognized command line option '-std=c++14'
>>> when compiling
>>> build/linux-aarch64/buildjdk/hotspot/varia
> This is a continuation of
> https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2020-August/009566.html
>
> Changes since then:
> * We've improved the write barrier as suggested by Andrew [1]
> * The define-guards around R18 have been changed to `R18_RESERVED`. This will
> be enabled for
On Mon, 21 Sep 2020 13:32:09 GMT, Robin Westberg wrote:
> A few days ago I posted an initial version of the necessary configuration
> required to run pre-submit build and tests
> for JDK main-line contributions using GitHub Actions [2] and the free tier
> [3] available to everyone working with
A few days ago I posted an initial version of the necessary configuration
required to run pre-submit build and tests
for JDK main-line contributions using GitHub Actions [2] and the free tier [3]
available to everyone working with open
source repositories. I've incorporated the feedback into an u
> This pull request is identical with the RFR previously sent for the Mercurial
> repository:
>
> https://mail.openjdk.java.net/pipermail/javadoc-dev/2020-August/001796.html
>
> I'm copy-pasting the comments from the original RFR below.
>
> Most of the new code is added to the Extern class wher
On 21/09/2020 09:18, Bernhard Urban-Forster wrote:
> Thank you Andrew. Is the goal to reduce the patch diff in
> `assembler_aarch64.cpp`? If so, we need to get rid of the
> retry in your patch to avoid additional calls to `random`, e.g. something
> like this (the diff for the generated part
> wou
On Fri, 18 Sep 2020 18:38:34 GMT, Bernhard Urban-Forster
wrote:
>> Our linux-aarch64 build fails with this:
>> cc: error: unrecognized command line option '-std=c++14'
>> when compiling
>> build/linux-aarch64/buildjdk/hotspot/variant-server/libjvm/objs/precompiled/precompiled.hpp.gch
>>
>> I'm
> This is a continuation of
> https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2020-August/009566.html
>
> Changes since then:
> * We've improved the write barrier as suggested by Andrew [1]
> * The define-guards around R18 have been changed to `R18_RESERVED`. This will
> be enabled for
On Fri, 18 Sep 2020 20:34:55 GMT, Erik Joelsson wrote:
> I assume you need the rest of the PATH on Windows.
Doesn't look like it actually. I've reverted it, thanks for catching it.
-
PR: https://git.openjdk.java.net/jdk/pull/212
24 matches
Mail list logo
