Re: RFR: 8253375: OSX build fails with Xcode 12.0 (12A7209)

2020-09-24 Thread Kim Barrett
On Thu, 24 Sep 2020 21:28:01 GMT, Paul Hohensee wrote: > Please review this small patch to enable the OSX build using Xcode 12.0. > > Thanks, > Paul No, don't do this. In the original, double is used to obtain the desired alignmnent. Changing the element type to short reduces the alignment

Integrated: 8235710: Remove the legacy elliptic curves

2020-09-24 Thread Anthony Scarpino
On Mon, 21 Sep 2020 21:10:58 GMT, Anthony Scarpino wrote: > This change removes the native elliptic curves library code; as well as, and > calls to that code, tests, and files > associated with those libraries. The makefiles have been changed to remove > from all source builds of the ec

Re: RFR: 8253375: OSX build fails with Xcode 12.0 (12A7209)

2020-09-24 Thread David Holmes
On Thu, 24 Sep 2020 21:28:01 GMT, Paul Hohensee wrote: > Please review this small patch to enable the OSX build using Xcode 12.0. > > Thanks, > Paul Changes requested by dholmes (Reviewer). src/hotspot/share/runtime/sharedRuntime.cpp line 2851: > 2849: if (buf != NULL) { > 2850:

Re: RFR: 8248238: Implementation of JEP: Windows AArch64 Support [v6]

2020-09-24 Thread David Holmes
Hi Chris, Monica, On 25/09/2020 1:47 am, Chris Plummer wrote: As for the copyright in the new SA files, I believe it is incorrect and needs to include Oracle. There are a number of other non-SA files that are new and also have the same copyright issue. If a file was created completely from

Integrated: 8253615: Change to Visual Studio 2019 16.7.2 for building on Windows at Oracle

2020-09-24 Thread Erik Joelsson
On Thu, 24 Sep 2020 20:25:27 GMT, Erik Joelsson wrote: > Oracle is changing the minor version of Visual Studio used for building the > JDK on Windows. This patch updates the jib > profiles configuration to point to the new devkit. This pull request has now been integrated. Changeset: 24a42489

Re: RFR: 8253616: Change to GCC 10.2 for building on Linux at Oracle

2020-09-24 Thread Erik Joelsson
On Thu, 24 Sep 2020 21:31:49 GMT, Mikael Vidstedt wrote: > Please review this change which updates the defaults in the linux devkit > creator, the doc/building.md file, and the JIB > (Oracle) configuration to gcc 10.2. Marked as reviewed by erikj (Reviewer). - PR:

Re: RFR: 8253615: Change to Visual Studio 2019 16.7.2 for building on Windows at Oracle [v2]

2020-09-24 Thread Mikael Vidstedt
On Thu, 24 Sep 2020 22:20:47 GMT, Erik Joelsson wrote: >> Oracle is changing the minor version of Visual Studio used for building the >> JDK on Windows. This patch updates the jib >> profiles configuration to point to the new devkit. > > Erik Joelsson has updated the pull request incrementally

Re: RFR: 8253615: Change to Visual Studio 2019 16.7.2 for building on Windows at Oracle [v2]

2020-09-24 Thread Erik Joelsson
> Oracle is changing the minor version of Visual Studio used for building the > JDK on Windows. This patch updates the jib > profiles configuration to point to the new devkit. Erik Joelsson has updated the pull request incrementally with one additional commit since the last revision: Update

Re: RFR: 8248238: Implementation of JEP: Windows AArch64 Support [v6]

2020-09-24 Thread Monica Beckwith
On Thu, 24 Sep 2020 15:43:10 GMT, Chris Plummer wrote: >> Monica Beckwith has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev >> excludes the unrelated changes brought in by the merge/rebase. The pull >> request contains 17 additional

Re: RFR: 8235710: Remove the legacy elliptic curves [v3]

2020-09-24 Thread Anthony Scarpino
On Thu, 24 Sep 2020 21:37:14 GMT, Weijun Wang wrote: >> jdk.disabled.namedCurves is commented out and I don't think it's good for >> every operation disabled algorithms call to >> check an empty property. The description for the disabledAlgorithm >> properties say you have to use "include",

Re: RFR: 8253375: OSX build fails with Xcode 12.0 (12A7209)

2020-09-24 Thread Phil Race
On Thu, 24 Sep 2020 21:28:01 GMT, Paul Hohensee wrote: > Please review this small patch to enable the OSX build using Xcode 12.0. > > Thanks, > Paul The awt change looks fine although it would be nice if you could paste the compiler error message into the bug report, since I'd like to see the

Re: RFR: 8235710: Remove the legacy elliptic curves [v3]

2020-09-24 Thread Weijun Wang
On Thu, 24 Sep 2020 21:15:34 GMT, Anthony Scarpino wrote: >> src/java.base/share/conf/security/java.security line 636: >> >>> 634: # >>> 635: jdk.certpath.disabledAlgorithms=MD2, MD5, SHA1 jdkCA & usage >>> TLSServer, \ >>> 636: RSA keySize < 1024, DSA keySize < 1024, EC keySize < 224 >>

RFR: 8253616: Change to GCC 10.2 for building on Linux at Oracle

2020-09-24 Thread Mikael Vidstedt
Please review this change which updates the defaults in the linux devkit creator, the doc/building.md file, and the JIB (Oracle) configuration to gcc 10.2. - Commit messages: - 8253616: Change to GCC 10.2 for building on Linux at Oracle Changes:

RFR: 8253375: OSX build fails with Xcode 12.0 (12A7209)

2020-09-24 Thread Paul Hohensee
Please review this small patch to enable the OSX build using Xcode 12.0. Thanks, Paul - Commit messages: - JDK-8253375 Changes: https://git.openjdk.java.net/jdk/pull/348/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=348=00 Issue:

Re: RFR: 8253615: Change to Visual Studio 2019 16.7.2 for building on Windows at Oracle

2020-09-24 Thread Mikael Vidstedt
On Thu, 24 Sep 2020 20:25:27 GMT, Erik Joelsson wrote: > Oracle is changing the minor version of Visual Studio used for building the > JDK on Windows. This patch updates the jib > profiles configuration to point to the new devkit. Do you want to update doc/building.{md,html} to reflect the

Re: RFR: 8235710: Remove the legacy elliptic curves [v3]

2020-09-24 Thread Anthony Scarpino
On Thu, 24 Sep 2020 19:48:45 GMT, Weijun Wang wrote: >> Anthony Scarpino has updated the pull request incrementally with one >> additional commit since the last revision: >> >> change exception for ec keyagreement >> fix supportedcurves in SunEC > >

Re: RFR: 8235710: Remove the legacy elliptic curves [v3]

2020-09-24 Thread Weijun Wang
On Wed, 23 Sep 2020 23:38:03 GMT, Anthony Scarpino wrote: >> This change removes the native elliptic curves library code; as well as, and >> calls to that code, tests, and files >> associated with those libraries. The makefiles have been changed to remove >> from all source builds of the ec

RFR: 8253615: Change to Visual Studio 2019 16.7.2 for building on Windows at Oracle

2020-09-24 Thread Erik Joelsson
Oracle is changing the minor version of Visual Studio used for building the JDK on Windows. This patch updates the jib profiles configuration to point to the new devkit. - Commit messages: - Bump VS version in jib-profiles Changes: https://git.openjdk.java.net/jdk/pull/346/files

Re: RFR: 8248238: Implementation of JEP: Windows AArch64 Support [v6]

2020-09-24 Thread Chris Plummer
On Thu, 24 Sep 2020 14:04:22 GMT, Monica Beckwith wrote: >> This is a continuation of >> https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2020-August/009566.html >> >> Changes since then: >> * We've improved the write barrier as suggested by Andrew [1] >> * The define-guards around

Integrated: 8253500: [REDO] JDK-8253208 Move CDS related code to a separate class

2020-09-24 Thread Yumin Qi
On Wed, 23 Sep 2020 23:05:59 GMT, Yumin Qi wrote: > This patch is a REDO for JDK-8253208 which was backed out since it caused > runtime/cds/DeterministicDump.java failed, > see JDK-8253495. Since the failure is another issue and only triggered by > this patch, the test case now is put on >

Re: RFR: 8253500: [REDO] JDK-8253208 Move CDS related code to a separate class

2020-09-24 Thread Erik Joelsson
On Wed, 23 Sep 2020 23:05:59 GMT, Yumin Qi wrote: > This patch is a REDO for JDK-8253208 which was backed out since it caused > runtime/cds/DeterministicDump.java failed, > see JDK-8253495. Since the failure is another issue and only triggered by > this patch, the test case now is put on >

Re: RFR: 8248238: Implementation of JEP: Windows AArch64 Support [v5]

2020-09-24 Thread Bernhard Urban-Forster
On Thu, 24 Sep 2020 04:52:22 GMT, David Holmes wrote: >> Monica Beckwith has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update orderAccess_windows_aarch64.hpp >> >> changing from Acq-reL to Sequential Consistency to avoid compiler

Re: RFR: 8248238: Implementation of JEP: Windows AArch64 Support [v7]

2020-09-24 Thread Monica Beckwith
> This is a continuation of > https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2020-August/009566.html > > Changes since then: > * We've improved the write barrier as suggested by Andrew [1] > * The define-guards around R18 have been changed to `R18_RESERVED`. This will > be enabled

Re: RFR: 8248238: Implementation of JEP: Windows AArch64 Support [v5]

2020-09-24 Thread Bernhard Urban-Forster
On Thu, 24 Sep 2020 04:45:16 GMT, David Holmes wrote: >> Monica Beckwith has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update orderAccess_windows_aarch64.hpp >> >> changing from Acq-reL to Sequential Consistency to avoid compiler

Re: RFR: 8248238: Implementation of JEP: Windows AArch64 Support [v6]

2020-09-24 Thread Monica Beckwith
> This is a continuation of > https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2020-August/009566.html > > Changes since then: > * We've improved the write barrier as suggested by Andrew [1] > * The define-guards around R18 have been changed to `R18_RESERVED`. This will > be enabled

Re: RFR: 8253424: Add support for running pre-submit testing using GitHub Actions [v4]

2020-09-24 Thread Robin Westberg
> A few days ago I posted an initial version of the necessary configuration > required to run pre-submit build and tests > for JDK main-line contributions using GitHub Actions [2] and the free tier > [3] available to everyone working with open > source repositories. I've incorporated the

Re: RFR: 8248984: Bump minimum boot jdk to JDK 15

2020-09-24 Thread Robin Westberg
On Wed, 23 Sep 2020 22:47:47 GMT, Erik Joelsson wrote: >> JDK 15 is now GA. The minimum boot JDK version for mainline/JDK 16 should be >> bumped to this version. >> >> Testing: tier1-5 passed with a slightly earlier version of this change. >> Re-running tier1 now for good luck. > > @rwestberg