On Tue, 29 Sep 2020 19:33:48 GMT, Paul Hohensee wrote:
>> Please review this small patch to enable the OSX build using Xcode 12.0.
>>
>> Thanks,
>> Paul
>
> Paul Hohensee has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev
> excludes the
> This patch is reorganized after 8252725, which is separated from this patch
> to refactor jlink glugin code. The previous
> webrev with hg can be found at:
> http://cr.openjdk.java.net/~minqi/2020/8247536/webrev-05. With 8252725
> integrated, the
> regeneration of holder classes is simply to
On Tue, 29 Sep 2020 22:00:04 GMT, Erik Joelsson wrote:
>> This pull request is for integration of the Vector API. It was previously
>> reviewed under conditions when mercurial was
>> used for the source code control system. Review threads can be found here
>> (searching for issue number
On Tue, 29 Sep 2020 14:08:49 GMT, Monica Beckwith wrote:
>> This is a continuation of
>> https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2020-August/009566.html
>>
>> Changes since then:
>> * We've improved the write barrier as suggested by Andrew [1]
>> * The define-guards around
Hmm. I'm running Xcode 12.0.1 on 10.15.6 and don't see it. Are you sure you
have the '&' in front of locs_buf? I.e.,
buffer.insts()->initialize_shared_locs((relocInfo*)_buf,
sizeof(locs_buf) / sizeof(relocInfo));
On Fri, 25 Sep 2020 20:14:29 GMT, Paul Sandoz wrote:
> This pull request is for integration of the Vector API. It was previously
> reviewed under conditions when mercurial was
> used for the source code control system. Review threads can be found here
> (searching for issue number 8223347 in
This pull request is for integration of the Vector API. It was previously
reviewed under conditions when mercurial was
used for the source code control system. Review threads can be found here
(searching for issue number 8223347 in the
title):
> On Sep 29, 2020, at 4:05 PM, Lutz Schmidt wrote:
>
> On Tue, 29 Sep 2020 19:33:48 GMT, Paul Hohensee wrote:
>
>>> Please review this small patch to enable the OSX build using Xcode 12.0.
>>>
>>> Thanks,
>>> Paul
>>
>> Paul Hohensee has updated the pull request with a new target base due to
On Tue, 29 Sep 2020 14:08:49 GMT, Monica Beckwith wrote:
>> This is a continuation of
>> https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2020-August/009566.html
>>
>> Changes since then:
>> * We've improved the write barrier as suggested by Andrew [1]
>> * The define-guards around
On Tue, 29 Sep 2020 14:03:57 GMT, Bernhard Urban-Forster
wrote:
>> Marked as reviewed by aph (Reviewer).
>
> @theRealAph okay, I've changed the string representation of `r18` to
> `"r18_tls"` on every platform.
> @plummercj thank you for your feedback. I've updated the copyright in
>
On Tue, 29 Sep 2020 19:33:48 GMT, Paul Hohensee wrote:
>> Please review this small patch to enable the OSX build using Xcode 12.0.
>>
>> Thanks,
>> Paul
>
> Paul Hohensee has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev
> excludes the
On Tue, 29 Sep 2020 19:33:48 GMT, Paul Hohensee wrote:
>> Please review this small patch to enable the OSX build using Xcode 12.0.
>>
>> Thanks,
>> Paul
>
> Paul Hohensee has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev
> excludes the
> Please review this small patch to enable the OSX build using Xcode 12.0.
>
> Thanks,
> Paul
Paul Hohensee has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev
excludes the unrelated changes brought in by the merge/rebase. The pull request
> On Sep 29, 2020, at 10:18 AM, Hohensee, Paul wrote:
> Code that calls initialize_shared_locs is inconsistent even within itself.
> E.g., in c1_Compilation.cpp, we have
Agreed there seems to be a bit of a mess around that function.
> Anyway, I just wanted to make the compiler warning go away,
> Hi, Matthias, Kim. No problem opening a separate issue to fix CSystemColors.m.
Hi Paul, did that :
https://bugs.openjdk.java.net/browse/JDK-8253791
https://github.com/openjdk/jdk/pull/403
Best regards, Matthias
-Original Message-
From: Hohensee, Paul
Sent: Dienstag, 29.
Thanks for the reviews/discussion, and apologies for the delayed reply: I've
been OOTO.
Kim is correct, initialize_shared_locs specifically adjusts the alignment of
its buffer argument, which is why short works. char would work as well, but
short happens to be the size of a relocInfo. Maybe
> This is a continuation of
> https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2020-August/009566.html
>
> Changes since then:
> * We've improved the write barrier as suggested by Andrew [1]
> * The define-guards around R18 have been changed to `R18_RESERVED`. This will
> be enabled
On Tue, 29 Sep 2020 07:11:34 GMT, Matthias Baesken wrote:
>> src/java.desktop/macosx/native/libawt_lwawt/awt/CSystemColors.m line 129:
>>
>>> 127: NSColor* result = nil;
>>> 128:
>>> 129: if (colorIndex < ((useAppleColor) ?
>>> sun_lwawt_macosx_LWCToolkit_NUM_APPLE_COLORS :
>>>
On Fri, 25 Sep 2020 12:44:37 GMT, Andrew Haley wrote:
>> Monica Beckwith has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - os_windows: remove duplicated UMA handling
>> - test_safefetch{32,N} works fine on win+aarch64
>
> Marked as
Hi, Matthias, Kim. No problem opening a separate issue to fix CSystemColors.m.
Thanks,
Paul
On 9/29/20, 4:23 AM, "hotspot-dev on behalf of Kim Barrett"
wrote:
> On Sep 29, 2020, at 3:14 AM, Matthias Baesken
wrote:
>
> On Fri, 25 Sep 2020 06:06:31 GMT, Kim Barrett
wrote:
>
> On Sep 29, 2020, at 3:59 AM, Matthias Baesken
> wrote:
>
> On Fri, 25 Sep 2020 02:23:07 GMT, David Holmes wrote:
>
>>> Please review this small patch to enable the OSX build using Xcode 12.0.
>>>
>>> Thanks,
>>> Paul
>>
>> src/hotspot/share/runtime/sharedRuntime.cpp line 2851:
>>
>>>
> On Sep 29, 2020, at 3:14 AM, Matthias Baesken
> wrote:
>
> On Fri, 25 Sep 2020 06:06:31 GMT, Kim Barrett wrote:
>
>>> Please review this small patch to enable the OSX build using Xcode 12.0.
>>>
>>> Thanks,
>>> Paul
>>
>> src/java.desktop/macosx/native/libawt_lwawt/awt/CSystemColors.m
On Mon, 28 Sep 2020 19:53:37 GMT, Monica Beckwith wrote:
>> This is a continuation of
>> https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2020-August/009566.html
>>
>> Changes since then:
>> * We've improved the write barrier as suggested by Andrew [1]
>> * The define-guards around
On 28/09/2020 20:12, Bernhard Urban-Forster wrote:
> The idea is that the naming should suggest that `r18` shouldn't be used on
> that particular platform. Same is true for
> macOS, but the ABI docs suggest a different usage, hence we have something
> like that in our internal branch for macOS:
On 28/09/2020 20:12, Bernhard Urban-Forster wrote:
> The idea is that the naming should suggest that `r18` shouldn't be used on
> that particular platform. Same is true for
> macOS, but the ABI docs suggest a different usage, hence we have something
> like that in our internal branch for macOS:
On Fri, 25 Sep 2020 02:23:07 GMT, David Holmes wrote:
>> Please review this small patch to enable the OSX build using Xcode 12.0.
>>
>> Thanks,
>> Paul
>
> src/hotspot/share/runtime/sharedRuntime.cpp line 2851:
>
>> 2849: if (buf != NULL) {
>> 2850: CodeBuffer buffer(buf);
>> 2851:
On Fri, 25 Sep 2020 06:06:31 GMT, Kim Barrett wrote:
>> Please review this small patch to enable the OSX build using Xcode 12.0.
>>
>> Thanks,
>> Paul
>
> src/java.desktop/macosx/native/libawt_lwawt/awt/CSystemColors.m line 129:
>
>> 127: NSColor* result = nil;
>> 128:
>> 129: if
On Mon, 28 Sep 2020 19:53:37 GMT, Monica Beckwith wrote:
>> This is a continuation of
>> https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2020-August/009566.html
>>
>> Changes since then:
>> * We've improved the write barrier as suggested by Andrew [1]
>> * The define-guards around
28 matches
Mail list logo
