Re: RFR: 8254162: Implementation of Foreign-Memory Access API (Third Incubator)

2020-10-07 Thread Erik Joelsson
On Wed, 7 Oct 2020 17:13:22 GMT, Maurizio Cimadamore wrote: > This patch contains the changes associated with the third incubation round of > the foreign memory access API incubation > (see JEP 393 [1]). This iteration focus on improving the usability of the API > in 3 main ways: > * first, by

Re: build openjdk8 with some problems

2020-10-07 Thread David Holmes
Hi, On 7/10/2020 7:44 pm, wrote: hello everyone ,I build openjdk but found something problem, no help useful information on internet. so ask for help, thinks! I can execute ./configure sucess , but execute "make all"   failture. the details as follows my build contexts Microsoft Wind

Re: RFR: 8247536: Support for pre-generated java.lang.invoke classes in CDS static archive [v13]

2020-10-07 Thread Yumin Qi
> This patch is reorganized after 8252725, which is separated from this patch > to refactor jlink glugin code. The previous > webrev with hg can be found at: > http://cr.openjdk.java.net/~minqi/2020/8247536/webrev-05. With 8252725 > integrated, the > regeneration of holder classes is simply to c

Re: RFR: 8247536: Support for pre-generated java.lang.invoke classes in CDS static archive [v11]

2020-10-07 Thread Yumin Qi
On Tue, 6 Oct 2020 18:12:50 GMT, Mandy Chung wrote: >> Yumin Qi has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Removed unused imports. > > src/java.base/share/classes/jdk/internal/misc/CDS.java line 83: > >> 81: * check if -XX:+Du

Re: RFR: 8247536: Support for pre-generated java.lang.invoke classes in CDS static archive [v12]

2020-10-07 Thread Yumin Qi
On Wed, 7 Oct 2020 17:48:41 GMT, Ioi Lam wrote: >> Yumin Qi has updated the pull request with a new target base due to a merge >> or a rebase. The pull request now contains >> 23 commits: >> - Added new separate function to CDS for logging species and modified the >> existing function to log l

Integrated: 8254102: use ProcessHandle::pid instead of ManagementFactory::getRuntimeMXBean to get pid in tests

2020-10-07 Thread Igor Ignatyev
On Tue, 6 Oct 2020 23:08:40 GMT, Igor Ignatyev wrote: > Hi all, > > could you please review this small cleanup which replaces > `ManagementFactory.getRuntimeMXBean().getName().split("@")[0]` w/ > `ProcessHandle.current().pid()` to get current > process pid? Thanks, > -- Igor This pull request

Re: RFR: 8254102: use ProcessHandle::pid instead of ManagementFactory::getRuntimeMXBean to get pid in tests [v2]

2020-10-07 Thread Igor Ignatyev
On Wed, 7 Oct 2020 18:38:07 GMT, Roger Riggs wrote: >> Igor Ignatyev has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - use Long.toString instead of String.valueOf >> - remove explicit coversion to String in Suicide.java > > Marked as re

Re: RFR: 8254102: use ProcessHandle::pid instead of ManagementFactory::getRuntimeMXBean to get pid in tests [v2]

2020-10-07 Thread Roger Riggs
On Wed, 7 Oct 2020 18:12:19 GMT, Igor Ignatyev wrote: >> Hi all, >> >> could you please review this small cleanup which replaces >> `ManagementFactory.getRuntimeMXBean().getName().split("@")[0]` w/ >> `ProcessHandle.current().pid()` to get current >> process pid? Thanks, >> -- Igor > > Igor Ig

Re: RFR: 8254102: use ProcessHandle::pid instead of ManagementFactory::getRuntimeMXBean to get pid in tests [v2]

2020-10-07 Thread Igor Ignatyev
On Wed, 7 Oct 2020 06:30:43 GMT, Aleksey Shipilev wrote: >> test/failure_handler/test/sanity/Suicide.java line 36: >> >>> 34: String osName = System.getProperty("os.name"); >>> 35: if (osName.contains("Windows")) { >>> 36: cmd = "taskkill.exe /F /PID " + p

Re: RFR: 8254102: use ProcessHandle::pid instead of ManagementFactory::getRuntimeMXBean to get pid in tests [v2]

2020-10-07 Thread Aleksey Shipilev
On Wed, 7 Oct 2020 18:09:28 GMT, Igor Ignatyev wrote: >> Hi all, >> >> could you please review this small cleanup which replaces >> `ManagementFactory.getRuntimeMXBean().getName().split("@")[0]` w/ >> `ProcessHandle.current().pid()` to get current >> process pid? Thanks, >> -- Igor > > Igor Ig

Re: RFR: 8254102: use ProcessHandle::pid instead of ManagementFactory::getRuntimeMXBean to get pid in tests [v2]

2020-10-07 Thread Igor Ignatyev
> Hi all, > > could you please review this small cleanup which replaces > `ManagementFactory.getRuntimeMXBean().getName().split("@")[0]` w/ > `ProcessHandle.current().pid()` to get current > process pid? Thanks, > -- Igor Igor Ignatyev has updated the pull request incrementally with two additio

Re: RFR: 8247536: Support for pre-generated java.lang.invoke classes in CDS static archive [v12]

2020-10-07 Thread Ioi Lam
On Tue, 6 Oct 2020 20:46:17 GMT, Yumin Qi wrote: >> This patch is reorganized after 8252725, which is separated from this patch >> to refactor jlink glugin code. The previous >> webrev with hg can be found at: >> http://cr.openjdk.java.net/~minqi/2020/8247536/webrev-05. With 8252725 >> integra

RFR: 8254162: Implementation of Foreign-Memory Access API (Third Incubator)

2020-10-07 Thread Maurizio Cimadamore
This patch contains the changes associated with the third incubation round of the foreign memory access API incubation (see JEP 393 [1]). This iteration focus on improving the usability of the API in 3 main ways: * first, by providing a way to obtain truly *shared* segments, which can be access

RFR: 8254175: Build no-pch configuration in debug mode for submit checks

2020-10-07 Thread Aleksey Shipilev
no-pch configuration is supposed to expose missing include dependencies. But currently it runs with default (release) bits, which misses symbols hidden in debug code. We should consider building it in debug mode. Testing: - [x] GH workflow still works, see the builds in the [latest run](https

Re: RFR: 8254173: Add Zero, Minimal hotspot targets to submit workflow [v2]

2020-10-07 Thread Aleksey Shipilev
> Zero VM and Minimal VM builds are routinely discovering the problems with > internal Hotspot dependencies. Mostly because > they turn off the whole lot of VM features, and every path that is not > guarded by a feature #ifdef or build file list > fails. It would be good to add Zero and Minimal

RFR: 8254173: Add Zero, Minimal hotspot targets to submit workflow

2020-10-07 Thread Aleksey Shipilev
Zero VM and Minimal VM builds are routinely discovering the problems with internal Hotspot dependencies. Mostly because they turn off the whole lot of VM features, and every path that is not guarded by a feature #ifdef or build file list fails. It would be good to add Zero and Minimal targets to

build openjdk8 with some problems

2020-10-07 Thread ????????
hello everyone ,I build openjdk but found something problem, no help useful information on internet. so ask for help, thinks! I can execute ./configure sucess , but execute "make all"   failture. the details as follows my build contexts Microsoft Windows 10  Visual Studio 2010 bootstra

Integrated: 8216497: javadoc should auto-link to platform classes

2020-10-07 Thread Hannes Wallnöfer
On Tue, 15 Sep 2020 09:10:54 GMT, Hannes Wallnöfer wrote: > This pull request is identical with the RFR previously sent for the Mercurial > repository: > > https://mail.openjdk.java.net/pipermail/javadoc-dev/2020-August/001796.html > > I'm copy-pasting the comments from the original RFR below.

Re: RFR: 8216497: javadoc should auto-link to platform classes [v4]

2020-10-07 Thread Hannes Wallnöfer
> This pull request is identical with the RFR previously sent for the Mercurial > repository: > > https://mail.openjdk.java.net/pipermail/javadoc-dev/2020-August/001796.html > > I'm copy-pasting the comments from the original RFR below. > > Most of the new code is added to the Extern class wher

Re: RFR: 8253000: Remove redundant MAKE_SUBDIR argument

2020-10-07 Thread Adam Farley
On Fri, 18 Sep 2020 12:43:05 GMT, Erik Joelsson wrote: >> As part of JDK-8244044, MAKE_SUBDIR is no longer used in >> DeclareRecipesForPhase inside MakeSupport.gmk. >> >> Therefore, it seems sensible to modify the instances where this is passed to >> DeclareRecipesForPhase, and to remove >> re

Integrated: 8253000: Remove redundant MAKE_SUBDIR argument

2020-10-07 Thread Adam Farley
On Fri, 18 Sep 2020 11:37:06 GMT, Adam Farley wrote: > As part of JDK-8244044, MAKE_SUBDIR is no longer used in > DeclareRecipesForPhase inside MakeSupport.gmk. > > Therefore, it seems sensible to modify the instances where this is passed to > DeclareRecipesForPhase, and to remove > references

Re: RFR: 8253757: Add LLVM-based backend for hsdis

2020-10-07 Thread Xin Liu
On Wed, 7 Oct 2020 00:48:24 GMT, Yasumasa Suenaga wrote: >> This is an interesting suggestion. There is a similar attempt at replacing >> binutils with capstone in >> https://bugs.openjdk.java.net/browse/JDK-8188073, which unfortunately has >> not seen much progress due to lack of >> resources;