Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v4]

2020-10-15 Thread Coleen Phillimore
On Thu, 15 Oct 2020 17:08:28 GMT, Maurizio Cimadamore wrote: >> This patch contains the changes associated with the first incubation round >> of the foreign linker access API incubation >> (see JEP 389 [1]). This work is meant to sit on top of the foreign memory >> access support (see JEP 393

Re: RFR: 8254072: AArch64: Get rid of --disable-warnings-as-errors on Windows+ARM64 build [v3]

2020-10-15 Thread Bernhard Urban-Forster
On Thu, 15 Oct 2020 17:24:56 GMT, Stuart Monteith wrote: >> Bernhard Urban-Forster has updated the pull request with a new target base >> due to a merge or a rebase. The pull request >> now contains 20 commits: >> - disable warning only for hotspot >> - Merge remote-tracking branch

Re: RFR: 8254072: AArch64: Get rid of --disable-warnings-as-errors on Windows+ARM64 build [v2]

2020-10-15 Thread Bernhard Urban-Forster
On Thu, 15 Oct 2020 09:57:14 GMT, Andrew Haley wrote: > Fine, but please assert JavaThread::stack_shadow_zone_size() == > (int)JavaThread::stack_shadow_zone_size(). Done. > Adding casts to shut up compilers is a very risky business, because often (if > not in this case) the programmer

Re: RFR: 8254072: AArch64: Get rid of --disable-warnings-as-errors on Windows+ARM64 build [v4]

2020-10-15 Thread Bernhard Urban-Forster
> I organized this PR so that each commit contains the warning emitted by MSVC > as commit message and its relevant fix. > > Verified on > * Linux+ARM64: `{hotspot,jdk,langtools}:tier1`, no failures. > * Windows+ARM64: `{hotspot,jdk,langtools}:tier1`, no (new) failures. > * internal macOS+ARM64

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator)

2020-10-15 Thread Jorn Vernee
On Tue, 13 Oct 2020 13:08:14 GMT, Maurizio Cimadamore wrote: > This patch contains the changes associated with the first incubation round of > the foreign linker access API incubation > (see JEP 389 [1]). This work is meant to sit on top of the foreign memory > access support (see JEP 393 [2]

Re: RFR: 8254072: AArch64: Get rid of --disable-warnings-as-errors on Windows+ARM64 build [v3]

2020-10-15 Thread Stuart Monteith
On Thu, 15 Oct 2020 08:57:27 GMT, Bernhard Urban-Forster wrote: >> I organized this PR so that each commit contains the warning emitted by MSVC >> as commit message and its relevant fix. >> >> Verified on >> * Linux+ARM64: `{hotspot,jdk,langtools}:tier1`, no failures. >> * Windows+ARM64:

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v4]

2020-10-15 Thread Maurizio Cimadamore
> This patch contains the changes associated with the first incubation round of > the foreign linker access API incubation > (see JEP 389 [1]). This work is meant to sit on top of the foreign memory > access support (see JEP 393 [2] and > associated pull request [3]). > The main goal of this API

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v3]

2020-10-15 Thread Maurizio Cimadamore
> This patch contains the changes associated with the first incubation round of > the foreign linker access API incubation > (see JEP 389 [1]). This work is meant to sit on top of the foreign memory > access support (see JEP 393 [2] and > associated pull request [3]). > The main goal of this API

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v2]

2020-10-15 Thread Maurizio Cimadamore
> This patch contains the changes associated with the first incubation round of > the foreign linker access API incubation > (see JEP 389 [1]). This work is meant to sit on top of the foreign memory > access support (see JEP 393 [2] and > associated pull request [3]). > The main goal of this API

RFR: 8254827: JVMCI: Enable it for Windows+AArch64

2020-10-15 Thread Bernhard Urban-Forster
Use r18 as allocatable register on Linux only. A bootstrap works now (it has been crashing before due to r18 being allocated): $ ./windows-aarch64-server-fastdebug/bin/java.exe -XX:+UnlockExperimentalVMOptions -XX:+UseJVMCICompiler -XX:+BootstrapJVMCI -version Bootstrapping

Re: RFR: JDK-8252870: Finalize (remove "incubator" from) jpackage [v3]

2020-10-15 Thread Andy Herrick
> JDK-8252870: Finalize (remove "incubator" from) jpackage Andy Herrick has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits: - Merge branch 'master' into JDK-8252870 - JDK-8252870: Finalize (remove "incubator" from)

Re: RFR: 8254072: AArch64: Get rid of --disable-warnings-as-errors on Windows+ARM64 build [v2]

2020-10-15 Thread Andrew Haley
On Thu, 15 Oct 2020 09:02:35 GMT, Bernhard Urban-Forster wrote: >> Changes requested by ihse (Reviewer). > > @theRealAph I prototyped changing the argument of `bang_stack_with_offset()` > from `int` to `size_t` here: >

Re: RFR: 8254072: AArch64: Get rid of --disable-warnings-as-errors on Windows+ARM64 build [v2]

2020-10-15 Thread Bernhard Urban-Forster
On Mon, 12 Oct 2020 10:29:23 GMT, Magnus Ihse Bursie wrote: >> Bernhard Urban-Forster has updated the pull request with a new target base >> due to a merge or a rebase. The pull request >> now contains 18 commits: >> - Merge remote-tracking branch 'upstream/master' into >>

Re: RFR: 8254072: AArch64: Get rid of --disable-warnings-as-errors on Windows+ARM64 build [v2]

2020-10-15 Thread Bernhard Urban-Forster
On Mon, 12 Oct 2020 10:29:11 GMT, Magnus Ihse Bursie wrote: >> Bernhard Urban-Forster has updated the pull request with a new target base >> due to a merge or a rebase. The pull request >> now contains 18 commits: >> - Merge remote-tracking branch 'upstream/master' into >>

Re: RFR: 8254072: AArch64: Get rid of --disable-warnings-as-errors on Windows+ARM64 build [v3]

2020-10-15 Thread Bernhard Urban-Forster
> I organized this PR so that each commit contains the warning emitted by MSVC > as commit message and its relevant fix. > > Verified on > * Linux+ARM64: `{hotspot,jdk,langtools}:tier1`, no failures. > * Windows+ARM64: `{hotspot,jdk,langtools}:tier1`, no (new) failures. > * internal macOS+ARM64