Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v8]

2020-10-21 Thread Maurizio Cimadamore
> This patch contains the changes associated with the first incubation round of > the foreign linker access API incubation > (see JEP 389 [1]). This work is meant to sit on top of the foreign memory > access support (see JEP 393 [2] and associated pull request [3]). > > The main goal of this API

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v9]

2020-10-21 Thread Maurizio Cimadamore
> This patch contains the changes associated with the first incubation round of > the foreign linker access API incubation > (see JEP 389 [1]). This work is meant to sit on top of the foreign memory > access support (see JEP 393 [2] and associated pull request [3]). > > The main goal of this API

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v4]

2020-10-21 Thread Jorn Vernee
On Mon, 19 Oct 2020 11:24:45 GMT, Jorn Vernee wrote: >> I looked through some Hotspot runtime code and that looks ok. I saw a >> couple of strange things on my way through the code. See comments. > > Hi David, this code somewhat predates me, so I initially kept the JVM_ENTRY > since that was

Re: RFR: 8188055: (ref) Add Reference::refersTo predicate [v6]

2020-10-21 Thread Magnus Ihse Bursie
On Wed, 21 Oct 2020 02:28:30 GMT, Kim Barrett wrote: >> Finally returning to this review that was started in April 2020. I've >> recast it as a github PR. I think the security concern raised by Gil >> has been adequately answered. >> https://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2020-A

Re: RFR: 8188055: (ref) Add Reference::refersTo predicate [v6]

2020-10-21 Thread Magnus Ihse Bursie
On Wed, 21 Oct 2020 02:55:49 GMT, David Holmes wrote: >> Kim Barrett has updated the pull request incrementally with one additional >> commit since the last revision: >> >> improve wording in refersTo javadoc > > Update looks good. Need to reflect the change in the CSR. > > Thanks. > David

Re: RFR: JDK-8250768: javac should be adapted to changes in JEP 12 [v2]

2020-10-21 Thread Hannes Wallnöfer
On Tue, 20 Oct 2020 12:15:23 GMT, Jan Lahoda wrote: >> This is an update to javac and javadoc, to introduce support for Preview >> APIs, and generally improve javac and javadoc behavior to more closely >> adhere to JEP 12. >> >> The notable changes are: >> >> * adding support for Preview API

Re: RFR: 8206311: Add docs-javase, docs-reference to CI build [v2]

2020-10-21 Thread Erik Joelsson
> Reposting this review as PR. > > In order to regularly build the javase and reference docs images, I have made > the following changes: > > 1. Introduced bundle targets for the javase and reference docs images. > 2. To run this in CI without adding more unnecessary build time to the > linux-x

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v9]

2020-10-21 Thread Paul Sandoz
On Wed, 21 Oct 2020 11:33:27 GMT, Maurizio Cimadamore wrote: >> This patch contains the changes associated with the first incubation round >> of the foreign linker access API incubation >> (see JEP 389 [1]). This work is meant to sit on top of the foreign memory >> access support (see JEP 393

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v7]

2020-10-21 Thread Paul Sandoz
On Tue, 20 Oct 2020 17:23:26 GMT, Maurizio Cimadamore wrote: >> This patch contains the changes associated with the first incubation round >> of the foreign linker access API incubation >> (see JEP 389 [1]). This work is meant to sit on top of the foreign memory >> access support (see JEP 393

Re: RFR: JDK-8252870: Finalize (remove "incubator" from) jpackage [v4]

2020-10-21 Thread Andy Herrick
> JDK-8252870: Finalize (remove "incubator" from) jpackage Andy Herrick has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits: - Merge branch master into JDK-8252870 - Merge branch 'master' into JDK-8252870 - JDK-8252870: Fi

Integrated: 8206311: Add docs-javase, docs-reference to CI build

2020-10-21 Thread Erik Joelsson
On Wed, 9 Sep 2020 22:50:52 GMT, Erik Joelsson wrote: > Reposting this review as PR. > > In order to regularly build the javase and reference docs images, I have made > the following changes: > > 1. Introduced bundle targets for the javase and reference docs images. > 2. To run this in CI with