Re: RFR: JDK-8255620: Build race between modulegraphs and exploded-image-optimize targets

2020-10-29 Thread Tim Bell
On Thu, 29 Oct 2020 22:00:52 GMT, Erik Joelsson wrote: > When I reorganized top level docs build targets in JDK-8206311, a race was > introduced. The docs-*-modulegraph targets use the BUILD_JDK to run a build > tool. For this to work, the BUILD_JDK needs to be ready for usage. In a > normal

Re: RFR: 8254072: AArch64: Get rid of --disable-warnings-as-errors on Windows+ARM64 build [v4]

2020-10-29 Thread Bernhard Urban-Forster
On Tue, 27 Oct 2020 14:04:04 GMT, Andrew Haley wrote: >> Bernhard Urban-Forster has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - uppercase suffix >> - add assert > > Marked as reviewed by aph (Reviewer). Would you mind sponsor it

RFR: JDK-8255620: Build race between modulegraphs and exploded-image-optimize targets

2020-10-29 Thread Erik Joelsson
When I reorganized top level docs build targets in JDK-8206311, a race was introduced. The docs-*-modulegraph targets use the BUILD_JDK to run a build tool. For this to work, the BUILD_JDK needs to be ready for usage. In a normal native build, this means that the exploded-image-optimize target

Re: RFR: JDK-8255612: Explicitly disable dtrace for Oracle OpenJDK Linux builds

2020-10-29 Thread Mikael Vidstedt
On Thu, 29 Oct 2020 20:53:00 GMT, Erik Joelsson wrote: > The OpenJDK build on Linux will determine if the JVM feature "dtrace" should > be enabled based on the availability of dtrace on the build host. For Oracle > produced OpenJDK builds, we implicitly had this disabled because our build >

RFR: JDK-8255612: Explicitly disable dtrace for Oracle OpenJDK Linux builds

2020-10-29 Thread Erik Joelsson
The OpenJDK build on Linux will determine if the JVM feature "dtrace" should be enabled based on the availability of dtrace on the build host. For Oracle produced OpenJDK builds, we implicitly had this disabled because our build environment didn't have it installed. Rather than having to trust

RFR: 8247781: Day periods support

2020-10-29 Thread Naoto Sato
Hi, Please review the changes for the subject issue. This is to enhance the java.time package to support day periods, such as "in the morning", defined in CLDR. It will add a new pattern character 'B' and its supporting builder method. The motivation and its spec are in this CSR:

Why do we export "JVM_handle_xxx_signal"?

2020-10-29 Thread Thomas Stüfe
Hi, Does anyone know why we explicitly export JVM_handle_bsd_signal and JVM_handle_linux_signal (the latter also accidentally from symbols-aix)? These functions are not even the real signal handler, just an internal function; the signal handler is "javaSignalHandler", but that one is not

Re: RFR: 8254162: Implementation of Foreign-Memory Access API (Third Incubator)

2020-10-29 Thread Maurizio Cimadamore
On Tue, 27 Oct 2020 14:40:29 GMT, Maurizio Cimadamore wrote: >> This patch contains the changes associated with the third incubation round >> of the foreign memory access API incubation (see JEP 393 [1]). This >> iteration focus on improving the usability of the API in 3 main ways: >> >> *

Re: RFR: 8254162: Implementation of Foreign-Memory Access API (Third Incubator) [v18]

2020-10-29 Thread Maurizio Cimadamore
> This patch contains the changes associated with the third incubation round of > the foreign memory access API incubation (see JEP 393 [1]). This iteration > focus on improving the usability of the API in 3 main ways: > > * first, by providing a way to obtain truly *shared* segments, which

BUG:j2re-image lost two dll files, j2sdk-image/jre have them

2020-10-29 Thread 柳鲲鹏
Hello! I have built OpenJDK8-272 on windows 10. I found there is a bug: Compre files between j2re-image and j2sdk-image, j2re-image lost two files: sawindbg.dll attach.dll I build severial times, it always ocurred. Thanks. Quantum6, Tai Shan IT.

Re: RFR: JDK-8250768: javac should be adapted to changes in JEP 12 [v4]

2020-10-29 Thread Jan Lahoda
On Fri, 23 Oct 2020 18:19:13 GMT, Jonathan Gibbons wrote: >> Jan Lahoda has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Removing unnecessary cast. > > src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/Utils.java >

Re: RFR: JDK-8250768: javac should be adapted to changes in JEP 12 [v4]

2020-10-29 Thread Jan Lahoda
On Tue, 27 Oct 2020 16:11:18 GMT, Jan Lahoda wrote: >> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/Utils.java >> line 2980: >> >>> 2978: } >>> 2979: >>> 2980: public enum DeclarationPreviewLanguageFeatures { >> >> General thinking aloud question ... how

Re: RFR: JDK-8250768: javac should be adapted to changes in JEP 12 [v4]

2020-10-29 Thread Jan Lahoda
On Fri, 23 Oct 2020 17:58:42 GMT, Jonathan Gibbons wrote: >> Jan Lahoda has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Removing unnecessary cast. > >

Re: RFR: JDK-8250768: javac should be adapted to changes in JEP 12 [v4]

2020-10-29 Thread Jan Lahoda
On Fri, 23 Oct 2020 18:28:12 GMT, Jonathan Gibbons wrote: >> Jan Lahoda has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Removing unnecessary cast. > > src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/ElementsTable.java > line

Re: make test TEST="micro:" got java.lang.UnsupportedClassVersionError

2020-10-29 Thread Liu, Xin
Hi, Claes, Thank you for fixing that. --lx On 10/28/20, 4:07 PM, "Claes Redestad" wrote: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. FWIW I just