Re: RFR: 8212879: Make JVMTI TagMap table concurrent [v11]

2020-11-18 Thread Kim Barrett
On Wed, 18 Nov 2020 19:31:44 GMT, Serguei Spitsyn wrote: > test/hotspot/jtreg/vmTestbase/nsk/jvmti/AttachOnDemand/attach021/attach021Agent00.cpp: > > The change below is not needed as the call to > nsk_jvmti_aod_disableEventAndFinish() does exactly the same: > > ``` > -nsk_jvmti_aod_disabl

Re: RFR: 8212879: Make JVMTI TagMap table concurrent [v12]

2020-11-18 Thread Coleen Phillimore
> This change turns the HashTable that JVMTI uses for object tagging into a > regular Hotspot hashtable - the one in hashtable.hpp with resizing and > rehashing. Instead of pointing directly to oops so that GC has to walk the > table to follow oops and then to rehash the table, this table poin

Re: RFR: 8212879: Make JVMTI TagMap table concurrent [v11]

2020-11-18 Thread Coleen Phillimore
On Wed, 18 Nov 2020 19:31:44 GMT, Serguei Spitsyn wrote: > There is a double-check for _needs_cleaning, so the one at line 136 can be > removed: I want to leave _needs_cleaning at 136 because even though the boolean is checked twice, it doesn't hurt performance and it has a nice symmetry in th

Re: RFR: 8212879: Make JVMTI TagMap table concurrent [v10]

2020-11-18 Thread Coleen Phillimore
On Mon, 16 Nov 2020 23:10:21 GMT, Coleen Phillimore wrote: >> This change turns the HashTable that JVMTI uses for object tagging into a >> regular Hotspot hashtable - the one in hashtable.hpp with resizing and >> rehashing. Instead of pointing directly to oops so that GC has to walk the >> t

Re: RFR: 8256497: Zero: enable G1 and Shenandoah GCs

2020-11-18 Thread Erik Joelsson
On Tue, 17 Nov 2020 19:02:03 GMT, Aleksey Shipilev wrote: > Following the [JDK-8255796](https://bugs.openjdk.java.net/browse/JDK-8255796) > improvement that ditched the inline contiguous alloc use from Zero, we can > now rely on GC interface to hook the GCs properly. G1 and Shenandoah are a >

Re: RFR: 8256538: Fix annoying awk warning in configure for java versions [v2]

2020-11-18 Thread Magnus Ihse Bursie
> The change from grep to awk in JDK-8244248 and further bug fixed in > JDK-8244756 still has invalid syntax. This causes some awk (most notably > gawk, the most commonly used) to complain: > > gawk: cmd. line:1: warning: regexp escape sequence `"' is not a known regexp > operator > > This is

Integrated: 8256538: Fix annoying awk warning in configure for java versions

2020-11-18 Thread Magnus Ihse Bursie
On Wed, 18 Nov 2020 09:47:58 GMT, Magnus Ihse Bursie wrote: > The change from grep to awk in JDK-8244248 and further bug fixed in > JDK-8244756 still has invalid syntax. This causes some awk (most notably > gawk, the most commonly used) to complain: > > gawk: cmd. line:1: warning: regexp escap

Re: RFR: 8256538: Fix annoying awk warning in configure for java versions [v2]

2020-11-18 Thread Magnus Ihse Bursie
On Wed, 18 Nov 2020 14:13:03 GMT, Bernhard Urban-Forster wrote: >> Marked as reviewed by erikj (Reviewer). > > Thank you Magnus, this is something that has bugged me as well. > > FWIW the same problem exists here with the build JDK detection: > https://github.com/openjdk/jdk/blob/9d5fd4fcabf7b

Re: RFR: JDK-6251738: Want a top-level summary page that itemizes all spec documents referenced from javadocs (OEM spec) [v3]

2020-11-18 Thread Jonathan Gibbons
> This introduces support for a new `@spec` tag that can be used as either an > inline tag or as a block tag. It is used to identify references to external > specifications, in such a way that the references can be collected together > on a new summary page, called "Other Specifications", availa

Re: RFR: 8212879: Make JVMTI TagMap table concurrent [v11]

2020-11-18 Thread Serguei Spitsyn
On Mon, 16 Nov 2020 23:30:25 GMT, Coleen Phillimore wrote: >> This change turns the HashTable that JVMTI uses for object tagging into a >> regular Hotspot hashtable - the one in hashtable.hpp with resizing and >> rehashing. Instead of pointing directly to oops so that GC has to walk the >> t

Integrated: JDK-8256501: libTestMainKeyWindow fails to build with Xcode 12.2

2020-11-18 Thread Erik Joelsson
On Tue, 17 Nov 2020 21:04:08 GMT, Erik Joelsson wrote: > In Xcode 12.2, the framework JavaVM was removed in the sysroot and all > (relevant) frameworks inside were just moved one step up so we still find > things like JavaNativeFoundation and JavaRuntimeSupport. There is however one > test tha

Re: RFR: 8256538: Fix annoying awk warning in configure for java versions

2020-11-18 Thread Bernhard Urban-Forster
On Wed, 18 Nov 2020 13:35:14 GMT, Erik Joelsson wrote: >> The change from grep to awk in JDK-8244248 and further bug fixed in >> JDK-8244756 still has invalid syntax. This causes some awk (most notably >> gawk, the most commonly used) to complain: >> >> gawk: cmd. line:1: warning: regexp escap

Re: RFR: 8248862: Implement Enhanced Pseudo-Random Number Generators [v3]

2020-11-18 Thread Jim Laskey
On Wed, 18 Nov 2020 13:18:30 GMT, Jim Laskey wrote: >> I am unsure if the intent is also to support external libraries providing >> `RandomGenerator` implementations. Currently there is an implicit contract >> for properties (reflectively invoking a method returning a map with a set of >> entr

Re: RFR: 8256497: Zero: enable G1 and Shenandoah GCs

2020-11-18 Thread Roman Kennke
On Tue, 17 Nov 2020 19:02:03 GMT, Aleksey Shipilev wrote: > Following the [JDK-8255796](https://bugs.openjdk.java.net/browse/JDK-8255796) > improvement that ditched the inline contiguous alloc use from Zero, we can > now rely on GC interface to hook the GCs properly. G1 and Shenandoah are a >

RFR: 8256497: Zero: enable G1 and Shenandoah GCs

2020-11-18 Thread Aleksey Shipilev
Following the [JDK-8255796](https://bugs.openjdk.java.net/browse/JDK-8255796) improvement that ditched the inline contiguous alloc use from Zero, we can now rely on GC interface to hook the GCs properly. G1 and Shenandoah are a bit special here, because they require special `Reference.get` handl

Re: RFR: 8256538: Fix annoying awk warning in configure for java versions

2020-11-18 Thread Erik Joelsson
On Wed, 18 Nov 2020 09:47:58 GMT, Magnus Ihse Bursie wrote: > The change from grep to awk in JDK-8244248 and further bug fixed in > JDK-8244756 still has invalid syntax. This causes some awk (most notably > gawk, the most commonly used) to complain: > > gawk: cmd. line:1: warning: regexp escap

Re: RFR: 8248862: Implement Enhanced Pseudo-Random Number Generators [v3]

2020-11-18 Thread Jim Laskey
On Wed, 18 Nov 2020 00:51:43 GMT, Paul Sandoz wrote: >> Jim Laskey has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 40 commits: >> >> - Merge branch 'master' into 8248862 >> - 8248862: Implement Enhanced Pseudo-Random Number Gene

Withdrawn: 8248862: Implement Enhanced Pseudo-Random Number Generators

2020-11-18 Thread Jim Laskey
On Tue, 17 Nov 2020 19:58:47 GMT, Jim Laskey wrote: > This PR is to introduce a new random number API for the JDK. The primary API > is found in RandomGenerator and RandomGeneratorFactory. Further description > can be found in the JEP https://openjdk.java.net/jeps/356 . This pull request has b

Re: RFR: 8256538: Fix annoying awk warning in configure for java versions

2020-11-18 Thread Magnus Ihse Bursie
On Wed, 18 Nov 2020 09:47:58 GMT, Magnus Ihse Bursie wrote: > The change from grep to awk in JDK-8244248 and further bug fixed in > JDK-8244756 still has invalid syntax. This causes some awk (most notably > gawk, the most commonly used) to complain: > > gawk: cmd. line:1: warning: regexp escap

RFR: 8256240: Reproducible builds should turn on the "deterministic" flag for Visual Studio

2020-11-18 Thread Magnus Ihse Bursie
The microsoft toolchain now supports a new "deterministic" build mode. This goes a long way towards building properly deterministic. Another important feature is that with the deterministic build mode enabled, the -pathmap flag, similar to gcc's -fmacro-prefix-map, is enabled. - Co

Re: RFR: 8256499: Zero: enable Epsilon GC

2020-11-18 Thread Magnus Ihse Bursie
On Tue, 17 Nov 2020 19:11:45 GMT, Aleksey Shipilev wrote: > Following the [JDK-8255796](https://bugs.openjdk.java.net/browse/JDK-8255796) > improvement that ditched the inline contiguous alloc use from Zero, we can > now rely on GC interface to hook the GCs properly. Epsilon GC does not > requ

RFR: 8256538: Fix annoying awk warning in configure for java versions

2020-11-18 Thread Magnus Ihse Bursie
The change from grep to awk in JDK-8244248 and further bug fixed in JDK-8244756 still has invalid syntax. This causes some awk (most notably gawk, the most commonly used) to complain: gawk: cmd. line:1: warning: regexp escape sequence `"' is not a known regexp operator This is annoying and sho

Re: RFR: 8256499: Zero: enable Epsilon GC

2020-11-18 Thread Roman Kennke
On Tue, 17 Nov 2020 19:11:45 GMT, Aleksey Shipilev wrote: > Following the [JDK-8255796](https://bugs.openjdk.java.net/browse/JDK-8255796) > improvement that ditched the inline contiguous alloc use from Zero, we can > now rely on GC interface to hook the GCs properly. Epsilon GC does not > requ

RFR: 8256499: Zero: enable Epsilon GC

2020-11-18 Thread Aleksey Shipilev
Following the [JDK-8255796](https://bugs.openjdk.java.net/browse/JDK-8255796) improvement that ditched the inline contiguous alloc use from Zero, we can now rely on GC interface to hook the GCs properly. Epsilon GC does not require anything else. Other GCs require a bit of fiddling and more test