Re: RFR: 8253753 Enable default constructor warning in client modules

2020-11-24 Thread Sergey Bylokhov
On Tue, 24 Nov 2020 19:10:04 GMT, Joe Darcy wrote: > With the default constructors warnings in java.desktop and jdk.accessibility > now fixed, the warning should be enabled in the build for those modules. Marked as reviewed by serb (Reviewer). - PR: https://git.openjdk.java.net/jd

Re: RFR: 8248862: Implement Enhanced Pseudo-Random Number Generators [v3]

2020-11-24 Thread Jim Laskey
On Wed, 18 Nov 2020 00:30:53 GMT, Paul Sandoz wrote: >> Jim Laskey has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 40 commits: >> >> - Merge branch 'master' into 8248862 >> - 8248862: Implement Enhanced Pseudo-Random Number Gene

Re: RFR: 8253753 Enable default constructor warning in client modules

2020-11-24 Thread Phil Race
On Tue, 24 Nov 2020 19:10:04 GMT, Joe Darcy wrote: > With the default constructors warnings in java.desktop and jdk.accessibility > now fixed, the warning should be enabled in the build for those modules. I tried this myself a few weeks ago and it was fine. - Marked as reviewed by

RFR: 8253753 Enable default constructor warning in client modules

2020-11-24 Thread Joe Darcy
With the default constructors warnings in java.desktop and jdk.accessibility now fixed, the warning should be enabled in the build for those modules. - Commit messages: - Merge branch 'JDK-8253753' of https://github.com/jddarcy/jdk into JDK-8253753 - Update build to enable default

Re: RFR: 8256308: Send arguments to javac server in a config file [v6]

2020-11-24 Thread Magnus Ihse Bursie
On Tue, 24 Nov 2020 09:52:34 GMT, Joel Borggrén-Franck wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix whitespace issues > > src/jdk.compiler/share/classes/com/sun/tools/sjavac/Util.java line 96: > >> 9

Integrated: 8256308: Send arguments to javac server in a config file

2020-11-24 Thread Magnus Ihse Bursie
On Thu, 12 Nov 2020 22:13:37 GMT, Magnus Ihse Bursie wrote: > Currently, to use the javac server, a horrendously long command line option > is created, looking like this: `--server:portfile= portfile>:sjavac=`, where the sjavac command has > had all spaces replaced by %20. Since Project Jigsaw,

Re: RFR: 8256755: Update build.tools.depend.Depend to handle record components in API signatures

2020-11-24 Thread Jan Lahoda
On Tue, 24 Nov 2020 09:59:44 GMT, Chris Hegarty wrote: > The `Depend` build tool creates a hash of a module's API elements, so that it > can determine if downstream modules require recompilation. The build tool > fails (throws an exception) when it encounters an "unknown" record > attribute/co

RFR: 8256755: Update build.tools.depend.Depend to handle record components in API signatures

2020-11-24 Thread Chris Hegarty
The `Depend` build tool creates a hash of a module's API elements, so that it can determine if downstream modules require recompilation. The build tool fails (throws an exception) when it encounters an "unknown" record attribute/component - the build tool predates records. The components of a p

Re: RFR: 8256308: Send arguments to javac server in a config file [v6]

2020-11-24 Thread Joel Borggrén-Franck
On Mon, 16 Nov 2020 12:44:08 GMT, Magnus Ihse Bursie wrote: >> Currently, to use the javac server, a horrendously long command line option >> is created, looking like this: `--server:portfile=> portfile>:sjavac=`, where the sjavac command has >> had all spaces replaced by %20. Since Project Jig