Re: RFR: 8256657: Add cross-compiled build for Windows+Arm64 to submit workflow [v2]

2020-11-27 Thread Bernhard Urban-Forster
> This adds the cross-compiled build only, as no Windows+Arm64 machines are > available on GitHub Action that we could use to run the tests. > > Due to cross-compilation a build JDK is required. Initially I added EA builds > to be downloaded from https://jdk.java.net/16/ and used for that, but

Integrated: 8253753 Enable default constructor warning in client modules

2020-11-27 Thread Joe Darcy
On Tue, 24 Nov 2020 19:10:04 GMT, Joe Darcy wrote: > With the default constructors warnings in java.desktop and jdk.accessibility > now fixed, the warning should be enabled in the build for those modules. This pull request has now been integrated. Changeset: 65137ff0 Author:Joe Darcy

Integrated: 8257208: Fix typo in doc/building.md

2020-11-27 Thread Hollow Man
On Sat, 21 Nov 2020 14:28:23 GMT, Hollow Man wrote: > overriden -> overridden This pull request has now been integrated. Changeset: f6bfbb2b Author:Hollow Man Committer: Magnus Ihse Bursie URL: https://git.openjdk.java.net/jdk/commit/f6bfbb2b Stats: 6 lines in 2 files changed:

Re: RFR: 8257208: Fix typo in doc/building.md

2020-11-27 Thread Hollow Man
On Fri, 27 Nov 2020 14:22:01 GMT, Magnus Ihse Bursie wrote: >> overriden -> overridden > > Marked as reviewed by ihse (Reviewer). @magicus Thanks for reviewing! Now could you please sponsor this change? Thanks! - PR: https://git.openjdk.java.net/jdk/pull/1365

RFR: JDK-8256950: Add record attribute support to symbol generator CreateSymbols

2020-11-27 Thread Jan Lahoda
Adding support for record classes in the historical data for ct.sym. This includes a few changes not strictly needed for the change: -updating and moving tests into test/langtools, so that it is easier to run them. -fixing Record attribute reading in javac's ClassReader (used for tests, but

Re: RFR: 8257208: Fix typo in doc/building.md

2020-11-27 Thread Magnus Ihse Bursie
On Sat, 21 Nov 2020 14:28:23 GMT, Hollow Man wrote: > overriden -> overridden Marked as reviewed by ihse (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/1365

RFR: 8257208: Fix typo in doc/building.md

2020-11-27 Thread Hollow Man
overriden -> overridden - Commit messages: - 8257208: Fix typo in doc/building.md Changes: https://git.openjdk.java.net/jdk/pull/1365/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=1365=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8257208 Stats: 6 lines in 2

Re: RFR: 8257208: Fix typo in doc/building.md

2020-11-27 Thread Hollow Man
On Sat, 21 Nov 2020 14:28:23 GMT, Hollow Man wrote: > overriden -> overridden > Hi @HollowMan6! > > Thank you for submitting this PR. As the contribution docs state, you need a > sponsor for this PR. I'll be your sponsor. > > I have opened a bug issue for this fix: >

Re: RFR: 8257208: Fix typo in doc/building.md

2020-11-27 Thread Magnus Ihse Bursie
On Sat, 21 Nov 2020 14:28:23 GMT, Hollow Man wrote: > overriden -> overridden Hi @HollowMan6! Thank you for submitting this PR. As the contribution docs state, you need a sponsor for this PR. I'll be your sponsor. I have opened a bug issue for this fix: