On Wed, 9 Dec 2020 07:22:51 GMT, Bernhard Urban-Forster
wrote:
>> This adds the cross-compiled build only, as no Windows+Arm64 machines are
>> available on GitHub Action that we could use to run the tests.
>>
>> Due to cross-compilation a build JDK is required. Initially I added EA
>> builds
> This adds the cross-compiled build only, as no Windows+Arm64 machines are
> available on GitHub Action that we could use to run the tests.
>
> Due to cross-compilation a build JDK is required. Initially I added EA builds
> to be downloaded from https://jdk.java.net/16/ and used for that, but
On Tue, 8 Dec 2020 06:59:23 GMT, Aleksey Shipilev wrote:
>> Minor nits.
>
> Also merge from master to get the clean workflow run everywhere?
Thank you @shipilev for your comments, I've updated the PR.
-
PR: https://git.openjdk.java.net/jdk/pull/1379
> Start of JDK 17 updates.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull request contains 14 additional commits since the
last revision:
- Get in JEP 390
On Tue, 8 Dec 2020 17:10:30 GMT, Joe Darcy wrote:
>> Start of JDK 17 updates.
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated changes brought in
> by the merge/rebase. The pull request contains 12
On Thu, 3 Dec 2020 09:22:18 GMT, Jan Lahoda wrote:
>> Adding support for record classes in the historical data for ct.sym. This
>> includes a few changes not strictly needed for the change:
>> -updating and moving tests into test/langtools, so that it is easier to run
>> them.
>> -fixing
> This is an update to javac and javadoc, to introduce support for Preview
> APIs, and generally improve javac and javadoc behavior to more closely adhere
> to JEP 12.
>
> The notable changes are:
>
> * adding support for Preview APIs (javac until now supported primarily only
> preview
On Tue, 8 Dec 2020 17:33:16 GMT, Alan Bateman wrote:
>> The mapping and nr tables, and the *-X.java.template files in
>> make/data/charsetmapping are used to generate source code for the java.base
>> and jdk.charsets modules. The stdcs-$OS files configure the package and
>> module that each
On Tue, 8 Dec 2020 17:33:16 GMT, Alan Bateman wrote:
>> The mapping and nr tables, and the *-X.java.template files in
>> make/data/charsetmapping are used to generate source code for the java.base
>> and jdk.charsets modules. The stdcs-$OS files configure the package and
>> module that each
On Thu, 3 Dec 2020 06:50:11 GMT, Anton Kozlov wrote:
>> Filed https://bugs.openjdk.java.net/browse/JDK-8257633
>
> Thanks for taking care of those issues. To be clear, there is no real need to
> bump the version for this PR, 10.9 is fine. This PR just proposes another way
> to implement the
On Tue, 8 Dec 2020 17:10:30 GMT, Joe Darcy wrote:
>> Start of JDK 17 updates.
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated changes brought in
> by the merge/rebase. The pull request contains 12
On Tue, 8 Dec 2020 18:16:15 GMT, Mandy Chung wrote:
>> @wangweij Moving build tools is a related, but separate, question, which is
>> addressed by https://bugs.openjdk.java.net/browse/JDK-8241463.
>>
>> I send out a review earlier this year (see
>>
On Tue, 8 Dec 2020 16:19:05 GMT, Magnus Ihse Bursie wrote:
>> Is there a plan to move make/jdk/src/classes/build/tools/intpoly into
>> java.base as well?
>>
>> Update: I see all subdirs in tools are still there.
>
> @wangweij Moving build tools is a related, but separate, question, which is
>
On Tue, 8 Dec 2020 14:43:00 GMT, Magnus Ihse Bursie wrote:
> When calling a Windows tool that needs an argument on the form
> `-option/a:/home/ihse/myjdk/...`, fixpath gets confused and thinks
> `/a:/home/ihse/myjdk` is a unix path, notices that it does not exists, and
> stops trying to
On Tue, 8 Dec 2020 12:15:38 GMT, Alan Bateman wrote:
>> Also, to clarify, for me there is a fundamental difference between
>> `src/$MODULE` and `make/modules/$MODULE`. The former is the home of files
>> that are part of the module, owned by the content team, and the `$MODULE`
>> part is
On Tue, 8 Dec 2020 16:43:14 GMT, Magnus Ihse Bursie wrote:
>> When calling a Windows tool that needs an argument on the form
>> `-option/a:/home/ihse/myjdk/...`, fixpath gets confused and thinks
>> `/a:/home/ihse/myjdk` is a unix path, notices that it does not exists, and
>> stops trying to
> Start of JDK 17 updates.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull request contains 12 additional commits since the
last revision:
- Merge branch
> When calling a Windows tool that needs an argument on the form
> `-option/a:/home/ihse/myjdk/...`, fixpath gets confused and thinks
> `/a:/home/ihse/myjdk` is a unix path, notices that it does not exists, and
> stops trying to convert the path.
>
> Instead it needs to recheck for paths
On Tue, 8 Dec 2020 16:40:26 GMT, Magnus Ihse Bursie wrote:
>> When calling a Windows tool that needs an argument on the form
>> `-option/a:/home/ihse/myjdk/...`, fixpath gets confused and thinks
>> `/a:/home/ihse/myjdk` is a unix path, notices that it does not exists, and
>> stops trying to
On Tue, 8 Dec 2020 14:56:20 GMT, Andy Herrick wrote:
>> Looks like test failed due to:
>> [Fatal Error] b.wxl:3:1: XML document structures must start and end within
>> the same entity.
>> So, I am not sure how increased repeat will help. Do we know why it failed
>> to parse XML?
>
>>
>>
>>
On Tue, 8 Dec 2020 15:25:47 GMT, Weijun Wang wrote:
>> The mapping and nr tables, and the *-X.java.template files in
>> make/data/charsetmapping are used to generate source code for the java.base
>> and jdk.charsets modules. The stdcs-$OS files configure the package and
>> module that each
On Tue, 8 Dec 2020 12:15:38 GMT, Alan Bateman wrote:
>> Also, to clarify, for me there is a fundamental difference between
>> `src/$MODULE` and `make/modules/$MODULE`. The former is the home of files
>> that are part of the module, owned by the content team, and the `$MODULE`
>> part is
On Tue, 8 Dec 2020 12:15:38 GMT, Alan Bateman wrote:
>> Also, to clarify, for me there is a fundamental difference between
>> `src/$MODULE` and `make/modules/$MODULE`. The former is the home of files
>> that are part of the module, owned by the content team, and the `$MODULE`
>> part is
> increase retries and timeout increasing in runMsiexecWithRetries
Andy Herrick has updated the pull request incrementally with 18 additional
commits since the last revision:
- 8256149: Weird AST structure for incomplete member select
Reviewed-by: vromero
- 8257194: Add 'foreign linker
When calling a Windows tool that needs an argument on the form
`-option/a:/home/ihse/myjdk/...`, fixpath gets confused and thinks
`/a:/home/ihse/myjdk` is a unix path, notices that it does not exists, and
stops trying to convert the path.
Instead it needs to recheck for paths after a
On 2020-12-08 00:30, Magnus Ihse Bursie wrote:
On Tue, 8 Dec 2020 02:40:43 GMT, Mandy Chung wrote:
I have reviewed all lines in the patch file with or near instances of
`jdk.compiler`
Hi Magnus,
I see the motivation of moving these build files for better identification of
ownership.
On Tue, 8 Dec 2020 08:32:28 GMT, Magnus Ihse Bursie wrote:
>> @mlchung If you don't have any strong preference, I implore you to accept
>> this change. I **vastly** prefer to move the data out of `make`!
>>
>> This is not just about Skara tooling. When working with make files, autoconf
>> and
On Tue, 8 Dec 2020 08:27:16 GMT, Magnus Ihse Bursie wrote:
>> Hi Magnus,
>>
>> I see the motivation of moving these build files for better identification
>> of ownership. Placing them under
>> `src/$MODULE/{share,$OS}/data` is one option. Given that skara will
>> automatically determine
On Tue, 8 Dec 2020 02:40:43 GMT, Mandy Chung wrote:
>> I have reviewed all lines in the patch file with or near instances of
>> `jdk.compiler`
>
> Hi Magnus,
>
> I see the motivation of moving these build files for better identification of
> ownership. Placing them under
>
29 matches
Mail list logo