Withdrawn: 8255917: runtime/cds/SharedBaseAddress.java failed "assert(reserved_rgn != 0LL) failed: No reserved region"

2020-12-10 Thread Yumin Qi
On Mon, 7 Dec 2020 05:01:27 GMT, Yumin Qi wrote: > Hi, Please review > Windows mapping for file into memory could not happen to reserved memory. > In mapping CDS archive we first reserve enough memory then before mapping, > release them. For cds archive and using class space, need split the

Re: RFR: 8255917: runtime/cds/SharedBaseAddress.java failed "assert(reserved_rgn != 0LL) failed: No reserved region" [v5]

2020-12-10 Thread Yumin Qi
On Tue, 8 Dec 2020 06:12:36 GMT, Yumin Qi wrote: >> Changes requested by iklam (Reviewer). > > Please check 03. 02 is generated when merge with most current and remote head > not updated correctly. After set remote head correct, 03 is regenerated and > is correct one for review. Thanks This

Re: RFR: 8255917: runtime/cds/SharedBaseAddress.java failed "assert(reserved_rgn != 0LL) failed: No reserved region" [v5]

2020-12-10 Thread Yumin Qi
> Hi, Please review > Windows mapping for file into memory could not happen to reserved memory. > In mapping CDS archive we first reserve enough memory then before mapping, > release them. For cds archive and using class space, need split the whole > space into two, that is, release the whole

Re: RFR: 8257733: Move module-specific data from make to respective module [v2]

2020-12-10 Thread Naoto Sato
On Mon, 7 Dec 2020 14:27:45 GMT, Magnus Ihse Bursie wrote: >> A lot (but not all) of the data in make/data is tied to a specific module. >> For instance, the publicsuffixlist is used by java.base, and fontconfig by >> java.desktop. (A few directories, like mainmanifest, is *actually* used by

Re: RFR: 8257620: Do not use objc_msgSend_stret to get macOS version

2020-12-10 Thread Anton Kozlov
On Wed, 2 Dec 2020 19:27:25 GMT, Phil Race wrote: >> Please review a small change that replaces use of objc_msgSend_stret in >> macOS platform code with pure ObjC code. It's also a prerequisite for >> macOS/AArch64 support, where objc_msgSend_stret is not available. > > Surely these days you

Integrated: 8257450: Start of release updates for JDK 17

2020-12-10 Thread Joe Darcy
On Tue, 1 Dec 2020 06:22:51 GMT, Joe Darcy wrote: > Start of JDK 17 updates. This pull request has now been integrated. Changeset: 6be1f567 Author:Joe Darcy URL: https://git.openjdk.java.net/jdk/commit/6be1f567 Stats: 7607 lines in 77 files changed: 7548 ins; 0 del; 59 mod

Integrated: 8258005: JDK build fails with incorrect fixpath script

2020-12-10 Thread Magnus Ihse Bursie
On Thu, 10 Dec 2020 12:42:48 GMT, Magnus Ihse Bursie wrote: > The Leaning Toothpick Syndrome[1] strikes back! > > In the fixpath shell script wrapper, we transform single `` to `\`, to make > them correctly escaped. Unfortunately, the bas variable substitution pattern > I used were missing a

Re: RFR: 8258005: JDK build fails with incorrect fixpath script [v2]

2020-12-10 Thread Erik Joelsson
On Thu, 10 Dec 2020 13:11:47 GMT, Magnus Ihse Bursie wrote: >> The Leaning Toothpick Syndrome[1] strikes back! >> >> In the fixpath shell script wrapper, we transform single `` to `\`, to make >> them correctly escaped. Unfortunately, the bas variable substitution pattern >> I used were

Re: RFR: 8258005: JDK build fails with incorrect fixpath script [v2]

2020-12-10 Thread Magnus Ihse Bursie
> The Leaning Toothpick Syndrome[1] strikes back! > > In the fixpath shell script wrapper, we transform single `` to `\`, to make > them correctly escaped. Unfortunately, the bas variable substitution pattern > I used were missing a `/`, so it only replaced the first backslash, not all > of

RFR: 8258005: JDK build fails with incorrect fixpath script

2020-12-10 Thread Magnus Ihse Bursie
The Leaning Toothpick Syndrome[1] strikes back! In the fixpath shell script wrapper, we transform single `` to `\`, to make them correctly escaped. Unfortunately, the bas variable substitution pattern I used were missing a `/`, so it only replaced the first backslash, not all of them. Thanks

Re: RFR: 8257450: Start of release updates for JDK 17 [v8]

2020-12-10 Thread Joe Darcy
> Start of JDK 17 updates. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 18 additional commits since the last revision: - Merge branch