On Mon, 4 Jan 2021 17:19:48 GMT, Ioi Lam wrote:
>> From the error log we can see the root cause is that, develop_pd flag
>> 'pd_CICompileOSR' is undeclared in zero build.
>>
>> Where this flag is used?
>> Flag 'pd_CICompileOSR' is assigned to flag 'CICompileOSR'. See line 77
>> of
On Tue, 5 Jan 2021 03:19:51 GMT, Ioi Lam wrote:
> > Given that this seems to be a common problem in our code, and likely a very
> > very old problem at that, why has it never been reported before? I'm not
> > questioning the fix except to the extent that I'm questioning our
> > understanding
On Mon, 4 Jan 2021 19:33:45 GMT, Xin Liu wrote:
>>> _Mailing list message from [Kim Barrett](mailto:kim.barr...@oracle.com) on
>>> [build-dev](mailto:build-dev@openjdk.java.net):_
>>>
>>> > On Dec 29, 2020, at 10:33 PM, Hao Sun >> > openjdk.java.net> wrote:
>>> > > _Mailing list message from
> 1. '-Wdeprecated-copy'
> As specified in C++11 [1], "the generation of the implicitly-defined
> copy constructor is deprecated if T has a user-defined destructor or
> user-defined copy assignment operator". The rationale behind is the
> well-known Rule of Three [2].
>
> Introduced since gcc-9
On Tue, 5 Jan 2021 03:07:49 GMT, Chris Plummer wrote:
> Given that this seems to be a common problem in our code, and likely a very
> very old problem at that, why has it never been reported before? I'm not
> questioning the fix except to the extent that I'm questioning our
> understanding of
On Tue, 5 Jan 2021 02:40:29 GMT, Yasumasa Suenaga wrote:
>> Marked as reviewed by iklam (Reviewer).
>
> @iklam Thanks for your review!
>
>> I looked at a cases in the JDK code where
>> `Java_sun_security_pkcs11_wrapper_PKCS11_connect()` calls `FormatMessage()`.
>> It eventually passes the
On Tue, 5 Jan 2021 02:19:37 GMT, Ioi Lam wrote:
>> I got garbled exception message as following when I run `livenmethods`
>> CLHSDB command:
>>
>> sun.jvm.hotspot.debugger.DebuggerException : ?w???W
>>
>> My Windows laptop is set Japanese Locale, garbled message was written in
>>
On Tue, 5 Jan 2021 01:31:28 GMT, Chris Plummer wrote:
> > jdk.hotspot.agent do not have `FormatMessage()` call in other place.
> > Did you say about whole JDK code? I haven't checked all of them, but some
> > code (e.g. net_util_md.c) uses `JNU_ThrowByName()` which is provided by
> > java.dll.
On Mon, 4 Jan 2021 09:25:55 GMT, Yasumasa Suenaga wrote:
> I got garbled exception message as following when I run `livenmethods` CLHSDB
> command:
>
> sun.jvm.hotspot.debugger.DebuggerException : ?w???W
>
> My Windows laptop is set Japanese Locale, garbled message was written in
>
On Tue, 5 Jan 2021 01:30:07 GMT, Ioi Lam wrote:
> Now the saproc DLL has an external reference to getLastErrorString,
> JNU_NewStringPlatform and JNU_NewObjectByName on all platforms. Do we need to
> modify the makefiles for platforms other than Windows?
@iklam Agree, so I added `LIBS_unix :=
On Tue, 5 Jan 2021 00:41:11 GMT, Yasumasa Suenaga wrote:
>> There are probably 25 or so places in our code where we use FormatMessage to
>> get the error message. Are these all going to run into the same
>> FormateMessage bug?
>>
>> Also, it's not clear to me why you are getting garbled text
On Tue, 5 Jan 2021 00:41:11 GMT, Yasumasa Suenaga wrote:
> jdk.hotspot.agent do not have `FormatMessage()` call in other place.
> Did you say about whole JDK code? I haven't checked all of them, but some
> code (e.g. net_util_md.c) uses `JNU_ThrowByName()` which is provided by
> java.dll.
On Mon, 4 Jan 2021 21:06:46 GMT, Chris Plummer wrote:
> There are probably 25 or so places in our code where we use FormatMessage to
> get the error message. Are these all going to run into the same
> FormateMessage bug?
jdk.hotspot.agent do not have `FormatMessage()` call in other place.
Did
On Mon, 4 Jan 2021 20:58:59 GMT, Chris Plummer wrote:
>> I got garbled exception message as following when I run `livenmethods`
>> CLHSDB command:
>>
>> sun.jvm.hotspot.debugger.DebuggerException : ?w???W
>>
>> My Windows laptop is set Japanese Locale, garbled message was written in
>>
On Mon, 4 Jan 2021 23:39:18 GMT, Jie Fu wrote:
>> src/hotspot/share/compiler/compiler_globals.hpp line 29:
>>
>>> 27:
>>> 28: #include "compiler/compiler_globals_pd.hpp"
>>> 29: #ifdef COMPILER1
>>
>> `#include "runtime/globals_shared.hpp"` should not be removed.
>> compiler_globals.hpp uses
On Mon, 4 Jan 2021 17:19:44 GMT, Ioi Lam wrote:
> `#include "runtime/globals_shared.hpp"` should not be removed.
> compiler_globals.hpp uses the `DECLARE_FLAGS` macro, which is defined by
> globals_shared.hpp.
Since globals_shared.hpp is included in compiler_globals_pd.hpp, I think it's
fine
On Tue, 15 Dec 2020 22:56:15 GMT, Magnus Ihse Bursie wrote:
>> A lot (but not all) of the data in make/data is tied to a specific module.
>> For instance, the publicsuffixlist is used by java.base, and fontconfig by
>> java.desktop. (A few directories, like mainmanifest, is *actually* used by
On Mon, 4 Jan 2021 09:25:55 GMT, Yasumasa Suenaga wrote:
> I got garbled exception message as following when I run `livenmethods` CLHSDB
> command:
>
> sun.jvm.hotspot.debugger.DebuggerException : ?w???W
>
> My Windows laptop is set Japanese Locale, garbled message was written in
>
On Mon, 4 Jan 2021 04:31:02 GMT, Hao Sun
wrote:
>>> _Mailing list message from [Kim Barrett](mailto:kim.barr...@oracle.com) on
>>> [build-dev](mailto:build-dev@openjdk.java.net):_
>>>
>>> > On Dec 24, 2020, at 3:44 PM, Xin Liu wrote:
>>> > On Thu, 24 Dec 2020 17:27:39 GMT, Kim Barrett
>>>
Hello Matthias,
The path configure found to vcruntime140_1.dll certainly looks strange.
This is likely a bug in the build system. Normally we would expect to
find this file in the redist dir of the Visual Studio installation. Does
your community edition not include that file?
/Erik
On
On Mon, 4 Jan 2021 09:25:55 GMT, Yasumasa Suenaga wrote:
> I got garbled exception message as following when I run `livenmethods` CLHSDB
> command:
>
> sun.jvm.hotspot.debugger.DebuggerException : ?w???W
>
> My Windows laptop is set Japanese Locale, garbled message was written in
>
On Mon, 4 Jan 2021 08:34:02 GMT, Aleksey Shipilev wrote:
> JDK-8256831 added the Zero linkage with libatomic for MIPS, but there are
> other 32-bit Zero platforms that need the same kind of treatment.
>
> Additional testing:
> - [x] linux-mipsel-zero-fastdebug build
Marked as reviewed by
Hello Andy,
Sorry for the late reply, but a lot of us have been on holiday.
I recommend starting with the main documentation in the source tree at
doc/building.md. I have no personal experience using Clang for cross
compilation, but I would imagine it would function similar enough to
GCC. To
Hi Guys,
Please review the integration of tzdata2020e to JDK.
Details regarding the change can be viewed at -
https://mm.icann.org/pipermail/tz-announce/2020-December/63.html
Bug: https://bugs.openjdk.java.net/browse/JDK-8258878
Most of the changes are about correcting past timestamps and
On Mon, 4 Jan 2021 10:09:23 GMT, Aleksey Shipilev wrote:
> It is unclear to me why the original change in JDK-8258074 included
> `compiler_globals_pd.hpp` in `globals.hpp` at all, @iklam?
The reason is, for historical reasons, some PD flags related to the compiler,
such as
On Fri, 25 Dec 2020 10:11:13 GMT, Hao Sun
wrote:
> From the error log we can see the root cause is that, develop_pd flag
> 'pd_CICompileOSR' is undeclared in zero build.
>
> Where this flag is used?
> Flag 'pd_CICompileOSR' is assigned to flag 'CICompileOSR'. See line 77
> of
On Tue, 15 Dec 2020 22:56:15 GMT, Magnus Ihse Bursie wrote:
>> A lot (but not all) of the data in make/data is tied to a specific module.
>> For instance, the publicsuffixlist is used by java.base, and fontconfig by
>> java.desktop. (A few directories, like mainmanifest, is *actually* used by
On Tue, 15 Dec 2020 23:15:23 GMT, Magnus Ihse Bursie wrote:
> The `templates` directory in `make` is an odd bird. It actually contains data
> files that the license checker needs, so it should move to `make/data`.
Marked as reviewed by erikj (Reviewer).
-
PR:
On Tue, 15 Dec 2020 23:38:02 GMT, Magnus Ihse Bursie wrote:
> The "symbol" files in make/hotspot/symbols are a list of exported symbols
> from libjvm. As such, they are an essential data source for the build system,
> and they should reside in make/data, not mixed with the hotspot make source
On Tue, 15 Dec 2020 21:17:14 GMT, Magnus Ihse Bursie wrote:
>> The file `make/autoconf/version-numbers` is plagued by a two-fold problem:
>> first of all, it's a configuration file, not a part of autoconf, so it
>> should reside in `make/conf` instead of `make/autoconf`.
>>
>> Secondly,
On Tue, 15 Dec 2020 13:11:30 GMT, Magnus Ihse Bursie wrote:
> Right now `CompileJavaModules.gmk` contains two different part: one part with
> the functionality needed to compile a java module, and one part were all
> special requirements for all modules are listed.
>
> The second part should
On Tue, 15 Dec 2020 14:40:34 GMT, Magnus Ihse Bursie wrote:
>> Right now `CompileJavaModules.gmk` contains two different part: one part
>> with the functionality needed to compile a java module, and one part were
>> all special requirements for all modules are listed.
>>
>> The second part
I got garbled exception message as following when I run `livenmethods` CLHSDB
command:
sun.jvm.hotspot.debugger.DebuggerException : ?w???W
My Windows laptop is set Japanese Locale, garbled message was written in
Japanese.
saproc.dll would throw exception via
On Mon, 4 Jan 2021 09:41:01 GMT, Kim Barrett wrote:
>> I suppose the constructor would be invoked before the copy assignment
>> operator. That is `_vdui` gets initialized already in the ctor
>> `DUIterator_Fast()` for `operator=` case. Right?
>> Take the following code snippet as an example.
On Fri, 25 Dec 2020 10:11:13 GMT, Hao Sun
wrote:
> From the error log we can see the root cause is that, develop_pd flag
> 'pd_CICompileOSR' is undeclared in zero build.
>
> Where this flag is used?
> Flag 'pd_CICompileOSR' is assigned to flag 'CICompileOSR'. See line 77
> of
On Mon, 4 Jan 2021 06:59:54 GMT, Hao Sun
wrote:
>> src/hotspot/share/opto/node.hpp line 1396:
>>
>>> 1394:
>>> 1395: DUIterator_Fast(const DUIterator_Fast& that)
>>> 1396: { _outp = that._outp; debug_only(reset(that)); }
>>
>> `reset` tests `_vdui`, but nothing here has
JDK-8256831 added the Zero linkage with libatomic for MIPS, but there are other
32-bit Zero platforms that need the same kind of treatment.
Additional testing:
- [x] linux-mipsel-zero-fastdebug build
-
Commit messages:
- 8259043: More Zero architectures need linkage with
Hi,
Thanks for the testing and the report, Matthias!
On 12/11/20 11:29 AM, Magnus Ihse Bursie wrote:
If we need -latomic on certain platforms we should add it on those
platforms, but I would prefer not to add it unconditionally. But then
again, if you want to add it for a bunch of system which
38 matches
Mail list logo
