On Fri, 8 Jan 2021 14:57:16 GMT, Erik Joelsson wrote:
> In this case, I think introducing a variable is well worth it as it means we
> can eliminate a very common and unnecessary call to $PATHTOOL.
Ok, I pushed new commit to use `$unixpath` instead of calling `$PATHTOOL`.
Could you review agai
> I ran configure script on WSL 1, but it failed as below:
>
> $ bash configure --enable-debug --with-boot-jdk=/mnt/d/Java/jdk-15.0.1
>
> :
>
> configure: Found potential Boot JDK using configure arguments
> configure: The command for java_to_test, which resolves as
> "/mnt/d/Java/jdk-15.0.
On Wed, 6 Jan 2021 21:14:06 GMT, Phil Race wrote:
> Proposed updates to JNI error handling.
src/java.desktop/macosx/native/libosxapp/JNIUtilities.h line 46:
> 44: if ((*env)->ExceptionOccurred(env) != NULL) { \
> 45: (*env)->ExceptionDescribe(env); \
> 46:
On Fri, 8 Jan 2021 04:40:36 GMT, Sergey Bylokhov wrote:
>> But then "env" would need to be passed explicitly. I don't think the churn
>> is worth it.
>> And a method would then need a .m or .c file ...
>
> But that could be merged to the CallXXXMethod and placed somewhere in the
> libosxapp
Yo
On Thu, 7 Jan 2021 00:35:27 GMT, Sergey Bylokhov wrote:
>> Proposed updates to JNI error handling.
>
> src/java.desktop/macosx/native/libosxapp/JNIUtilities.h line 180:
>
>> 178: * nature of the problem that has been detected and how survivable it
>> is.
>> 179: */
>> 180: #define CHECK_EXCEP
On Fri, 8 Jan 2021 02:40:58 GMT, Phil Race wrote:
>> src/java.desktop/macosx/native/libosxapp/JNIUtilities.h line 41:
>>
>>> 39:NSLog(@"%@",[NSThread callStackSymbols]); \
>>> 40:if ([NSThread isMainThread] == NO) { \
>>> 41:JNU_ThrowInternalError(env, "Bad JNI Lookup
Proposed updates to JNI error handling.
-
Commit messages:
- 8259343: [macOS] Update JNI error handling in Cocoa code.
- 8259343: [macOS] Update JNI error handling in Cocoa code.
Changes: https://git.openjdk.java.net/jdk/pull/1967/files
Webrev: https://webrevs.openjdk.java.net/?re
On Wed, 6 Jan 2021 21:14:06 GMT, Phil Race wrote:
> Proposed updates to JNI error handling.
src/java.desktop/macosx/native/libosxapp/JNIUtilities.h line 180:
> 178: * nature of the problem that has been detected and how survivable it is.
> 179: */
> 180: #define CHECK_EXCEPTION() \
Since thi
On Fri, 8 Jan 2021 11:55:21 GMT, Kim Barrett wrote:
> [Can't comment on this inline.] I'd prefer DUIterator_Last::operator= be
> changed to =default, for consistency with the copy constructor. That would
> require fixing the return type too.
Thanks for your comment. Agree. Will update the code
On Fri, 8 Jan 2021 22:36:01 GMT, Joe Darcy wrote:
> Using the symbol updating script, update the symbol files for API changes in
> JDK 16 build 31.
This pull request has now been integrated.
Changeset: a6539282
Author:Joe Darcy
URL: https://git.openjdk.java.net/jdk/commit/a6539282
S
On Fri, 8 Jan 2021 22:36:01 GMT, Joe Darcy wrote:
> Using the symbol updating script, update the symbol files for API changes in
> JDK 16 build 31.
Marked as reviewed by jjg (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/2010
Using the symbol updating script, update the symbol files for API changes in
JDK 16 build 31.
-
Commit messages:
- 8259512: Update --release 16 symbol information for JDK 16 build 31
Changes: https://git.openjdk.java.net/jdk/pull/2010/files
Webrev: https://webrevs.openjdk.java.net
On Thu, 7 Jan 2021 22:01:51 GMT, Erik Joelsson wrote:
> In JDK-8251551, the top level README file changed names to README.md. In
> jib-profiles.js we have a reference to this file to identify if the current
> source tree is likely to be complete. This reference needs to be updated.
This pull r
> This is an update to javac and javadoc, to introduce support for Preview
> APIs, and generally improve javac and javadoc behavior to more closely adhere
> to JEP 12.
>
> The notable changes are:
>
> * adding support for Preview APIs (javac until now supported primarily only
> preview langua
> This is an update to javac and javadoc, to introduce support for Preview
> APIs, and generally improve javac and javadoc behavior to more closely adhere
> to JEP 12.
>
> The notable changes are:
>
> * adding support for Preview APIs (javac until now supported primarily only
> preview langua
On Fri, 8 Jan 2021 01:51:52 GMT, Jonathan Gibbons wrote:
>> Jan Lahoda has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 57 commits:
>>
>> - Fixing tests after a merge.
>> - Merging master into JDK-8250768
>> - Merging recent mas
On Fri, 8 Jan 2021 14:49:12 GMT, Yasumasa Suenaga wrote:
>> I initially wanted to leave this for Magnus to look at since he wrote all of
>> this, and I know he put a lot of effort into fixpath.sh. It's not a simple
>> script. Now I have stared at it for a while, I think I understand the
>> pro
On Fri, 8 Jan 2021 14:15:08 GMT, Erik Joelsson wrote:
>> Hi Yasumasa,
>>
>> Okay I see the problem case now, and the latest fix seems to fix things in a
>> way that makes sense to me now. We still need to wait to see what Magnus or
>> Erik think though.
>>
>> Thanks,
>> David
>
> I initially
On Fri, 8 Jan 2021 13:07:02 GMT, David Holmes wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Refactoring
>
> Hi Yasumasa,
>
> Okay I see the problem case now, and the latest fix seems to fix things in a
> wa
I agree this would be useful and filed
https://bugs.openjdk.java.net/browse/JDK-8259485
/Erik
On 2021-01-07 21:35, - wrote:
Hello,
This is a followup of
https://mail.openjdk.java.net/pipermail/build-dev/2021-January/029905.html.
In that thread, my build on Windows 10 (not WSL) failed because
On Fri, 8 Jan 2021 12:29:17 GMT, Yasumasa Suenaga wrote:
>> I ran configure script on WSL 1, but it failed as below:
>>
>> $ bash configure --enable-debug --with-boot-jdk=/mnt/d/Java/jdk-15.0.1
>>
>> :
>>
>> configure: Found potential Boot JDK using configure arguments
>> configure: The co
On Fri, 8 Jan 2021 07:34:03 GMT, Yasumasa Suenaga wrote:
>> I ran configure script on WSL 1, but it failed as below:
>>
>> $ bash configure --enable-debug --with-boot-jdk=/mnt/d/Java/jdk-15.0.1
>>
>> :
>>
>> configure: Found potential Boot JDK using configure arguments
>> configure: The co
> I ran configure script on WSL 1, but it failed as below:
>
> $ bash configure --enable-debug --with-boot-jdk=/mnt/d/Java/jdk-15.0.1
>
> :
>
> configure: Found potential Boot JDK using configure arguments
> configure: The command for java_to_test, which resolves as
> "/mnt/d/Java/jdk-15.0.
On Wed, 6 Jan 2021 06:14:11 GMT, Hao Sun
wrote:
>> 1. '-Wdeprecated-copy'
>> As specified in C++11 [1], "the generation of the implicitly-defined
>> copy constructor is deprecated if T has a user-defined destructor or
>> user-defined copy assignment operator". The rationale behind is the
>> well
On 8/01/2021 5:36 pm, Yasumasa Suenaga wrote:
On Thu, 24 Dec 2020 08:04:34 GMT, Yasumasa Suenaga wrote:
I ran configure script on WSL 1, but it failed as below:
$ bash configure --enable-debug --with-boot-jdk=/mnt/d/Java/jdk-15.0.1
:
configure: Found potential Boot JDK using configure
25 matches
Mail list logo
