On Mon, 11 Jan 2021 02:42:09 GMT, Kim Barrett wrote:
>> Hao Sun has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Define the copy assign operator of class DUIterator_Last as defaulted
>>
>> The copy assignment operator of class DUIter
On Wed, 6 Jan 2021 21:14:06 GMT, Phil Race wrote:
> Proposed updates to JNI error handling.
This pull request has now been integrated.
Changeset: d6a2105b
Author:Phil Race
URL: https://git.openjdk.java.net/jdk/commit/d6a2105b
Stats: 75 lines in 8 files changed: 60 ins; 1 del; 14
On Mon, 11 Jan 2021 19:27:12 GMT, Phil Race wrote:
>> Proposed updates to JNI error handling.
>
> Phil Race has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8259343: [macOS] Update JNI error handling in Cocoa code.
Marked as reviewed by ser
On Tue, 12 Jan 2021 17:21:53 GMT, Phil Race wrote:
>> src/java.desktop/macosx/native/libosxapp/JNIUtilities.h line 197:
>>
>>> 195: } \
>>> 196: if (getenv("JNU_NO_COCOA_EXCEPTION") == NULL) { \
>>> 197: [NSException raise:NSGenericException format:@"Java
>>> Excep
On Mon, 11 Jan 2021 02:14:17 GMT, Hao Sun
wrote:
>> 1. '-Wdeprecated-copy'
>> As specified in C++11 [1], "the generation of the implicitly-defined
>> copy constructor is deprecated if T has a user-defined destructor or
>> user-defined copy assignment operator". The rationale behind is the
>> wel
On Tue, 12 Jan 2021 02:31:56 GMT, Sergey Bylokhov wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8259343: [macOS] Update JNI error handling in Cocoa code.
>
> src/java.desktop/macosx/native/libosxapp/JNIUtilities.h l
On Tue, 12 Jan 2021 02:38:11 GMT, Sergey Bylokhov wrote:
>>> Not sure that the check for ExceptionOccurred is needed,
>> It may not be needed in practice but if the code path is never taken no harm
>> ...
>>
>> in all other places where we check the ref to methods/field we only check
>> the r
Hi,
Please review this small change which enables the GB18030 charset to be built
into java.base
Thanks
-
Commit messages:
- 8226810: Failed to launch JVM because of NullPointerException occurred on
System.props
Changes: https://git.openjdk.java.net/jdk/pull/2053/files
Webrev:
On Tue, 12 Jan 2021 06:46:33 GMT, liach
wrote:
> Though this content seems simple, it would be extremely frustrating to
> newcomers, especially when the build stalls at "cannot find valid visual
> studio installation" for no clear reason in logs at all.
Marked as reviewed by erikj (Reviewer).
>> Sure. Is a comment stating that this was backported what you have in mind?
> Preferrably comment + link "backportet by" to your backport issue.
I'll do that once it's in.
Roland.
10 matches
Mail list logo