On Tue, 26 Jan 2021 12:34:11 GMT, Alan Hayward
wrote:
>>> AIUI, the configure line needs passing a prebuilt JavaNativeFoundation
>>> framework
>>> ie:
>>> `--with-extra-ldflags='-F
>>>
On Fri, 15 Jan 2021 04:57:24 GMT, David Holmes wrote:
> We are now confident that we have build-time and runtime support for
> clock_gettime and CLOCK_MONOTONIC on all our OpenJDK supported POSIX
> platforms - see bug report for some more details on different OS.
> Consequently we can
> We are now confident that we have build-time and runtime support for
> clock_gettime and CLOCK_MONOTONIC on all our OpenJDK supported POSIX
> platforms - see bug report for some more details on different OS.
> Consequently we can simplify a lot of the code in this area and move common
> code
On Tue, 26 Jan 2021 09:23:18 GMT, Magnus Ihse Bursie wrote:
>> Anton Kozlov has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Refactor CDS disabling
>> - Redo builsys support for aarch64-darwin
>
>
> Please review the implementation of JEP 391: macOS/AArch64 Port.
>
> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
> windows/aarch64.
>
> Major changes are in:
> * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks
> JDK-8253817, JDK-8253818)
On Tue, 26 Jan 2021 19:33:28 GMT, Weijun Wang wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert harfbuzz changes, disable warnings for it
>
> src/java.security.jgss/share/native/libj2gss/gssapi.h line 48:
>
On Mon, 25 Jan 2021 17:43:35 GMT, Phil Race wrote:
>> Anton Kozlov has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Address feedback for signature generators
>> - Enable -Wformat-nonliteral back
>
>
On Tue, 26 Jan 2021 18:42:02 GMT, Anton Kozlov wrote:
>> Please review the implementation of JEP 391: macOS/AArch64 Port.
>>
>> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
>> windows/aarch64.
>>
>> Major changes are in:
>> * src/hotspot/cpu/aarch64: support of
See for example:
https://github.com/shipilev/jdk/runs/1771453139?check_suite_focus=true
E: Could not configure 'libc6:i386'.
E: Could not perform immediate configuration on 'libgcc-s1:i386'. Please see
man 5 apt.conf under APT::Immediate-Configure for details. (2)
It seems JDK-8259924 helped
On Tue, 26 Jan 2021 16:35:54 GMT, Bernhard Urban-Forster
wrote:
>> @lewurm This and other harfbuzz changes came from MS, could you please
>> comment here ?
>
> This looks like a merge fix mistake:
>
> Please review the implementation of JEP 391: macOS/AArch64 Port.
>
> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
> windows/aarch64.
>
> Major changes are in:
> * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks
> JDK-8253817, JDK-8253818)
On 2021-01-26 04:44, Magnus Ihse Bursie wrote:
On 2021-01-26 13:09, Vladimir Kempik wrote:
On Tue, 26 Jan 2021 12:02:02 GMT, Alan Hayward
wrote:
AIUI, the configure line needs passing a prebuilt
JavaNativeFoundation framework
ie:
`--with-extra-ldflags='-F
On Tue, 26 Jan 2021 16:07:19 GMT, Vladimir Kempik wrote:
>> src/java.desktop/share/native/libharfbuzz/hb-common.h line 113:
>>
>>> 111:
>>> 112: #define HB_TAG(c1,c2,c3,c4)
>>>
On Mon, 25 Jan 2021 17:43:22 GMT, Phil Race wrote:
>> Anton Kozlov has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Address feedback for signature generators
>> - Enable -Wformat-nonliteral back
>
>
Several Linux distros now build with link time optimizations (-flto=auto) by
default. It looks like 15 and newer versions can be built with -flto. I haven't
yet checked test results for LTO/non-LTO builds. I also only tried building with
GCC 10.
11 still fails with
/usr/bin/ld:
> Please review the implementation of JEP 391: macOS/AArch64 Port.
>
> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
> windows/aarch64.
>
> Major changes are in:
> * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks
> JDK-8253817, JDK-8253818)
On Mon, 25 Jan 2021 10:00:20 GMT, Andrew Haley wrote:
>> I like the suggestion. For the defense, new functions were made this way
>> intentionally, to match existing `pass_int`, `pass_long`,.. I take your
>> comment as a blessing to fix all of them. But I feel that refactoring of
>> existing
On Tue, 26 Jan 2021 10:35:03 GMT, Magnus Ihse Bursie wrote:
> For java.base gensrc we do the following:
>
> # Copy two Java files that need no preprocessing.
> $(SUPPORT_OUTPUTDIR)/gensrc/java.base/java/lang/%.java:
> $(CHARACTERDATA_TEMPLATES)/%.java.template
> $(call LogInfo, Generating
On Tue, 26 Jan 2021 10:35:03 GMT, Magnus Ihse Bursie wrote:
> For java.base gensrc we do the following:
>
> # Copy two Java files that need no preprocessing.
> $(SUPPORT_OUTPUTDIR)/gensrc/java.base/java/lang/%.java:
> $(CHARACTERDATA_TEMPLATES)/%.java.template
> $(call LogInfo, Generating
On Tue, 26 Jan 2021 12:42:10 GMT, Magnus Ihse Bursie wrote:
>> I was following up on performance testing results for some ongoing work, and
>> realized that there are `ShenandoahMarkContext::mark_strong` calls from
>> `mark_work_loop`. Those callees were supposed to be inlined. I believe it is
On Tue, 26 Jan 2021 11:41:52 GMT, Aleksey Shipilev wrote:
> I was following up on performance testing results for some ongoing work, and
> realized that there are `ShenandoahMarkContext::mark_strong` calls from
> `mark_work_loop`. Those callees were supposed to be inlined. I believe it is
> a
On Mon, 25 Jan 2021 19:12:17 GMT, Coleen Phillimore wrote:
>> I've tried to do something like this initially. The idea was to use Write in
>> VM state and Exec in Java and Native states. However, for example, JIT runs
>> in the Native state and needs Write access. So instead, W^X is managed on
On 2021-01-26 13:09, Vladimir Kempik wrote:
On Tue, 26 Jan 2021 12:02:02 GMT, Alan Hayward
wrote:
AIUI, the configure line needs passing a prebuilt JavaNativeFoundation framework
ie:
`--with-extra-ldflags='-F
On Tue, 26 Jan 2021 11:41:52 GMT, Aleksey Shipilev wrote:
> I was following up on performance testing results for some ongoing work, and
> realized that there are `ShenandoahMarkContext::mark_strong` calls from
> `mark_work_loop`. Those callees were supposed to be inlined. I believe it is
> a
On Tue, 26 Jan 2021 12:06:28 GMT, Vladimir Kempik wrote:
> > AIUI, the configure line needs passing a prebuilt JavaNativeFoundation
> > framework
> > ie:
> > `--with-extra-ldflags='-F
> >
On Tue, 26 Jan 2021 12:02:02 GMT, Alan Hayward
wrote:
> AIUI, the configure line needs passing a prebuilt JavaNativeFoundation
> framework
> ie:
> `--with-extra-ldflags='-F
> /Applications/Xcode.app/Contents/SharedFrameworks/ContentDeliveryServices.framework/Versions/A/itms/java/Frameworks/'`
On Tue, 26 Jan 2021 09:23:23 GMT, Magnus Ihse Bursie wrote:
>> Anton Kozlov has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Refactor CDS disabling
>> - Redo builsys support for aarch64-darwin
>
> Changes requested by ihse (Reviewer).
On Tue, 26 Jan 2021 11:41:52 GMT, Aleksey Shipilev wrote:
> I was following up on performance testing results for some ongoing work, and
> realized that there are `ShenandoahMarkContext::mark_strong` calls from
> `mark_work_loop`. Those callees were supposed to be inlined. I believe it is
> a
On Tue, 26 Jan 2021 11:31:18 GMT, Anton Kozlov wrote:
>> This could be a follow-up RFE.
>
> I assume a WXVerifier class that tracks W^X mode in debug mode and does
> nothing in release mode. I've considered to do this, it's relates to small
> inefficiencies, while this patch brings zero
I was following up on performance testing results for some ongoing work, and
realized that there are `ShenandoahMarkContext::mark_strong` calls from
`mark_work_loop`. Those callees were supposed to be inlined. I believe it is a
simple omission after JDK-8255019 moved `mark_work_loop` code to
On Tue, 26 Jan 2021 10:35:03 GMT, Magnus Ihse Bursie wrote:
> For java.base gensrc we do the following:
>
> # Copy two Java files that need no preprocessing.
> $(SUPPORT_OUTPUTDIR)/gensrc/java.base/java/lang/%.java:
> $(CHARACTERDATA_TEMPLATES)/%.java.template
> $(call LogInfo, Generating
On Mon, 25 Jan 2021 14:40:42 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/runtime/thread.hpp line 915:
>>
>>> 913: verify_wx_state(WXExec);
>>> 914: }
>>> 915: };
>>
>> Rather than add all this to thread.hpp, can you make a wxVerifier.hpp and
>> just add the class instance
For java.base gensrc we do the following:
# Copy two Java files that need no preprocessing.
$(SUPPORT_OUTPUTDIR)/gensrc/java.base/java/lang/%.java:
$(CHARACTERDATA_TEMPLATES)/%.java.template
$(call LogInfo, Generating $(@F))
$(call install-file)
GENSRC_CHARACTERDATA +=
On Sat, 23 Jan 2021 07:55:09 GMT, Alan Bateman wrote:
> We should create a separate issue to rename them and get rid of the copying
> in the make file.
I opened https://bugs.openjdk.java.net/browse/JDK-8260406.
-
PR: https://git.openjdk.java.net/jdk/pull/1611
On 2021-01-20 06:48, David Holmes wrote:
On 19/01/2021 11:48 pm, Magnus Ihse Bursie wrote:
On 2021-01-19 00:13, David Holmes wrote:
Hard-wiring build numbers seems a maintenance PITA. :( Is there not
a way to do this that is independent of the actual build installed?
I agree that hard-wiring
On Thu, 21 Jan 2021 09:03:57 GMT, Robin Westberg wrote:
>> Normally when running GitHub Actions on a pull request, what is checked out
>> is the merge of the pull request with the latest changes on the target
>> branch. This ensure that what is tested is as close as possible to what will
>>
On Mon, 25 Jan 2021 04:46:52 GMT, David Holmes wrote:
>> We are now confident that we have build-time and runtime support for
>> clock_gettime and CLOCK_MONOTONIC on all our OpenJDK supported POSIX
>> platforms - see bug report for some more details on different OS.
>> Consequently we can
On Mon, 25 Jan 2021 19:38:16 GMT, Anton Kozlov wrote:
>> Please review the implementation of JEP 391: macOS/AArch64 Port.
>>
>> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
>> windows/aarch64.
>>
>> Major changes are in:
>> * src/hotspot/cpu/aarch64: support of
On 1/25/21 5:45 PM, Anton Kozlov wrote:
> I see how this can be done, from looking at C example with `__thread`, which
> involves
> poorly documented relocations and private libc interface invocation.
>
> But now I also wonder how much benefit would we have from this optimization.
OK, so
On Mon, 25 Jan 2021 19:38:16 GMT, Anton Kozlov wrote:
>> Please review the implementation of JEP 391: macOS/AArch64 Port.
>>
>> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
>> windows/aarch64.
>>
>> Major changes are in:
>> * src/hotspot/cpu/aarch64: support of
40 matches
Mail list logo
