Re: RFR: JDK-8260518: Change default -mmacosx-version-min to 10.12

2021-01-27 Thread Sergey Bylokhov
On Wed, 27 Jan 2021 20:43:44 GMT, Phil Race wrote: >> To guarantee backwards compatible binaries on Macos, we use the option >> -mmacosx-version-min. This is currently set to 10.9, which is a really >> ancient version. I propose we bump this to 10.12, which is still a rather >> conservative ol

RFR: 8256421: Add 2 HARICA roots to Oracle Root CA Program

2021-01-27 Thread Rajan Halade
Following two roots are added to cacerts store - CN=Hellenic Academic and Research Institutions RootCA 2015, O=Hellenic Academic and Research Institutions Cert. Authority, L=Athens, C=GR CN=Hellenic Academic and Research Institutions ECC RootCA 2015, O=Hellenic Academic and Research Institution

Re: RFR: JDK-8260518: Change default -mmacosx-version-min to 10.12

2021-01-27 Thread Phil Race
On Wed, 27 Jan 2021 19:23:48 GMT, Erik Joelsson wrote: > To guarantee backwards compatible binaries on Macos, we use the option > -mmacosx-version-min. This is currently set to 10.9, which is a really > ancient version. I propose we bump this to 10.12, which is still a rather > conservative ol

Re: RFR: JDK-8260518: Change default -mmacosx-version-min to 10.12

2021-01-27 Thread Tim Bell
On Wed, 27 Jan 2021 19:23:48 GMT, Erik Joelsson wrote: > To guarantee backwards compatible binaries on Macos, we use the option > -mmacosx-version-min. This is currently set to 10.9, which is a really > ancient version. I propose we bump this to 10.12, which is still a rather > conservative ol

RFR: JDK-8260518: Change default -mmacosx-version-min to 10.12

2021-01-27 Thread Erik Joelsson
To guarantee backwards compatible binaries on Macos, we use the option -mmacosx-version-min. This is currently set to 10.9, which is a really ancient version. I propose we bump this to 10.12, which is still a rather conservative old version (support ended in 2019). The driving issue for bumping

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v6]

2021-01-27 Thread Vladimir Kempik
On Wed, 27 Jan 2021 08:36:19 GMT, Magnus Ihse Bursie wrote: > Build changes per se now looks okay. However, I agree with Erik that unless > this PR can wait for the JNF removal, at the very least the build docs needs > to be updated to explain how to successfully build for this platform. (I can

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v7]

2021-01-27 Thread Anton Kozlov
> Please review the implementation of JEP 391: macOS/AArch64 Port. > > It's heavily based on existing ports to linux/aarch64, macos/x86_64, and > windows/aarch64. > > Major changes are in: > * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks > JDK-8253817, JDK-8253818)

Re: building OpenJDK 11 with link time optimizations?

2021-01-27 Thread Magnus Ihse Bursie
On 2021-01-27 11:42, Matthias Klose wrote: On 1/27/21 10:35 AM, Magnus Ihse Bursie wrote: On 2021-01-26 17:08, Matthias Klose wrote: Several Linux distros now build with link time optimizations (-flto=auto) by default.  It looks like 15 and newer versions can be built with -flto. I haven't ye

Re: RFR: 8260460: GitHub actions still fail on Linux x86_32 with "Could not configure libc6:i386"

2021-01-27 Thread Aleksey Shipilev
On Wed, 27 Jan 2021 10:46:04 GMT, Magnus Ihse Bursie wrote: >> Okay to push now, as to unbreak the GHA? > > Yeah..? What are you waiting for otherwise? The 24 hour rule only apply to > Hotspot coce. I believe 24 hour rule is the generic courtesy rule for everything. So I was asking explicitly

Re: RFR: 8260460: GitHub actions still fail on Linux x86_32 with "Could not configure libc6:i386"

2021-01-27 Thread Magnus Ihse Bursie
On Wed, 27 Jan 2021 09:50:13 GMT, Aleksey Shipilev wrote: >> Marked as reviewed by ihse (Reviewer). > > Okay to push now, as to unbreak the GHA? Yeah..? What are you waiting for otherwise? The 24 hour rule only apply to Hotspot coce. - PR: https://git.openjdk.java.net/jdk/pull/224

Integrated: 8260460: GitHub actions still fail on Linux x86_32 with "Could not configure libc6:i386"

2021-01-27 Thread Aleksey Shipilev
On Tue, 26 Jan 2021 19:08:41 GMT, Aleksey Shipilev wrote: > See for example: > https://github.com/shipilev/jdk/runs/1771453139?check_suite_focus=true > > E: Could not configure 'libc6:i386'. > E: Could not perform immediate configuration on 'libgcc-s1:i386'. Please see > man 5 apt.conf under A

Re: building OpenJDK 11 with link time optimizations?

2021-01-27 Thread Matthias Klose
On 1/27/21 10:35 AM, Magnus Ihse Bursie wrote: > On 2021-01-26 17:08, Matthias Klose wrote: >> Several Linux distros now build with link time optimizations (-flto=auto) by >> default.  It looks like 15 and newer versions can be built with -flto. I >> haven't >> yet checked test results for LTO/non

Re: RFR: 8260460: GitHub actions still fail on Linux x86_32 with "Could not configure libc6:i386"

2021-01-27 Thread Aleksey Shipilev
On Wed, 27 Jan 2021 08:18:56 GMT, Magnus Ihse Bursie wrote: >> See for example: >> https://github.com/shipilev/jdk/runs/1771453139?check_suite_focus=true >> >> E: Could not configure 'libc6:i386'. >> E: Could not perform immediate configuration on 'libgcc-s1:i386'. Please see >> man 5 apt.conf

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v3]

2021-01-27 Thread Andrew Haley
On 1/26/21 6:42 PM, erik.joels...@oracle.com wrote: > My understanding is that Apple chose to not provide JNF for aarch64, so > if you want to build OpenJDK, you first need to build JNF yourself (it's > available in github). Phil is working on removing this dependency > completely, which will solve

Re: building OpenJDK 11 with link time optimizations?

2021-01-27 Thread Magnus Ihse Bursie
On 2021-01-26 17:08, Matthias Klose wrote: Several Linux distros now build with link time optimizations (-flto=auto) by default. It looks like 15 and newer versions can be built with -flto. I haven't yet checked test results for LTO/non-LTO builds. I also only tried building with GCC 10. 11 sti

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v3]

2021-01-27 Thread David Holmes
I don't know why the Skara tools decided to associate my comment with Alan Hayward's comment as they are not at all related. :( David On 27/01/2021 4:50 pm, David Holmes wrote: On Tue, 26 Jan 2021 12:34:11 GMT, Alan Hayward wrote: AIUI, the configure line needs passing a prebuilt JavaNativ

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v6]

2021-01-27 Thread Magnus Ihse Bursie
On Tue, 26 Jan 2021 21:59:03 GMT, Anton Kozlov wrote: >> Please review the implementation of JEP 391: macOS/AArch64 Port. >> >> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and >> windows/aarch64. >> >> Major changes are in: >> * src/hotspot/cpu/aarch64: support of the

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v3]

2021-01-27 Thread Magnus Ihse Bursie
On Tue, 26 Jan 2021 22:04:48 GMT, Vladimir Kempik wrote: >> make/autoconf/build-aux/autoconf-config.guess line 1275: >> >>> 1273: UNAME_PROCESSOR="aarch64" >>> 1274: fi >>> 1275: fi ;; >> >> Almost, but not quite, correct. We cannot change the a

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v6]

2021-01-27 Thread Magnus Ihse Bursie
On Mon, 25 Jan 2021 16:00:23 GMT, Bernhard Urban-Forster wrote: >> @luhenry , could you please check this comment, I think SA-agent was MS's >> job here. > > The target is identified by the header file now: > https://github.com/openjdk/jdk/pull/2200/files#diff-51442e74eeef2163f0f0643df0ae995083

Re: RFR: 8260460: GitHub actions still fail on Linux x86_32 with "Could not configure libc6:i386"

2021-01-27 Thread Magnus Ihse Bursie
On Tue, 26 Jan 2021 19:08:41 GMT, Aleksey Shipilev wrote: > See for example: > https://github.com/shipilev/jdk/runs/1771453139?check_suite_focus=true > > E: Could not configure 'libc6:i386'. > E: Could not perform immediate configuration on 'libgcc-s1:i386'. Please see > man 5 apt.conf under A