Re: RFR: 8260193: Remove JVM_GetInterfaceVersion() and JVM_DTraceXXX [v2]

On Tue, 2 Feb 2021 16:00:43 GMT, Gerard Ziemski wrote: >> I am not sure if jni_utils.c is the right file (it defines the `JNU_XXX` >> functions that are used by other shared libraries). >> >> There are other .c files that have trivial `DEF_JNI_OnLoad` functions (e.g., >>

Integrated: 8260193: Remove JVM_GetInterfaceVersion() and JVM_DTraceXXX

On Mon, 1 Feb 2021 18:40:54 GMT, Ioi Lam wrote: > - JVM_GetInterfaceVersion() was used by "HotSpot Express" (HSX) which allowed > the same JDK library to use different version of HotSpot. However, HSX is no > longer supported so this API should be removed. > - Implementations of APIs such as

Re: RFR: 8260193: Remove JVM_GetInterfaceVersion() and JVM_DTraceXXX [v2]

On Tue, 2 Feb 2021 15:59:47 GMT, Gerard Ziemski wrote: >> Ioi Lam has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fixed macos build > > Marked as reviewed by gziemski (Committer). Thanks @gerard-ziemski @magicus @AlanBateman @lfoltan

Re: RFR: 8260616: Removing remaining JNF dependencies in the java.desktop module [v2]

On Tue, 2 Feb 2021 21:26:28 GMT, Kevin Rushforth wrote: >> The changes look good to me, but please see my comment from my review about >> documenting `NormalizedPathNSStringFromJavaString()` API. > > The following commit was integrated to jdk master since you created this > branch: > >

Re: RFR: 8260616: Removing remaining JNF dependencies in the java.desktop module [v4]

> This completes the desktop module JNF removal > > * remove -framework JavaNativeFoundation from make files > > * remove #import from all > source files. If needed add import of JNIUtilities.h to get jni.h definitions > - better anyway since then it gets the current JDK ones not the ones

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v9]

On Tue, 2 Feb 2021 11:59:08 GMT, Anton Kozlov wrote: >> Please review the implementation of JEP 391: macOS/AArch64 Port. >> >> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and >> windows/aarch64. >> >> Major changes are in: >> * src/hotspot/cpu/aarch64: support of the

Re: RFR: 8260616: Removing remaining JNF dependencies in the java.desktop module [v3]

On Tue, 2 Feb 2021 22:33:09 GMT, Phil Race wrote: >> I read it and not sure that it is fine to ignore this error, why not throw >> an exception and signal the CTextPipe_doDrawString that an error occurred >> like InvalidPipeException or something(Sometimes we wrap other exception >> like OOM

Re: RFR: 8260616: Removing remaining JNF dependencies in the java.desktop module [v3]

On Tue, 2 Feb 2021 21:48:36 GMT, Sergey Bylokhov wrote: >> Look a few lines further up at my reply 3 days ago Gerard about this. > > I read it and not sure that it is fine to ignore this error, why not throw an > exception and signal the CTextPipe_doDrawString that an error occurred like >

Re: RFR: 8260616: Removing remaining JNF dependencies in the java.desktop module [v3]

On Tue, 2 Feb 2021 22:02:14 GMT, Sergey Bylokhov wrote: >> I ran some tests embedding JavaFX into Swing and vice versa both with and >> without `-Djavafx.embed.singleThread=true` and I don't see any regression in >> behavior. > > I am mostly worried about the usage of JNF by someone else's

Re: RFR: 8260616: Removing remaining JNF dependencies in the java.desktop module [v3]

On Mon, 1 Feb 2021 23:47:06 GMT, Phil Race wrote: >> src/java.desktop/macosx/native/libawt_lwawt/awt/CTextPipe.m line 611: >> >>> 609: const jchar *unichars = (*env)->GetStringChars(env, str, NULL); >>> 610: if (unichars == NULL) { >>> 611: return; >> >> Do not we

Re: RFR: 8260616: Removing remaining JNF dependencies in the java.desktop module [v3]

On Tue, 2 Feb 2021 21:18:42 GMT, Kevin Rushforth wrote: >> We are just specifying an additional run mode for JDK internal use. >> It means that when we are saying to process only events for that mode, then >> only those will be processed. >> And it is used only for nested event loops. >>

Re: RFR: 8260616: Removing remaining JNF dependencies in the java.desktop module [v2]

On Mon, 1 Feb 2021 18:33:32 GMT, Gerard Ziemski wrote: >> Marked as reviewed by gziemski (Committer). > > The changes look good to me, but please see my comment from my review about > documenting `NormalizedPathNSStringFromJavaString()` API. The following commit was integrated to jdk master

Re: RFR: 8260616: Removing remaining JNF dependencies in the java.desktop module [v3]

On Tue, 2 Feb 2021 00:30:07 GMT, Phil Race wrote: >> src/java.desktop/macosx/native/libosxapp/ThreadUtilities.m line 53: >> >>> 51: @implementation ThreadUtilities >>> 52: >>> 53: + (void)initialize { >> >> I think we need to check how this new modes will work when the AWT is >> embedded

Re: RFR: 8257988: Remove JNF dependency from libsaproc/MacosxDebuggerLocal.m

On Thu, 28 Jan 2021 22:40:57 GMT, Phil Race wrote: > This removes the JNF dependency from the jdk.hotspot.agent module. > The macro expansions are the same as already used in the Java desktop module > - which actually uses a macro > still but there there are hundreds of uses. > The function of

Re: [jdk16] RFR: 8259794: Remove EA from JDK 16 version string starting with Initial RC promotion on Feb 04, 2021(B35)

On Tue, 2 Feb 2021 18:17:55 GMT, Jesper Wilhelmsson wrote: > We have our (first) RC candidate build for JDK 16 on Feb 04, 2021. We need to > remove the EA from version string for this build (b35) and going forward. > > Pushing this for @pashh Marked as reviewed by mikael (Reviewer).

[jdk16] Integrated: 8259794: Remove EA from JDK 16 version string starting with Initial RC promotion on Feb 04, 2021(B35)

On Tue, 2 Feb 2021 18:17:55 GMT, Jesper Wilhelmsson wrote: > We have our (first) RC candidate build for JDK 16 on Feb 04, 2021. We need to > remove the EA from version string for this build (b35) and going forward. > > Pushing this for @pashh This pull request has now been integrated.

Re: [jdk16] RFR: 8259794: Remove EA from JDK 16 version string starting with Initial RC promotion on Feb 04, 2021(B35)

On Tue, 2 Feb 2021 18:17:55 GMT, Jesper Wilhelmsson wrote: > We have our (first) RC candidate build for JDK 16 on Feb 04, 2021. We need to > remove the EA from version string for this build (b35) and going forward. > > Pushing this for @pashh Marked as reviewed by iignatyev (Reviewer).

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v9]

On Tue, 2 Feb 2021 18:23:04 GMT, Gerard Ziemski wrote: >> Anton Kozlov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> support macos_aarch64 in hsdis > > src/hotspot/os/posix/signals_posix.cpp line 1297: > >> 1295: kern_return_t kr;

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v9]

On Tue, 2 Feb 2021 18:52:29 GMT, Gerard Ziemski wrote: >> Anton Kozlov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> support macos_aarch64 in hsdis > > Changes requested by gziemski (Committer). There were bunch of assembly code that

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v9]

On Tue, 2 Feb 2021 11:59:08 GMT, Anton Kozlov wrote: >> Please review the implementation of JEP 391: macOS/AArch64 Port. >> >> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and >> windows/aarch64. >> >> Major changes are in: >> * src/hotspot/cpu/aarch64: support of the

Re: [jdk16] RFR: 8259794: Remove EA from JDK 16 version string starting with Initial RC promotion on Feb 04, 2021(B35)

On Tue, 2 Feb 2021 18:17:55 GMT, Jesper Wilhelmsson wrote: > We have our (first) RC candidate build for JDK 16 on Feb 04, 2021. We need to > remove the EA from version string for this build (b35) and going forward. > > Pushing this for @pashh Marked as reviewed by pa...@github.com (no known

[jdk16] RFR: 8259794: Remove EA from JDK 16 version string starting with Initial RC promotion on Feb 04, 2021(B35)

We have our (first) RC candidate build for JDK 16 on Feb 04, 2021. We need to remove the EA from version string for this build (b35) and going forward. Pushing this for @pashh - Commit messages: - Remove ea Changes: https://git.openjdk.java.net/jdk16/pull/146/files Webrev:

Re: [External] : Re: AArch64 OpenJDK bootstrap failure on head

(dropping Andrew and Aleksey) On Tue, Feb 2, 2021 at 6:13 PM Ioi Lam wrote: > > > On 2/2/21 1:32 AM, Thomas Stüfe wrote: > > > > On Mon, Feb 1, 2021 at 10:11 PM Ioi Lam wrote: > >> On 2/1/21 9:36 AM, Thomas Stüfe wrote: >> >> This does not solve the alignment problem, but I don't like that we

Re: [External] : Re: AArch64 OpenJDK bootstrap failure on head

On 2/2/21 1:32 AM, Thomas Stüfe wrote: On Mon, Feb 1, 2021 at 10:11 PM Ioi Lam > wrote: On 2/1/21 9:36 AM, Thomas Stüfe wrote: This does not solve the alignment problem, but I don't like that we unconditionally print a message here since this is a

Re: RFR: 8260193: Remove JVM_GetInterfaceVersion() and JVM_DTraceXXX [v2]

On Mon, 1 Feb 2021 20:10:58 GMT, Ioi Lam wrote: >> - JVM_GetInterfaceVersion() was used by "HotSpot Express" (HSX) which >> allowed the same JDK library to use different version of HotSpot. However, >> HSX is no longer supported so this API should be removed. >> - Implementations of APIs such

Re: RFR: 8260193: Remove JVM_GetInterfaceVersion() and JVM_DTraceXXX [v2]

On Mon, 1 Feb 2021 20:54:42 GMT, Ioi Lam wrote: >> src/java.base/share/native/libjava/check_version.c line 33: >> >>> 31: DEF_JNI_OnLoad(JavaVM *vm, void *reserved) >>> 32: { >>> 33: return JNI_VERSION_1_2; >> >> This leaves an entire file with one trivial function implementation. Can we

Re: RFR: 8259886 : Improve SSL session cache performance and scalability [v2]

On Tue, 2 Feb 2021 02:37:39 GMT, Xue-Lei Andrew Fan wrote: > the benchmark performance improvement is a trade-off between CPU and memory, > by keeping expired entries while putting a new entry in the cache Not exactly. The memory use is capped by cache size. The patch is a trade off between

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v6]

On Tue, 2 Feb 2021 11:56:12 GMT, Vladimir Kempik wrote: > > > > Hello, hsdis is a separate out-of-tree project and is not part of this > > > > jep. > > > > > > > > > Unless there's something I'm missing it only requires a few lines of > > > change to src/utils/hsdis/makefile (it already has

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v6]

On Tue, 2 Feb 2021 11:14:12 GMT, Vladimir Kempik wrote: > > > > Hello, hsdis is a separate out-of-tree project and is not part of this > > > > jep. > > > > > > > > > Unless there's something I'm missing it only requires a few lines of > > > change to src/utils/hsdis/makefile (it already has

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v9]

> Please review the implementation of JEP 391: macOS/AArch64 Port. > > It's heavily based on existing ports to linux/aarch64, macos/x86_64, and > windows/aarch64. > > Major changes are in: > * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks > JDK-8253817, JDK-8253818)

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v6]

On Mon, 1 Feb 2021 14:06:32 GMT, Magnus Ihse Bursie wrote: >>> Hello, hsdis is a separate out-of-tree project and is not part of this jep. >> >> Unless there's something I'm missing it only requires a few lines of change >> to src/utils/hsdis/makefile (it already has support for macos x86_64)

Re: AArch64 OpenJDK bootstrap failure on head

On Mon, Feb 1, 2021 at 10:11 PM Ioi Lam wrote: > On 2/1/21 9:36 AM, Thomas Stüfe wrote: > > This does not solve the alignment problem, but I don't like that we > unconditionally print a message here since this is a non-fatal error. Also, > CDS mapping may fail for other reasons, for which we do

Re: RFR: 8260193: Remove JVM_GetInterfaceVersion() and JVM_DTraceXXX [v2]

On Mon, 1 Feb 2021 20:10:58 GMT, Ioi Lam wrote: >> - JVM_GetInterfaceVersion() was used by "HotSpot Express" (HSX) which >> allowed the same JDK library to use different version of HotSpot. However, >> HSX is no longer supported so this API should be removed. >> - Implementations of APIs such

Re: RFR: 8257858: [macOS]: Remove JNF dependency from libosxsecurity/KeystoreImpl.m [v7]

On Mon, 1 Feb 2021 16:51:12 GMT, Weijun Wang wrote: >> This fix covers both >> >> - [[macOS]: Remove JNF dependency from >> libosxsecurity/KeystoreImpl.m](https://bugs.openjdk.java.net/browse/JDK-8257858) >> - [[macOS]: Remove JNF dependency from >>