Integrated: 8262893: Enable more doclint checks in javadoc build

2021-03-02 Thread Joe Darcy
On Tue, 2 Mar 2021 22:41:38 GMT, Joe Darcy wrote: > With recent cleanups, several doclint categories have been cleared across the > JDK and should be enabled in the javadoc build to make sure they stay clean. > > Local docs build completes with this stricter set of checks. This pull request ha

Re: RFR: 8262893: Enable more doclint checks in javadoc build

2021-03-02 Thread Erik Joelsson
On Tue, 2 Mar 2021 22:41:38 GMT, Joe Darcy wrote: > With recent cleanups, several doclint categories have been cleared across the > JDK and should be enabled in the javadoc build to make sure they stay clean. > > Local docs build completes with this stricter set of checks. Marked as reviewed b

Re: RFR: 8262893: Enable more doclint checks in javadoc build

2021-03-02 Thread liach
On Wed, 3 Mar 2021 00:23:04 GMT, Jonathan Gibbons wrote: >> With recent cleanups, several doclint categories have been cleared across >> the JDK and should be enabled in the javadoc build to make sure they stay >> clean. >> >> Local docs build completes with this stricter set of checks. > > 👍

Re: RFR: 8262893: Enable more doclint checks in javadoc build

2021-03-02 Thread Jonathan Gibbons
On Tue, 2 Mar 2021 22:41:38 GMT, Joe Darcy wrote: > With recent cleanups, several doclint categories have been cleared across the > JDK and should be enabled in the javadoc build to make sure they stay clean. > > Local docs build completes with this stricter set of checks. 👍 - Ma

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v23]

2021-03-02 Thread David Holmes
On Tue, 2 Mar 2021 21:19:18 GMT, Anton Kozlov wrote: >> Please review the implementation of JEP 391: macOS/AArch64 Port. >> >> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and >> windows/aarch64. >> >> Major changes are in: >> * src/hotspot/cpu/aarch64: support of the

RFR: 8262893: Enable more doclint checks in javadoc build

2021-03-02 Thread Joe Darcy
With recent cleanups, several doclint categories have been cleared across the JDK and should be enabled in the javadoc build to make sure they stay clean. Local docs build completes with this stricter set of checks. - Commit messages: - 8262893: Enable more doclint checks in javado

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v10]

2021-03-02 Thread Anton Kozlov
On Thu, 4 Feb 2021 22:58:39 GMT, Gerard Ziemski wrote: >> Anton Kozlov has updated the pull request incrementally with six additional >> commits since the last revision: >> >> - Merge remote-tracking branch 'origin/jdk/jdk-macos' into jdk-macos >> - Add comments to WX transitions >> >>

Re: RFR: 8259886 : Improve SSL session cache performance and scalability [v2]

2021-03-02 Thread djelinski
On Mon, 22 Feb 2021 21:31:21 GMT, Xue-Lei Andrew Fan wrote: >> Actually there's a much easier solution to reduce the number of slow >> `put()`s without making any behavioral changes. >> The cache object could store the earliest expire time, and then exit >> `expungeExpiredEntries()` early when

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v23]

2021-03-02 Thread Anton Kozlov
> Please review the implementation of JEP 391: macOS/AArch64 Port. > > It's heavily based on existing ports to linux/aarch64, macos/x86_64, and > windows/aarch64. > > Major changes are in: > * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks > JDK-8253817, JDK-8253818)

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v10]

2021-03-02 Thread Anton Kozlov
On Fri, 12 Feb 2021 15:21:06 GMT, Vladimir Kempik wrote: >> src/hotspot/os_cpu/bsd_aarch64/os_bsd_aarch64.cpp line 302: >> >>> 300: const uint64_t *detail_msg_ptr >>> 301: = (uint64_t*)(pc + NativeInstruction::instruction_size); >>> 302: const char *detail_msg = (const

Re: RFR: 8259886 : Improve SSL session cache performance and scalability [v5]

2021-03-02 Thread djelinski
> Under certain load, MemoryCache operations take a substantial fraction of the > time needed to complete SSL handshakes. This series of patches improves > performance characteristics of MemoryCache, at the cost of a functional > change: expired entries are no longer guaranteed to be removed bef

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v10]

2021-03-02 Thread Anton Kozlov
On Thu, 4 Feb 2021 22:34:16 GMT, Gerard Ziemski wrote: >> Anton Kozlov has updated the pull request incrementally with six additional >> commits since the last revision: >> >> - Merge remote-tracking branch 'origin/jdk/jdk-macos' into jdk-macos >> - Add comments to WX transitions >> >>

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v10]

2021-03-02 Thread Anton Kozlov
On Thu, 4 Feb 2021 22:15:47 GMT, Gerard Ziemski wrote: >> Anton Kozlov has updated the pull request incrementally with six additional >> commits since the last revision: >> >> - Merge remote-tracking branch 'origin/jdk/jdk-macos' into jdk-macos >> - Add comments to WX transitions >> >>

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v9]

2021-03-02 Thread Anton Kozlov
On Tue, 2 Feb 2021 23:10:17 GMT, Daniel D. Daugherty wrote: > For platform files that were copied from other ports to this port, if the > file wasn't > changed I presume the copyright years are left alone. If the file required > changes > for this port, I expect the year to be updated to 2021.

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v9]

2021-03-02 Thread Anton Kozlov
On Tue, 2 Feb 2021 22:47:04 GMT, Daniel D. Daugherty wrote: >> Anton Kozlov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> support macos_aarch64 in hsdis > > src/hotspot/share/prims/nativeEntryPoint.cpp line 45: > >> 43: guarantee(st

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v9]

2021-03-02 Thread Anton Kozlov
On Tue, 2 Feb 2021 22:18:43 GMT, Daniel D. Daugherty wrote: >> Anton Kozlov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> support macos_aarch64 in hsdis > > src/hotspot/os_cpu/bsd_aarch64/thread_bsd_aarch64.cpp line 43: > >> 41: ass

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v9]

2021-03-02 Thread Anton Kozlov
On Fri, 12 Feb 2021 13:32:52 GMT, Vladimir Kempik wrote: >> src/hotspot/os_cpu/bsd_aarch64/os_bsd_aarch64.cpp line 486: >> >>> 484: } >>> 485: } >>> 486: } >> >> This appears to be a mix for Mavericks (10.9) and 10.12 >> work arounds. Is this code needed by this project? > > I

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v9]

2021-03-02 Thread Anton Kozlov
On Fri, 12 Feb 2021 12:40:09 GMT, Florian Weimer wrote: >> only macos comiplers > > The comment is also wrong for glibc: The AArch64 ABI requires a 64 KiB guard > region independently of page size, otherwise `-fstack-clash-protection` is > not reliable. Thanks, I deleted the comment. It descri