Re: RFR: 8265696: Move CDS sources to src/hotspot/shared/cds [v6]

2021-04-22 Thread Ioi Lam
On Thu, 22 Apr 2021 06:10:17 GMT, Thomas Stuefe wrote: >> Ioi Lam has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains 11 additional commits >> since

Integrated: 8265696: Move CDS sources to src/hotspot/shared/cds

2021-04-22 Thread Ioi Lam
On Wed, 21 Apr 2021 21:55:25 GMT, Ioi Lam wrote: > The number of CDS source files have grown significantly. To improve > modularity, the following files should be moved a new directory, > src/hotspot/share/cds. > > - src/hotspot/share/classfile/classListParser.cpp > - src/hotspot/share/classfi

Re: RFR: 8265696: Move CDS sources to src/hotspot/shared/cds [v6]

2021-04-22 Thread Ioi Lam
> The number of CDS source files have grown significantly. To improve > modularity, the following files should be moved a new directory, > src/hotspot/share/cds. > > - src/hotspot/share/classfile/classListParser.cpp > - src/hotspot/share/classfile/classListParser.hpp > - src/hotspot/share/classf

Re: RFR: 8260517: implement Sealed Classes as a standard feature in Java [v4]

2021-04-22 Thread Vicente Romero
> Please review this PR that intents to make sealed classes a final feature in > Java. This PR contains compiler and VM changes. In line with similar PRs, > which has made preview features final, this one is mostly removing preview > related comments from APIs plus options in test cases. Please

Re: RFR: 8265696: Move CDS sources to src/hotspot/shared/cds [v5]

2021-04-22 Thread David Holmes
On Fri, 23 Apr 2021 01:23:56 GMT, Ioi Lam wrote: >> The number of CDS source files have grown significantly. To improve >> modularity, the following files should be moved a new directory, >> src/hotspot/share/cds. >> >> - src/hotspot/share/classfile/classListParser.cpp >> - src/hotspot/share/c

Re: RFR: 8265696: Move CDS sources to src/hotspot/shared/cds [v5]

2021-04-22 Thread Ioi Lam
> The number of CDS source files have grown significantly. To improve > modularity, the following files should be moved a new directory, > src/hotspot/share/cds. > > - src/hotspot/share/classfile/classListParser.cpp > - src/hotspot/share/classfile/classListParser.hpp > - src/hotspot/share/classf

Re: RFR: 8265696: Move CDS sources to src/hotspot/shared/cds [v4]

2021-04-22 Thread Ioi Lam
> The number of CDS source files have grown significantly. To improve > modularity, the following files should be moved a new directory, > src/hotspot/share/cds. > > - src/hotspot/share/classfile/classListParser.cpp > - src/hotspot/share/classfile/classListParser.hpp > - src/hotspot/share/classf

RFR: 8265783: Create a separate library for x86 Intel SVML assembly intrinsics

2021-04-22 Thread Sandhya Viswanathan
Intel Short Vector Math Library (SVML) based intrinsics in native x86 assembly provide optimized implementation for Vector API transcendental and trigonometric methods. These methods are built into a separate library instead of being part of libjvm.so or jvm.dll. The following changes are made:

Integrated: 8265782: Bump bootjdk to jdk-17+19 on macosx-aarch64 at Oracle

2021-04-22 Thread Mikael Vidstedt
On Thu, 22 Apr 2021 18:15:58 GMT, Mikael Vidstedt wrote: > The bootjdk used for macosx-aarch64 at Oracle is a custom build of JDK 16 > from early December, so does not include all the JDK 16 GA functionality. > This leads to build issues after JDK-8263621 which uses a method not included > in

Re: RFR: 8265782: Bump bootjdk to jdk-17+19 on macosx-aarch64 at Oracle

2021-04-22 Thread Erik Joelsson
On Thu, 22 Apr 2021 18:15:58 GMT, Mikael Vidstedt wrote: > The bootjdk used for macosx-aarch64 at Oracle is a custom build of JDK 16 > from early December, so does not include all the JDK 16 GA functionality. > This leads to build issues after JDK-8263621 which uses a method not included > in

Re: RFR: 8265782: Bump bootjdk to jdk-17+19 on macosx-aarch64 at Oracle

2021-04-22 Thread Iris Clark
On Thu, 22 Apr 2021 18:15:58 GMT, Mikael Vidstedt wrote: > The bootjdk used for macosx-aarch64 at Oracle is a custom build of JDK 16 > from early December, so does not include all the JDK 16 GA functionality. > This leads to build issues after JDK-8263621 which uses a method not included > in

Re: RFR: 8265782: Bump bootjdk to jdk-17+19 on macosx-aarch64 at Oracle

2021-04-22 Thread Tim Bell
On Thu, 22 Apr 2021 18:15:58 GMT, Mikael Vidstedt wrote: > The bootjdk used for macosx-aarch64 at Oracle is a custom build of JDK 16 > from early December, so does not include all the JDK 16 GA functionality. > This leads to build issues after JDK-8263621 which uses a method not included > in

RFR: 8265782: Bump bootjdk to jdk-17+19 on macosx-aarch64 at Oracle

2021-04-22 Thread Mikael Vidstedt
The bootjdk used for macosx-aarch64 at Oracle is a custom build of JDK 16 from early December, so does not include all the JDK 16 GA functionality. This leads to build issues after JDK-8263621 which uses a method not included in the custom version. Let's bump the bootjdk used for macosx-aarch64

Re: RFR: 8265782: Bump bootjdk to jdk-17+19 on macosx-aarch64 at Oracle

2021-04-22 Thread Igor Ignatyev
On Thu, 22 Apr 2021 18:15:58 GMT, Mikael Vidstedt wrote: > The bootjdk used for macosx-aarch64 at Oracle is a custom build of JDK 16 > from early December, so does not include all the JDK 16 GA functionality. > This leads to build issues after JDK-8263621 which uses a method not included > in

Re: RFR: 8265531: doc/building.md should mention homebrew install freetype

2021-04-22 Thread Erik Joelsson
On Tue, 20 Apr 2021 14:58:02 GMT, George Adams wrote: > Updates the docs/building.html guide to include steps to install FreeType on > macOS using homebrew. Marked as reviewed by erikj (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/3590

Re: RFR: 8265702: ZGC on macOS/aarch64 [v2]

2021-04-22 Thread Gerard Ziemski
On Thu, 22 Apr 2021 06:43:45 GMT, Per Liden wrote: >> This patch enables ZGC on macOS/aarch64. It does three things: >> 1) Enables building of ZGC on this platform. >> 2) Adds `os::processor_id()`, which for now always returns 0. >> 3) Fixes a WX issue in `OptoRuntime::handle_exception_C()`, wher

RFR: 8265531: doc/building.md should mention homebrew install freetype

2021-04-22 Thread George Adams
Updates the docs/building.html guide to include steps to install FreeType on macOS using homebrew. - Commit messages: - add macOS freetype install steps to docs/building.html Changes: https://git.openjdk.java.net/jdk/pull/3590/files Webrev: https://webrevs.openjdk.java.net/?repo=j

Re: RFR: 8265696 move cds sources [v3]

2021-04-22 Thread Erik Joelsson
On Thu, 22 Apr 2021 06:19:29 GMT, Ioi Lam wrote: >> I don't suppose we can just exclude the new directory rather than listing >> individual files? > > Fixed. Now all files under share/cds are excluded. I needed to move > compactHashtable.cpp back to its old location since a little of it is used

Re: RFR: 8265696 move cds sources [v3]

2021-04-22 Thread Erik Joelsson
On Thu, 22 Apr 2021 06:27:45 GMT, Ioi Lam wrote: >> The number of CDS source files have grown significantly. To improve >> modularity, the following files should be moved a new directory, >> src/hotspot/share/cds. >> >> - src/hotspot/share/classfile/classListParser.cpp >> - src/hotspot/share/c