Re: RFR: 8261169: Upgrade HarfBuzz to the latest 2.8.0

2021-04-30 Thread Sergey Bylokhov
On Fri, 30 Apr 2021 20:07:53 GMT, Phil Race wrote: > Upgrade to harfbuzz 2.8 I assume the build using bundled lib is fine on all our platforms. - Marked as reviewed by serb (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/3826

RFR: 8261169: Upgrade HarfBuzz to the latest 2.8.0

2021-04-30 Thread Phil Race
Upgrade to harfbuzz 2.8 - Commit messages: - 8261169: Upgrade HarfBuzz to the latest 2.8.0 Changes: https://git.openjdk.java.net/jdk/pull/3826/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3826&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8261169 Stats

Re: RFR: 8266318: Switch to macos prefix for macOS bundles [v2]

2021-04-30 Thread Mikael Vidstedt
On Fri, 30 Apr 2021 03:51:18 GMT, Mikael Vidstedt wrote: >> Apple rebranded the operating system as "macOS" back in 2016. The JDK >> bundles files are still use the legacy "osx" string. They should be >> modernized to use "macos" instead. > > Mikael Vidstedt has updated the pull request increme

Integrated: 8266318: Switch to macos prefix for macOS bundles

2021-04-30 Thread Mikael Vidstedt
On Thu, 29 Apr 2021 19:15:52 GMT, Mikael Vidstedt wrote: > Apple rebranded the operating system as "macOS" back in 2016. The JDK bundles > files are still use the legacy "osx" string. They should be modernized to use > "macos" instead. This pull request has now been integrated. Changeset: 096

Re: RFR: 8260517: implement Sealed Classes as a standard feature in Java [v5]

2021-04-30 Thread Vicente Romero
> Please review this PR that intents to make sealed classes a final feature in > Java. This PR contains compiler and VM changes. In line with similar PRs, > which has made preview features final, this one is mostly removing preview > related comments from APIs plus options in test cases. Please

Re: RFR: 8255566: Initialize JDK_Version direct from the build system

2021-04-30 Thread Coleen Phillimore
On Fri, 30 Apr 2021 09:19:57 GMT, David Holmes wrote: > The existing logic does: > > build system -> java.lang.VersionProps -> VM thread.cpp fixed-size static > buffers -> JDK_Version class > > we can simply do: > > build system -> JDK_Version class > > reduces footprint, loc and startup tim

Re: RFR: 8255566: Initialize JDK_Version direct from the build system

2021-04-30 Thread David Holmes
On Fri, 30 Apr 2021 09:19:57 GMT, David Holmes wrote: > The existing logic does: > > build system -> java.lang.VersionProps -> VM thread.cpp fixed-size static > buffers -> JDK_Version class > > we can simply do: > > build system -> JDK_Version class > > reduces footprint, loc and startup tim

Withdrawn: 8255566: Initialize JDK_Version direct from the build system

2021-04-30 Thread David Holmes
On Fri, 30 Apr 2021 09:19:57 GMT, David Holmes wrote: > The existing logic does: > > build system -> java.lang.VersionProps -> VM thread.cpp fixed-size static > buffers -> JDK_Version class > > we can simply do: > > build system -> JDK_Version class > > reduces footprint, loc and startup tim

Re: RFR: 8255566: Initialize JDK_Version direct from the build system

2021-04-30 Thread David Holmes
On Fri, 30 Apr 2021 09:19:57 GMT, David Holmes wrote: > The existing logic does: > > build system -> java.lang.VersionProps -> VM thread.cpp fixed-size static > buffers -> JDK_Version class > > we can simply do: > > build system -> JDK_Version class > > reduces footprint, loc and startup tim

Re: RFR: 8255566: Initialize JDK_Version direct from the build system

2021-04-30 Thread Erik Joelsson
On Fri, 30 Apr 2021 09:19:57 GMT, David Holmes wrote: > The existing logic does: > > build system -> java.lang.VersionProps -> VM thread.cpp fixed-size static > buffers -> JDK_Version class > > we can simply do: > > build system -> JDK_Version class > > reduces footprint, loc and startup tim

RFR: 8255566: Initialize JDK_Version direct from the build system

2021-04-30 Thread David Holmes
The existing logic does: build system -> java.lang.VersionProps -> VM thread.cpp fixed-size static buffers -> JDK_Version class we can simply do: build system -> JDK_Version class reduces footprint, loc and startup time. Testing tiers 1-3 and manual visual inspection of version strings Thank