Re: RFR: 8266545: 8261169 broke Harfbuzz build with gcc 7 and 8

2021-05-05 Thread Thomas Stuefe
On Wed, 5 May 2021 07:54:20 GMT, Thomas Stuefe wrote: > Harfbuzz upgrade broke Linux x64 build on older gccs. For details see JBS > issue. > > I fixed the issue in the harfbuzz sources, but I am not sure of the policy > here. Do we modify the harfbuzz sources or leave them untouched? Advice is

Re: RFR: 8266545: 8261169 broke Harfbuzz build with gcc 7 and 8 [v2]

2021-05-05 Thread Thomas Stuefe
On Thu, 6 May 2021 06:16:36 GMT, Aleksey Shipilev wrote: >> Thomas Stuefe has updated the pull request incrementally with one additional >> commit since the last revision: >> >> switch off warning in build instead of fixing it > > FWIW, current jdk master builds fine with gcc 9.3.0. It fails

Re: RFR: 8266545: 8261169 broke Harfbuzz build with gcc 7 and 8 [v2]

2021-05-05 Thread Thomas Stuefe
> Harfbuzz upgrade broke Linux x64 build on older gccs. For details see JBS > issue. > > I fixed the issue in the harfbuzz sources, but I am not sure of the policy > here. Do we modify the harfbuzz sources or leave them untouched? Advice is > welcome. > > The patch fixes linux x64 fastdebug an

Re: RFR: 8266545: 8261169 broke Harfbuzz build with gcc 7 and 8

2021-05-05 Thread Aleksey Shipilev
On Wed, 5 May 2021 07:54:20 GMT, Thomas Stuefe wrote: > Harfbuzz upgrade broke Linux x64 build on older gccs. For details see JBS > issue. > > I fixed the issue in the harfbuzz sources, but I am not sure of the policy > here. Do we modify the harfbuzz sources or leave them untouched? Advice is

Re: RFR: 8266545: 8261169 broke Harfbuzz build with gcc 7 and 8

2021-05-05 Thread Thomas Stuefe
On Wed, 5 May 2021 07:54:20 GMT, Thomas Stuefe wrote: > Harfbuzz upgrade broke Linux x64 build on older gccs. For details see JBS > issue. > > I fixed the issue in the harfbuzz sources, but I am not sure of the policy > here. Do we modify the harfbuzz sources or leave them untouched? Advice is

Re: RFR: 8266545: 8261169 broke Harfbuzz build with gcc 7 and 8

2021-05-05 Thread Thomas Stuefe
On Wed, 5 May 2021 07:54:20 GMT, Thomas Stuefe wrote: > Harfbuzz upgrade broke Linux x64 build on older gccs. For details see JBS > issue. > > I fixed the issue in the harfbuzz sources, but I am not sure of the policy > here. Do we modify the harfbuzz sources or leave them untouched? Advice is

RFR: 8265909 : build.tools.dtdbuilder.DTDBuilder.java failed detecting missing path of dtd_home

2021-05-05 Thread ScientificWare
This concern [dtdbuilder tools](https://github.com/openjdk/jdk/tree/master/make/jdk/src/classes/build/tools/dtdbuilder). In jshell, try `System.getProperty("html32") + ""` you'll get a `String`. So, in `DTDBuilder.java` when none `dtd_home` property is set, the `dtd_home` string value is not `n

Re: RFR: 8265909 : build.tools.dtdbuilder.DTDBuilder.java failed detecting missing path of dtd_home

2021-05-05 Thread ScientificWare
On Thu, 22 Apr 2021 13:47:03 GMT, ScientificWare wrote: > This concern [dtdbuilder > tools](https://github.com/openjdk/jdk/tree/master/make/jdk/src/classes/build/tools/dtdbuilder). > > In jshell, try `System.getProperty("html32") + ""` you'll get a `String`. > > So, in `DTDBuilder.java` when

Re: RFR: 8266545: 8261169 broke Harfbuzz build with gcc 7 and 8

2021-05-05 Thread Matthias Baesken
On Wed, 5 May 2021 07:54:20 GMT, Thomas Stuefe wrote: > Harfbuzz upgrade broke Linux x64 build on older gccs. For details see JBS > issue. > > I fixed the issue in the harfbuzz sources, but I am not sure of the policy > here. Do we modify the harfbuzz sources or leave them untouched? Advice is

Re: RFR: 8261169: Upgrade HarfBuzz to the latest 2.8.0

2021-05-05 Thread Thomas Stuefe
On Fri, 30 Apr 2021 20:07:53 GMT, Phil Race wrote: > Upgrade to harfbuzz 2.8 https://github.com/openjdk/jdk/pull/3873 - PR: https://git.openjdk.java.net/jdk/pull/3826

Re: RFR: 8261169: Upgrade HarfBuzz to the latest 2.8.0

2021-05-05 Thread Thomas Stuefe
On Fri, 30 Apr 2021 20:07:53 GMT, Phil Race wrote: > Upgrade to harfbuzz 2.8 Same here. In my case it breaks with gcc 7.5.0, which I believe is still supported. I opened https://bugs.openjdk.java.net/browse/JDK-8266545. - PR: https://git.openjdk.java.net/jdk/pull/3826