Re: RFR: 8266459: Implement JEP 411: Deprecate the Security Manager for Removal [v5]

2021-05-27 Thread Weijun Wang
On Thu, 27 May 2021 20:16:25 GMT, Weijun Wang wrote: >> Please review this implementation of [JEP >> 411](https://openjdk.java.net/jeps/411). >> >> The code change is divided into 3 commits. Please review them one by one. >> >> 1. >> https://github.com/openjdk/jdk/commit/576161d15423f58281e38

Re: RFR: 8266459: Implement JEP 411: Deprecate the Security Manager for Removal [v5]

2021-05-27 Thread Weijun Wang
> Please review this implementation of [JEP > 411](https://openjdk.java.net/jeps/411). > > The code change is divided into 3 commits. Please review them one by one. > > 1. > https://github.com/openjdk/jdk/commit/576161d15423f58281e384174d28c9f9be7941a1 > The essential change for this JEP, incl

Re: RFR: 8262891: Compiler implementation for Pattern Matching for switch (Preview) [v5]

2021-05-27 Thread Evgeny Mandrikov
On Thu, 27 May 2021 18:19:38 GMT, Rémi Forax wrote: > in your example, there is no guard so no backward goto @forax btw this example is not about switch pattern matching - it is about already existing string switch, where indy not involed 😉 void example(java.lang.String); descriptor:

Re: RFR: 8262891: Compiler implementation for Pattern Matching for switch (Preview) [v5]

2021-05-27 Thread Rémi Forax
On Wed, 26 May 2021 17:52:36 GMT, Jan Lahoda wrote: >> This is a preview of a patch implementing JEP 406: Pattern Matching for >> switch (Preview): >> https://bugs.openjdk.java.net/browse/JDK-8213076 >> >> The current draft of the specification is here: >> http://cr.openjdk.java.net/~gbierman/j

Re: RFR: 8267706: bin/idea.sh tries to use cygpath on WSL [v2]

2021-05-27 Thread Erik Joelsson
On Thu, 27 May 2021 17:45:40 GMT, Nikita Gubarkov wrote: >> 8267706: bin/idea.sh tries to use cygpath on WSL > > Nikita Gubarkov has updated the pull request incrementally with one > additional commit since the last revision: > > 8267706: Break long line in make/ide/idea/jdk/idea.gmk Marked

Re: RFR: 8262891: Compiler implementation for Pattern Matching for switch (Preview) [v5]

2021-05-27 Thread Evgeny Mandrikov
On Wed, 26 May 2021 17:52:36 GMT, Jan Lahoda wrote: >> This is a preview of a patch implementing JEP 406: Pattern Matching for >> switch (Preview): >> https://bugs.openjdk.java.net/browse/JDK-8213076 >> >> The current draft of the specification is here: >> http://cr.openjdk.java.net/~gbierman/j

Re: RFR: 8267706: bin/idea.sh tries to use cygpath on WSL [v2]

2021-05-27 Thread Nikita Gubarkov
> 8267706: bin/idea.sh tries to use cygpath on WSL Nikita Gubarkov has updated the pull request incrementally with one additional commit since the last revision: 8267706: Break long line in make/ide/idea/jdk/idea.gmk - Changes: - all: https://git.openjdk.java.net/jdk/pull/4190/

Re: RFR: 8266459: Implement JEP 411: Deprecate the Security Manager for Removal [v4]

2021-05-27 Thread Phil Race
On Mon, 24 May 2021 13:53:34 GMT, Weijun Wang wrote: >> Please review this implementation of [JEP >> 411](https://openjdk.java.net/jeps/411). >> >> The code change is divided into 3 commits. Please review them one by one. >> >> 1. >> https://github.com/openjdk/jdk/commit/576161d15423f58281e38

Re: RFR: 8267706: bin/idea.sh tries to use cygpath on WSL

2021-05-27 Thread Erik Joelsson
On Tue, 25 May 2021 16:37:30 GMT, Nikita Gubarkov wrote: > 8267706: bin/idea.sh tries to use cygpath on WSL I think this looks ok, though I'm not very familiar with the details of this code. I also very rarely use the idea projects. It would be good if some frequent users could take this for

Re: RFR: 8267312: Resolve should use generated diagnostic factories

2021-05-27 Thread Vicente Romero
On Wed, 26 May 2021 14:09:39 GMT, Maurizio Cimadamore wrote: > > Some general comments about the generated code. I wonder if it would make > > sense to change the implementation of the toType() method which will fold > > common cases in the switch expression into a default case or generate a

Integrated: 8267123: Remove RMI Activation

2021-05-27 Thread Stuart Marks
On Tue, 25 May 2021 18:04:45 GMT, Stuart Marks wrote: > This is the implementation of [JEP 407](https://openjdk.java.net/jeps/407). > > This is a fairly straightforward removal of this component. > - Activation implementation classes removed > - Activation tests removed > - adjustments to var

RFR: 8267706: bin/idea.sh tries to use cygpath on WSL

2021-05-27 Thread Nikita Gubarkov
8267706: bin/idea.sh tries to use cygpath on WSL - Commit messages: - 8267706: Added shell run configurations instead of Ant for IDEA project - 8267706: Improved IDEA project setup - 8267706: Fix bin/idea.sh cygpath usage on WSL Changes: https://git.openjdk.java.net/jdk/pull/4190/

Re: RFR: JDK-8263468: New page for "recent" new API

2021-05-27 Thread Erik Joelsson
On Thu, 27 May 2021 13:28:33 GMT, Erik Joelsson wrote: >> I don't have a solution for this problem. AFAIK there are a few things that >> have to be "bumped" manually between releases, and this would be yet >> another. Obviously not a great solution. > > Yes, there are a few things, but in the b

Re: RFR: JDK-8263468: New page for "recent" new API

2021-05-27 Thread Erik Joelsson
On Thu, 27 May 2021 13:05:27 GMT, Hannes Wallnöfer wrote: >> make/Docs.gmk line 336: >> >>> 334: >>> 335: # Add summary pages for new/deprecated APIs in recent releases >>> 336: $1_OPTIONS += --since 12,13,14,15,16,17 --since-label "New API since >>> JDK 11" >> >> How do you expect this t

Re: RFR: JDK-8263468: New page for "recent" new API

2021-05-27 Thread Hannes Wallnöfer
On Thu, 27 May 2021 12:52:34 GMT, Erik Joelsson wrote: >> This adds a new kind of summary list for new API added in specific releases, >> and adds information to the deprecated API list about elements that were >> deprecated in the given releases. >> >> The changes to the code are relatively m

Re: RFR: JDK-8263468: New page for "recent" new API

2021-05-27 Thread Erik Joelsson
On Wed, 26 May 2021 16:02:29 GMT, Hannes Wallnöfer wrote: > This adds a new kind of summary list for new API added in specific releases, > and adds information to the deprecated API list about elements that were > deprecated in the given releases. > > The changes to the code are relatively min

RFR: JDK-8263468: New page for "recent" new API

2021-05-27 Thread Hannes Wallnöfer
This adds a new kind of summary list for new API added in specific releases, and adds information to the deprecated API list about elements that were deprecated in the given releases. The changes to the code are relatively minor thanks to the existing infrastructure for summary list pages, whic

Re: RFR: 8262891: Compiler implementation for Pattern Matching for switch (Preview) [v5]

2021-05-27 Thread Maurizio Cimadamore
On Wed, 26 May 2021 17:52:36 GMT, Jan Lahoda wrote: >> This is a preview of a patch implementing JEP 406: Pattern Matching for >> switch (Preview): >> https://bugs.openjdk.java.net/browse/JDK-8213076 >> >> The current draft of the specification is here: >> http://cr.openjdk.java.net/~gbierman/j