RFR: 8267630: Start of release updates for JDK 18

2021-06-02 Thread Joe Darcy
8267630: Start of release updates for JDK 18 - Commit messages: - Merge branch 'master' into 8267630 - Merge branch 'master' into 8267630 - Merge branch 'master' into 8267630 - Merge branch 'master' into 8267630 - Merge branch 'master' into 8267630 - Merge branch 'master' into

Re: RFR: 8267630: Start of release updates for JDK 18

2021-06-02 Thread Joe Darcy
On Mon, 24 May 2021 22:35:04 GMT, Joe Darcy wrote: > 8267630: Start of release updates for JDK 18 JDK 18 is right around the corner, time for the usual start-of-release changeset for review. Typical structure for these kinds of changes. I'll update the symbol file information of JDK 17 b25

Withdrawn: JDK-8266254: Update to use jtreg 6

2021-06-02 Thread duke
On Wed, 2 Jun 2021 16:13:48 GMT, Jonathan Gibbons wrote: > Please review the change to update to using jtreg 6. > > The primary change is to the jib-profiles.js file, which specifies the > version of jtreg to use, for those systems that rely on this file. In > addition, the `requiredVersion`

Re: RFR: JDK-8266254: Update to use jtreg 6 [v2]

2021-06-02 Thread Naoto Sato
On Wed, 2 Jun 2021 20:15:55 GMT, Jonathan Gibbons wrote: >> Please review the change to update to using jtreg 6. >> >> The primary change is to the jib-profiles.js file, which specifies the >> version of jtreg to use, for those systems that rely on this file. In >> addition, the

Re: RFR: JDK-8266254: Update to use jtreg 6 [v2]

2021-06-02 Thread Jonathan Gibbons
> Please review the change to update to using jtreg 6. > > The primary change is to the jib-profiles.js file, which specifies the > version of jtreg to use, for those systems that rely on this file. In > addition, the `requiredVersion` has been updated in the various `TEST.ROOT` > files. > >

Re: RFR: JDK-8266254: Update to use jtreg 6

2021-06-02 Thread Chris Hegarty
On Wed, 2 Jun 2021 16:13:48 GMT, Jonathan Gibbons wrote: > Please review the change to update to using jtreg 6. > > The primary change is to the jib-profiles.js file, which specifies the > version of jtreg to use, for those systems that rely on this file. In > addition, the `requiredVersion`

Re: RFR: JDK-8266254: Update to use jtreg 6

2021-06-02 Thread Iris Clark
On Wed, 2 Jun 2021 16:13:48 GMT, Jonathan Gibbons wrote: > Please review the change to update to using jtreg 6. > > The primary change is to the jib-profiles.js file, which specifies the > version of jtreg to use, for those systems that rely on this file. In > addition, the `requiredVersion`

Re: RFR: 8267706: bin/idea.sh tries to use cygpath on WSL [v2]

2021-06-02 Thread Jonathan Gibbons
On Thu, 27 May 2021 17:45:40 GMT, Nikita Gubarkov wrote: >> 8267706: bin/idea.sh tries to use cygpath on WSL > > Nikita Gubarkov has updated the pull request incrementally with one > additional commit since the last revision: > > 8267706: Break long line in make/ide/idea/jdk/idea.gmk I

Re: RFR: 8265783: Create a separate library for x86 Intel SVML assembly intrinsics [v16]

2021-06-02 Thread Sandhya Viswanathan
> This PR contains Short Vector Math Library support related changes for > [JEP-414 Vector API (Second Incubator)](https://openjdk.java.net/jeps/414), > in preparation for when targeted. > > Intel Short Vector Math Library (SVML) based intrinsics in native x86 > assembly provide optimized

Re: RFR: JDK-8266254: Update to use jtreg 6

2021-06-02 Thread Alan Bateman
On Wed, 2 Jun 2021 16:13:48 GMT, Jonathan Gibbons wrote: > Please review the change to update to using jtreg 6. > > The primary change is to the jib-profiles.js file, which specifies the > version of jtreg to use, for those systems that rely on this file. In > addition, the `requiredVersion`

Re: RFR: JDK-8266254: Update to use jtreg 6

2021-06-02 Thread Naoto Sato
On Wed, 2 Jun 2021 16:13:48 GMT, Jonathan Gibbons wrote: > Please review the change to update to using jtreg 6. > > The primary change is to the jib-profiles.js file, which specifies the > version of jtreg to use, for those systems that rely on this file. In > addition, the `requiredVersion`

Re: RFR: JDK-8266254: Update to use jtreg 6

2021-06-02 Thread Mandy Chung
On Wed, 2 Jun 2021 16:13:48 GMT, Jonathan Gibbons wrote: > Please review the change to update to using jtreg 6. > > The primary change is to the jib-profiles.js file, which specifies the > version of jtreg to use, for those systems that rely on this file. In > addition, the `requiredVersion`

Re: RFR: JDK-8266254: Update to use jtreg 6

2021-06-02 Thread Erik Joelsson
On Wed, 2 Jun 2021 16:13:48 GMT, Jonathan Gibbons wrote: > Please review the change to update to using jtreg 6. > > The primary change is to the jib-profiles.js file, which specifies the > version of jtreg to use, for those systems that rely on this file. In > addition, the `requiredVersion`

Re: RFR: JDK-8266254: Update to use jtreg 6

2021-06-02 Thread Lance Andersen
On Wed, 2 Jun 2021 16:13:48 GMT, Jonathan Gibbons wrote: > Please review the change to update to using jtreg 6. > > The primary change is to the jib-profiles.js file, which specifies the > version of jtreg to use, for those systems that rely on this file. In > addition, the `requiredVersion`

RFR: JDK-8266254: Update to use jtreg 6

2021-06-02 Thread Jonathan Gibbons
Please review the change to update to using jtreg 6. The primary change is to the jib-profiles.js file, which specifies the version of jtreg to use, for those systems that rely on this file. In addition, the `requiredVersion` has been updated in the various `TEST.ROOT` files. All the tests

Re: RFR: 8267706: bin/idea.sh tries to use cygpath on WSL [v2]

2021-06-02 Thread Erik Joelsson
On Thu, 27 May 2021 17:45:40 GMT, Nikita Gubarkov wrote: >> 8267706: bin/idea.sh tries to use cygpath on WSL > > Nikita Gubarkov has updated the pull request incrementally with one > additional commit since the last revision: > > 8267706: Break long line in make/ide/idea/jdk/idea.gmk We

Re: RFR: 8267706: bin/idea.sh tries to use cygpath on WSL [v2]

2021-06-02 Thread Nikita Gubarkov
On Wed, 2 Jun 2021 13:24:00 GMT, Erik Joelsson wrote: >> Nikita Gubarkov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8267706: Break long line in make/ide/idea/jdk/idea.gmk > > We do not require brew to install packages on mac, the

Re: RFR: 8267706: bin/idea.sh tries to use cygpath on WSL [v2]

2021-06-02 Thread Erik Joelsson
On Thu, 27 May 2021 17:45:40 GMT, Nikita Gubarkov wrote: >> 8267706: bin/idea.sh tries to use cygpath on WSL > > Nikita Gubarkov has updated the pull request incrementally with one > additional commit since the last revision: > > 8267706: Break long line in make/ide/idea/jdk/idea.gmk We do

Integrated: 8266459: Implement JEP 411: Deprecate the Security Manager for Removal

2021-06-02 Thread Weijun Wang
On Mon, 17 May 2021 18:23:41 GMT, Weijun Wang wrote: > Please review this implementation of [JEP > 411](https://openjdk.java.net/jeps/411). > > The code change is divided into 3 commits. Please review them one by one. > > 1. >

Re: RFR: 8266459: Implement JEP 411: Deprecate the Security Manager for Removal [v9]

2021-06-02 Thread Weijun Wang
> Please review this implementation of [JEP > 411](https://openjdk.java.net/jeps/411). > > The code change is divided into 3 commits. Please review them one by one. > > 1. > https://github.com/openjdk/jdk/commit/576161d15423f58281e384174d28c9f9be7941a1 > The essential change for this JEP,

Re: RFR: 8265440: IGV: make node selection more visible

2021-06-02 Thread Koichi Sakata
On Wed, 2 Jun 2021 06:22:44 GMT, Koichi Sakata wrote: > This pull request makes node selection more visible. > > At present when selecting node, node name is bolder. In addition to that, > thickness of the border is bolder after applying this code. > > I tested manually. Here are the images

Re: RFR: 8265440: IGV: make node selection more visible

2021-06-02 Thread Nils Eliasson
On Wed, 2 Jun 2021 06:22:44 GMT, Koichi Sakata wrote: > This pull request makes node selection more visible. > > At present when selecting node, node name is bolder. In addition to that, > thickness of the border is bolder after applying this code. > > I tested manually. Here are the images

Re: RFR: 8267706: bin/idea.sh tries to use cygpath on WSL [v2]

2021-06-02 Thread Nikita Gubarkov
On Wed, 2 Jun 2021 06:30:11 GMT, Jonathan Gibbons wrote: >> Nikita Gubarkov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8267706: Break long line in make/ide/idea/jdk/idea.gmk > > The fix was supposed to be just about disentangling

Re: RFR: 8265440: IGV: make node selection more visible

2021-06-02 Thread Christian Hagedorn
On Wed, 2 Jun 2021 06:22:44 GMT, Koichi Sakata wrote: > This pull request makes node selection more visible. > > At present when selecting node, node name is bolder. In addition to that, > thickness of the border is bolder after applying this code. > > I tested manually. Here are the images

Re: RFR: 8267706: bin/idea.sh tries to use cygpath on WSL [v2]

2021-06-02 Thread Jonathan Gibbons
On Thu, 27 May 2021 17:45:40 GMT, Nikita Gubarkov wrote: >> 8267706: bin/idea.sh tries to use cygpath on WSL > > Nikita Gubarkov has updated the pull request incrementally with one > additional commit since the last revision: > > 8267706: Break long line in make/ide/idea/jdk/idea.gmk The

RFR: 8265440: IGV: make node selection more visible

2021-06-02 Thread Koichi Sakata
This pull request makes node selection more visible. At present when selecting node, node name is bolder. In addition to that, thickness of the border is bolder after applying this code. I tested manually. Here are the images that I took before and after applying this patch as follows. ###