Integrated: 8267634: Update --release 17 symbol information for JDK 17 build 26

2021-06-11 Thread Joe Darcy
On Fri, 11 Jun 2021 22:44:03 GMT, Joe Darcy wrote: > Update symbol files in JDK 18 for changes in JDK 17 b26. This pull request has now been integrated. Changeset: a466b49e Author:Joe Darcy URL: https://git.openjdk.java.net/jdk/commit/a466b49e71b0d235294e17faba47ed4fd3fb8f6e Stats:

Re: RFR: 8267634: Update --release 17 symbol information for JDK 17 build 26

2021-06-11 Thread Iris Clark
On Fri, 11 Jun 2021 22:44:03 GMT, Joe Darcy wrote: > Update symbol files in JDK 18 for changes in JDK 17 b26. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/4477

Re: RFR: 8267634: Update --release 17 symbol information for JDK 17 build 26

2021-06-11 Thread Jonathan Gibbons
On Fri, 11 Jun 2021 22:44:03 GMT, Joe Darcy wrote: > Update symbol files in JDK 18 for changes in JDK 17 b26. Marked as reviewed by jjg (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/4477

RFR: 8267634: Update --release 17 symbol information for JDK 17 build 26

2021-06-11 Thread Joe Darcy
Update symbol files in JDK 18 for changes in JDK 17 b26. - Commit messages: - 8267634: Update --release 17 symbol information for JDK 17 build 26 Changes: https://git.openjdk.java.net/jdk/pull/4477/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4477&range=00 Issue: h

Re: [jdk17] RFR: 8266036: class file for sun.misc.Contended not found

2021-06-11 Thread Joe Darcy
On Fri, 11 Jun 2021 13:09:55 GMT, Jan Lahoda wrote: > [this is an improved version of openjdk/jdk PR: > https://github.com/openjdk/jdk/pull/4428 > ] > > The ct.sym may contain classfiles referring to annotations that are not > present in ct.sym (liek JDK's internal annotation sun.misc.Contended

Re: RFR: 8268626: Remove native pre-jdk9 support for jtreg failure handler

2021-06-11 Thread Erik Joelsson
On Fri, 11 Jun 2021 18:44:38 GMT, Leonid Mesnik wrote: > jtreg failure handler uses native lib to implement getPid for preJDK9. > Currently. it is not needed and might be removed. Marked as reviewed by erikj (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/4476

RFR: 8268626: Remove native pre-jdk9 support for jtreg failure handler

2021-06-11 Thread Leonid Mesnik
jtreg failure handler uses native lib to implement getPid for preJDK9. Currently. it is not needed and might be removed. - Commit messages: - native lib support removed. Changes: https://git.openjdk.java.net/jdk/pull/4476/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr

[jdk17] RFR: 8266036: class file for sun.misc.Contended not found

2021-06-11 Thread Jan Lahoda
[this is an improved version of openjdk/jdk PR: https://github.com/openjdk/jdk/pull/4428 ] The ct.sym may contain classfiles referring to annotations that are not present in ct.sym (liek JDK's internal annotation sun.misc.Contended). If javac will try to load them (while discovering annotations

Withdrawn: 8266036: class file for sun.misc.Contended not found

2021-06-11 Thread Jan Lahoda
On Wed, 9 Jun 2021 11:05:37 GMT, Jan Lahoda wrote: > The ct.sym may contain classfiles referring to annotations that are not > present in ct.sym (liek JDK's internal annotation `sun.misc.Contended`). If > javac will try to load them (while discovering annotations for the purpose of > detecting

Re: RFR: 8266036: class file for sun.misc.Contended not found

2021-06-11 Thread Jan Lahoda
On Thu, 10 Jun 2021 21:38:28 GMT, Joe Darcy wrote: > Does jdk.internal.ValueBased also need special handling? See JDK-8258421. @jddarcy, you are right, there needs to be special handling for it. I have created a new PR for JDK 17 here: https://github.com/openjdk/jdk17/pull/27 It should also in

Re: RFR: 8266036: class file for sun.misc.Contended not found

2021-06-11 Thread Jan Lahoda
On Thu, 10 Jun 2021 15:28:16 GMT, Vicente Romero wrote: >> The ct.sym may contain classfiles referring to annotations that are not >> present in ct.sym (liek JDK's internal annotation `sun.misc.Contended`). If >> javac will try to load them (while discovering annotations for the purpose >> of

Re: RFR: 8265909 : build.tools.dtdbuilder.DTDBuilder.java failed detecting missing path of dtd_home [v2]

2021-06-11 Thread ScientificWare
On Wed, 9 Jun 2021 14:13:06 GMT, Erik Joelsson wrote: >> ScientificWare has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Changes to keep home_dtd null check. >> >> As suggested in conversation moving `+ File.separator` is more elegan

Integrated: 8265909 : build.tools.dtdbuilder.DTDBuilder.java failed detecting missing path of dtd_home

2021-06-11 Thread ScientificWare
On Thu, 22 Apr 2021 13:47:03 GMT, ScientificWare wrote: > This concerns [dtdbuilder > tools](https://github.com/openjdk/jdk/tree/master/make/jdk/src/classes/build/tools/dtdbuilder). > > In jshell, try `System.getProperty("html32") + ""` you'll get a `String`. > > So, in `DTDBuilder.java` when

Re: RFR: 8265909 : build.tools.dtdbuilder.DTDBuilder.java failed detecting missing path of dtd_home [v2]

2021-06-11 Thread ScientificWare
On Wed, 9 Jun 2021 14:13:06 GMT, Erik Joelsson wrote: >> ScientificWare has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Changes to keep home_dtd null check. >> >> As suggested in conversation moving `+ File.separator` is more elegan