When the classlist is generated using build.tools.classlist.HelloClasslist, its
contents may be non-deterministic due to Java thread execution order.
We should sort the generated classlist to make the JDK image's contents more
deterministic.
Tested with Mach5 tier1, tier2, builds-tier5
---
On Fri, 27 Aug 2021 14:28:07 GMT, Magnus Ihse Bursie wrote:
> Having the environment variable CLASSPATH set when building can cause
> hard-to-diagnose build errors. We should not silently accept the CLASSPATH
> variable when building. Normally, the classpath should be correctly setup for
> all
On Thu, 22 Jul 2021 16:43:26 GMT, Severin Gehwolf wrote:
> Hi!
>
> Please review this tiny patch which removes the special casing of
> `--with-native-debug-symbols=external` for the static libs build. I don't see
> why this is needed. If no debug symbols are wanted
> `--with-native-debug-symb
Having the environment variable CLASSPATH set when building can cause
hard-to-diagnose build errors. We should not silently accept the CLASSPATH
variable when building. Normally, the classpath should be correctly setup for
all invocations of java during the build. If the user wants to have a
ha
On Fri, 27 Aug 2021 13:15:36 GMT, Jie Fu wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix code review comments
>
> make/devkit/createMacosxDevkit.sh line 105:
>
>> 103:
>> 104: for ex in $EXCLUDE_DIRS; d
On Fri, 27 Aug 2021 10:21:26 GMT, Magnus Ihse Bursie wrote:
> JDK-8272700 was created to fix a bug in a variable assignment in configure.
> While it fixed the bug, it kept the problematic syntax that caused the bug in
> the first place.
>
> We do not use the `FOO+="appended"` syntax for appen
On Fri, 27 Aug 2021 13:22:31 GMT, David Holmes wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix code review comments
>
> I wouldn't have considered the m4 files as "shell scripts" and I'm surprised
> that
> JDK-8272700 was created to fix a bug in a variable assignment in configure.
> While it fixed the bug, it kept the problematic syntax that caused the bug in
> the first place.
>
> We do not use the `FOO+="appended"` syntax for appending to variables in
> shell scripts, since this differs from
On Fri, 27 Aug 2021 13:53:56 GMT, Magnus Ihse Bursie wrote:
>> JDK-8272700 was created to fix a bug in a variable assignment in configure.
>> While it fixed the bug, it kept the problematic syntax that caused the bug
>> in the first place.
>>
>> We do not use the `FOO+="appended"` syntax for
On Fri, 27 Aug 2021 13:14:52 GMT, Magnus Ihse Bursie wrote:
>> JDK-8272700 was created to fix a bug in a variable assignment in configure.
>> While it fixed the bug, it kept the problematic syntax that caused the bug
>> in the first place.
>>
>> We do not use the `FOO+="appended"` syntax for
On Fri, 27 Aug 2021 13:14:52 GMT, Magnus Ihse Bursie wrote:
>> JDK-8272700 was created to fix a bug in a variable assignment in configure.
>> While it fixed the bug, it kept the problematic syntax that caused the bug
>> in the first place.
>>
>> We do not use the `FOO+="appended"` syntax for
On Fri, 27 Aug 2021 12:46:14 GMT, Magnus Ihse Bursie wrote:
> It turned out that JDK-8255785 was incorrectly verified, and headless do
> indeed need X headers. This fix is a revert (anti-delta) of JDK-8255785.
This pull request has now been integrated.
Changeset: 596b0755
Author:Magnus Ihs
> JDK-8272700 was created to fix a bug in a variable assignment in configure.
> While it fixed the bug, it kept the problematic syntax that caused the bug in
> the first place.
>
> We do not use the `FOO+="appended"` syntax for appending to variables in
> shell scripts, since this differs from
On Fri, 27 Aug 2021 10:21:26 GMT, Magnus Ihse Bursie wrote:
> JDK-8272700 was created to fix a bug in a variable assignment in configure.
> While it fixed the bug, it kept the problematic syntax that caused the bug in
> the first place.
>
> We do not use the `FOO+="appended"` syntax for appen
On Fri, 27 Aug 2021 12:46:14 GMT, Magnus Ihse Bursie wrote:
> It turned out that JDK-8255785 was incorrectly verified, and headless do
> indeed need X headers. This fix is a revert (anti-delta) of JDK-8255785.
Looks good! Looks like a trivial reversal.
-
Marked as reviewed by shad
On Fri, 27 Aug 2021 10:21:26 GMT, Magnus Ihse Bursie wrote:
> JDK-8272700 was created to fix a bug in a variable assignment in configure.
> While it fixed the bug, it kept the problematic syntax that caused the bug in
> the first place.
>
> We do not use the `FOO+="appended"` syntax for appen
It turned out that JDK-8255785 was incorrectly verified, and headless do indeed
need X headers. This fix is a revert (anti-delta) of JDK-8255785.
-
Commit messages:
- 8258465: Headless build fails due to missing X11 headers on linux
Changes: https://git.openjdk.java.net/jdk/pull/52
JDK-8272700 was created to fix a bug in a variable assignment in configure.
While it fixed the bug, it kept the problematic syntax that caused the bug in
the first place.
We do not use the `FOO+="appended"` syntax for appending to variables in shell
scripts, since this differs from what you'd
18 matches
Mail list logo
