Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v3]

2021-09-22 Thread Jaikiran Pai
On Wed, 22 Sep 2021 15:20:21 GMT, Julia Boes wrote: > > Thanks for sharing your experience on this, it's appreciated. 0.0.0.0 is > > common default for Apache httpd [1], Ngnix [2], the Python web server [3]. > > This being said, I want to make sure we're taking the right decision here > > so

Re: RFR: 8274083: Update testing docs to mention tiered testing [v2]

2021-09-22 Thread David Holmes
On Wed, 22 Sep 2021 12:28:18 GMT, Aleksey Shipilev wrote: >> Now that OpenJDK has more or less complete `tier{1,2,3,4}` definitions, >> let's mention them in `testing.md`. >> >> Current patch is my braindump, I am open for suggestions :) > > Aleksey Shipilev has updated the pull request

Re: RFR: 8274169: HotSpot Style Guide has stale link to chromium style guide

2021-09-22 Thread David Holmes
On Wed, 22 Sep 2021 20:48:11 GMT, Liam Miller-Cushon wrote: > Update links to the chromium style guide in the HotSpot Style Guide. Update looks good and trivial. Aside: no idea why changes to these files mapped to build-dev ?? Thanks, David - Marked as reviewed by dholmes

RFR: 8274169: HotSpot Style Guide has stale link to chromium style guide

2021-09-22 Thread Liam Miller-Cushon
Update links to the chromium style guide in the HotSpot Style Guide. - Commit messages: - 8274169: HotSpot Style Guide has stale link to chromium style guide Changes: https://git.openjdk.java.net/jdk/pull/5641/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=5641=00

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v6]

2021-09-22 Thread Daniel Fuchs
On Wed, 22 Sep 2021 15:26:33 GMT, Julia Boes wrote: >> This change implements a simple web server that can be run on the >> command-line with `java -m jdk.httpserver`. >> >> This is facilitated by adding an entry point for the `jdk.httpserver` >> module, an implementation class whose main

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v3]

2021-09-22 Thread Julia Boes
On Fri, 17 Sep 2021 14:11:38 GMT, Julia Boes wrote: > Thanks for sharing your experience on this, it's appreciated. 0.0.0.0 is > common default for Apache httpd [1], Ngnix [2], the Python web server [3]. > This being said, I want to make sure we're taking the right decision here so > let me

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v6]

2021-09-22 Thread Julia Boes
> This change implements a simple web server that can be run on the > command-line with `java -m jdk.httpserver`. > > This is facilitated by adding an entry point for the `jdk.httpserver` module, > an implementation class whose main method is run when the above command is > executed. This is

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v5]

2021-09-22 Thread Julia Boes
On Tue, 21 Sep 2021 17:16:08 GMT, Michael McMahon wrote: >> Julia Boes has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 16 commits: >> >> - Merge branch 'master' into simpleserver >> - Merge remote-tracking branch

Re: RFR: 8274083: Update testing docs to mention tiered testing [v2]

2021-09-22 Thread Aleksey Shipilev
> Now that OpenJDK has more or less complete `tier{1,2,3,4}` definitions, let's > mention them in `testing.md`. > > Current patch is my braindump, I am open for suggestions :) Aleksey Shipilev has updated the pull request incrementally with two additional commits since the last revision: -

Re: RFR: 8274083: Update testing docs to mention tiered testing [v2]

2021-09-22 Thread Aleksey Shipilev
On Wed, 22 Sep 2021 02:05:35 GMT, David Holmes wrote: >> I'll take another stab at it tomorrow. >> >> The whole tiered testing thing encapsulates that some tests are more >> important to run (at least, first or regularly) than others. So we need to >> somehow capture that. Discussing what

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v5]

2021-09-22 Thread Julia Boes
On Tue, 21 Sep 2021 16:04:21 GMT, Daniel Fuchs wrote: >> Julia Boes has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 16 commits: >> >> - Merge branch 'master' into simpleserver >> - Merge remote-tracking branch

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v5]

2021-09-22 Thread Julia Boes
On Tue, 21 Sep 2021 15:23:33 GMT, Michael McMahon wrote: >> Julia Boes has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 16 commits: >> >> - Merge branch 'master' into simpleserver >> - Merge remote-tracking branch

Re: RFR: 8274048 IGV: Replace usages of Collections.sort with List.sort call

2021-09-22 Thread Christian Hagedorn
On Mon, 23 Aug 2021 20:52:22 GMT, Andrey Turbanov wrote: > Collections.sort is just a wrapper, so it is better to use an instance method > directly. Looks good and trivial. - Marked as reviewed by chagedorn (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/5228

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v5]

2021-09-22 Thread Chris Hegarty
On Tue, 21 Sep 2021 14:09:54 GMT, Julia Boes wrote: >> This change implements a simple web server that can be run on the >> command-line with `java -m jdk.httpserver`. >> >> This is facilitated by adding an entry point for the `jdk.httpserver` >> module, an implementation class whose main