Integrated: 8274048 IGV: Replace usages of Collections.sort with List.sort call

2021-09-23 Thread Andrey Turbanov
On Mon, 23 Aug 2021 20:52:22 GMT, Andrey Turbanov wrote: > Collections.sort is just a wrapper, so it is better to use an instance method > directly. This pull request has now been integrated. Changeset: 8b833bbe Author:Andrey Turbanov Committer: Christian Hagedorn URL: https://gi

Re: RFR: 8274083: Update testing docs to mention tiered testing [v2]

2021-09-23 Thread Aleksey Shipilev
On Thu, 23 Sep 2021 05:44:57 GMT, David Holmes wrote: >> Aleksey Shipilev has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Revert accidental edit >> - More discussion > > doc/testing.html line 73: > >> 71: Common Test Groups >> 72: In

Re: RFR: 8274083: Update testing docs to mention tiered testing [v3]

2021-09-23 Thread Aleksey Shipilev
> Now that OpenJDK has more or less complete `tier{1,2,3,4}` definitions, let's > mention them in `testing.md`. > > Current patch is my braindump, I am open for suggestions :) Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision: Mor

Re: RFR: 8274083: Update testing docs to mention tiered testing [v3]

2021-09-23 Thread Jie Fu
On Thu, 23 Sep 2021 09:19:42 GMT, Aleksey Shipilev wrote: >> Now that OpenJDK has more or less complete `tier{1,2,3,4}` definitions, >> let's mention them in `testing.md`. >> >> Current patch is my braindump, I am open for suggestions :) > > Aleksey Shipilev has updated the pull request increm

Re: RFR: 8274083: Update testing docs to mention tiered testing [v3]

2021-09-23 Thread Aleksey Shipilev
On Thu, 23 Sep 2021 09:28:29 GMT, Jie Fu wrote: >> Aleksey Shipilev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> More fixes > > doc/testing.md line 107: > >> 105: (`JTREG_KEYWORDS=\!headful`), or both. >> 106: >> 107: - `tier4`: Thi

Re: RFR: 8274083: Update testing docs to mention tiered testing [v3]

2021-09-23 Thread Jie Fu
On Thu, 23 Sep 2021 09:19:42 GMT, Aleksey Shipilev wrote: >> Now that OpenJDK has more or less complete `tier{1,2,3,4}` definitions, >> let's mention them in `testing.md`. >> >> Current patch is my braindump, I am open for suggestions :) > > Aleksey Shipilev has updated the pull request increm

Re: RFR: 8274083: Update testing docs to mention tiered testing [v3]

2021-09-23 Thread Jie Fu
On Thu, 23 Sep 2021 09:37:49 GMT, Aleksey Shipilev wrote: > No, I think "every other X" puts "X" in singular form: > https://www.merriam-webster.com/dictionary/every%20other. Okay, I agree. Thanks. - PR: https://git.openjdk.java.net/jdk/pull/5615

Re: RFR: 8255790: GTKL&F: Java 16 crashes on initialising GTKL&F on Manjaro Linux [v3]

2021-09-23 Thread Magnus Ihse Bursie
On Wed, 15 Sep 2021 19:43:45 GMT, Andrew John Hughes wrote: >> Phil Race has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8255790: GTKL&F: Java 16 crashes on initialising GTKL&F on Manjaro Linux > > You mention that "too many systems have

Re: RFR: 8274083: Update testing docs to mention tiered testing [v3]

2021-09-23 Thread Thomas Stuefe
On Thu, 23 Sep 2021 09:19:42 GMT, Aleksey Shipilev wrote: >> Now that OpenJDK has more or less complete `tier{1,2,3,4}` definitions, >> let's mention them in `testing.md`. >> >> Current patch is my braindump, I am open for suggestions :) > > Aleksey Shipilev has updated the pull request increm

Re: RFR: 8274169: HotSpot Style Guide has stale link to chromium style guide

2021-09-23 Thread Magnus Ihse Bursie
On Thu, 23 Sep 2021 02:56:05 GMT, David Holmes wrote: >> Update links to the chromium style guide in the HotSpot Style Guide. > > Update looks good and trivial. > > Aside: no idea why changes to these files mapped to build-dev ?? > > Thanks, > David @dholmes-ora The build team has traditionall

Re: RFR: 8274169: HotSpot Style Guide has stale link to chromium style guide

2021-09-23 Thread Magnus Ihse Bursie
On Wed, 22 Sep 2021 20:48:11 GMT, Liam Miller-Cushon wrote: > Update links to the chromium style guide in the HotSpot Style Guide. Marked as reviewed by ihse (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5641

Re: RFR: 8274083: Update testing docs to mention tiered testing [v3]

2021-09-23 Thread Magnus Ihse Bursie
On Thu, 23 Sep 2021 09:19:42 GMT, Aleksey Shipilev wrote: >> Now that OpenJDK has more or less complete `tier{1,2,3,4}` definitions, >> let's mention them in `testing.md`. >> >> Current patch is my braindump, I am open for suggestions :) > > Aleksey Shipilev has updated the pull request increm

Re: RFR: 8274083: Update testing docs to mention tiered testing [v4]

2021-09-23 Thread Aleksey Shipilev
> Now that OpenJDK has more or less complete `tier{1,2,3,4}` definitions, let's > mention them in `testing.md`. > > Current patch is my braindump, I am open for suggestions :) Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision: Dro

Re: RFR: 8274083: Update testing docs to mention tiered testing [v3]

2021-09-23 Thread Aleksey Shipilev
On Thu, 23 Sep 2021 10:56:02 GMT, Magnus Ihse Bursie wrote: >> Aleksey Shipilev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> More fixes > > doc/testing.md line 95: > >> 93: the tests in `tier1` are carefully selected and optimized to

Re: RFR: 8274083: Update testing docs to mention tiered testing [v4]

2021-09-23 Thread Magnus Ihse Bursie
On Thu, 23 Sep 2021 11:30:20 GMT, Aleksey Shipilev wrote: >> Now that OpenJDK has more or less complete `tier{1,2,3,4}` definitions, >> let's mention them in `testing.md`. >> >> Current patch is my braindump, I am open for suggestions :) > > Aleksey Shipilev has updated the pull request increm

Re: RFR: 8274083: Update testing docs to mention tiered testing [v4]

2021-09-23 Thread Alan Bateman
On Thu, 23 Sep 2021 11:30:20 GMT, Aleksey Shipilev wrote: >> Now that OpenJDK has more or less complete `tier{1,2,3,4}` definitions, >> let's mention them in `testing.md`. >> >> Current patch is my braindump, I am open for suggestions :) > > Aleksey Shipilev has updated the pull request increm

Re: RFR: 8274083: Update testing docs to mention tiered testing [v4]

2021-09-23 Thread Aleksey Shipilev
On Thu, 23 Sep 2021 11:54:06 GMT, Alan Bateman wrote: >> Aleksey Shipilev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Drop GH link > > doc/testing.html line 72: > >> 70: The test specifications given in TEST is parsed into >> fully

Re: RFR: 8274083: Update testing docs to mention tiered testing [v5]

2021-09-23 Thread Aleksey Shipilev
> Now that OpenJDK has more or less complete `tier{1,2,3,4}` definitions, let's > mention them in `testing.md`. > > Current patch is my braindump, I am open for suggestions :) Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision: Mor

Re: RFR: 8274083: Update testing docs to mention tiered testing [v4]

2021-09-23 Thread Aleksey Shipilev
On Thu, 23 Sep 2021 11:58:02 GMT, Alan Bateman wrote: >> Aleksey Shipilev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Drop GH link > > doc/testing.html line 79: > >> 77: >> 78: tier1: This is the lowest test tier. Multiple >> deve

Re: RFR: 8274169: HotSpot Style Guide has stale link to chromium style guide

2021-09-23 Thread David Holmes
On 23/09/2021 8:53 pm, Magnus Ihse Bursie wrote: On Thu, 23 Sep 2021 02:56:05 GMT, David Holmes wrote: Update links to the chromium style guide in the HotSpot Style Guide. Update looks good and trivial. Aside: no idea why changes to these files mapped to build-dev ?? Thanks, David @dholm

Re: RFR: 8274083: Update testing docs to mention tiered testing [v3]

2021-09-23 Thread David Holmes
On 23/09/2021 8:33 pm, Thomas Stuefe wrote: On Thu, 23 Sep 2021 09:19:42 GMT, Aleksey Shipilev wrote: Now that OpenJDK has more or less complete `tier{1,2,3,4}` definitions, let's mention them in `testing.md`. Current patch is my braindump, I am open for suggestions :) Aleksey Shipilev has

Integrated: 8274169: HotSpot Style Guide has stale link to chromium style guide

2021-09-23 Thread Liam Miller-Cushon
On Wed, 22 Sep 2021 20:48:11 GMT, Liam Miller-Cushon wrote: > Update links to the chromium style guide in the HotSpot Style Guide. This pull request has now been integrated. Changeset: 1b7f4b7d Author:Liam Miller-Cushon URL: https://git.openjdk.java.net/jdk/commit/1b7f4b7dd8a6070d29

Re: RFR: 8274169: HotSpot Style Guide has stale link to chromium style guide

2021-09-23 Thread Magnus Ihse Bursie
On 2021-09-23 15:38, David Holmes wrote: Okay but I think we need to change that for the Hotspot Style Guide. :) Sure. Open a Skara bug and specify which hotspot list should be the recipient and I can fix it. /Magnus

RFR: 8267636: Bump minimum boot jdk to JDK 17

2021-09-23 Thread Mikael Vidstedt
With the JDK 17 GA out it's time to bump the minimum boot JDK version for mainline/JDK 18. Testing: tier1-5, GHA builds - Commit messages: - 8267636: Bump minimum boot jdk to JDK 17 Changes: https://git.openjdk.java.net/jdk/pull/5639/files Webrev: https://webrevs.openjdk.java.net

Re: RFR: 8267636: Bump minimum boot jdk to JDK 17

2021-09-23 Thread Joe Darcy
On Wed, 22 Sep 2021 20:03:55 GMT, Mikael Vidstedt wrote: > With the JDK 17 GA out it's time to bump the minimum boot JDK version for > mainline/JDK 18. > > Testing: tier1-5, GHA builds Marked as reviewed by darcy (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5639

Re: RFR: 8267636: Bump minimum boot jdk to JDK 17

2021-09-23 Thread Erik Joelsson
On Wed, 22 Sep 2021 20:03:55 GMT, Mikael Vidstedt wrote: > With the JDK 17 GA out it's time to bump the minimum boot JDK version for > mainline/JDK 18. > > Testing: tier1-5, GHA builds Marked as reviewed by erikj (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5639

Re: RFR: 8267636: Bump minimum boot jdk to JDK 17

2021-09-23 Thread Iris Clark
On Wed, 22 Sep 2021 20:03:55 GMT, Mikael Vidstedt wrote: > With the JDK 17 GA out it's time to bump the minimum boot JDK version for > mainline/JDK 18. > > Testing: tier1-5, GHA builds Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5639

Re: RFR: 8274083: Update testing docs to mention tiered testing [v5]

2021-09-23 Thread Mikhailo Seledtsov
On Thu, 23 Sep 2021 12:53:23 GMT, Aleksey Shipilev wrote: >> Now that OpenJDK has more or less complete `tier{1,2,3,4}` definitions, >> let's mention them in `testing.md`. >> >> Current patch is my braindump, I am open for suggestions :) > > Aleksey Shipilev has updated the pull request increm

Re: RFR: JDK-8274170: Add hooks for custom makefiles to augment jtreg test execution

2021-09-23 Thread Mikhailo Seledtsov
On Thu, 23 Sep 2021 22:02:07 GMT, Mikhailo Seledtsov wrote: > Please review this small change that adds hook for custom makefiles to > augment parameters for jtreg test execution. Testing: - tested with custom make file to make sure the feature works - ran a variety of test framework comb

RFR: JDK-8274170: Add hooks for custom makefiles to augment jtreg test execution

2021-09-23 Thread Mikhailo Seledtsov
Please review this small change that adds hook for custom makefiles to augment parameters for jtreg test execution. - Commit messages: - Initial change Changes: https://git.openjdk.java.net/jdk/pull/5666/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5666&range=00 I

Re: RFR: 8274083: Update testing docs to mention tiered testing [v5]

2021-09-23 Thread David Holmes
On Thu, 23 Sep 2021 12:53:23 GMT, Aleksey Shipilev wrote: >> Now that OpenJDK has more or less complete `tier{1,2,3,4}` definitions, >> let's mention them in `testing.md`. >> >> Current patch is my braindump, I am open for suggestions :) > > Aleksey Shipilev has updated the pull request increm

Re: RFR: 8274083: Update testing docs to mention tiered testing [v5]

2021-09-23 Thread Jie Fu
On Thu, 23 Sep 2021 12:53:23 GMT, Aleksey Shipilev wrote: >> Now that OpenJDK has more or less complete `tier{1,2,3,4}` definitions, >> let's mention them in `testing.md`. >> >> Current patch is my braindump, I am open for suggestions :) > > Aleksey Shipilev has updated the pull request increm

Re: RFR: 8274083: Update testing docs to mention tiered testing [v5]

2021-09-23 Thread Alan Bateman
On Thu, 23 Sep 2021 12:53:23 GMT, Aleksey Shipilev wrote: >> Now that OpenJDK has more or less complete `tier{1,2,3,4}` definitions, >> let's mention them in `testing.md`. >> >> Current patch is my braindump, I am open for suggestions :) > > Aleksey Shipilev has updated the pull request increm

Re: RFR: 8274083: Update testing docs to mention tiered testing [v6]

2021-09-23 Thread Aleksey Shipilev
> Now that OpenJDK has more or less complete `tier{1,2,3,4}` definitions, let's > mention them in `testing.md`. > > Current patch is my braindump, I am open for suggestions :) Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision: Ano

Re: RFR: 8274083: Update testing docs to mention tiered testing [v5]

2021-09-23 Thread Aleksey Shipilev
On Fri, 24 Sep 2021 05:58:09 GMT, Alan Bateman wrote: >> Aleksey Shipilev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> More fixes > > doc/testing.html line 80: > >> 78: >> 79: tier1: This is the lowest test tier. Multiple >> develo

Re: RFR: 8274083: Update testing docs to mention tiered testing [v6]

2021-09-23 Thread Alan Bateman
On Fri, 24 Sep 2021 06:12:20 GMT, Aleksey Shipilev wrote: >> Now that OpenJDK has more or less complete `tier{1,2,3,4}` definitions, >> let's mention them in `testing.md`. >> >> Current patch is my braindump, I am open for suggestions :) > > Aleksey Shipilev has updated the pull request increm