Re: RFR: JDK-8274311: Make build.tools.jigsaw.GenGraphs more configurable

2021-09-24 Thread Alan Bateman
On Fri, 24 Sep 2021 23:07:33 GMT, Mandy Chung wrote: > GenGraphs tool generates the module graph. It currently supports the > configuration via javadoc-graphs.properties. However, > `make/jdk/src/classes/build/tools/jigsaw/javadoc-graphs.properties` only > documents two properties. It should b

RFR: JDK-8274311: Make build.tools.jigsaw.GenGraphs more configurable

2021-09-24 Thread Mandy Chung
GenGraphs tool generates the module graph. It currently supports the configuration via javadoc-graphs.properties. However, `make/jdk/src/classes/build/tools/jigsaw/javadoc-graphs.properties` only documents two properties. It should be updated to cover all configurable properties. There are a c

Integrated: 8274273: Update testing docs for MacOS with Non-US locale

2021-09-24 Thread Jie Fu
On Fri, 24 Sep 2021 09:50:19 GMT, Jie Fu wrote: > Hi all, > > I'd like to update the testing docs for MacOS with Non-US locale. > > Our experiments show that the solution mentioned for Windows with Non-US > locale also works for MacOS. > So it would be helpful to mention MacOS explicitly. > >

Re: RFR: 8274273: Update testing docs for MacOS with Non-US locale [v2]

2021-09-24 Thread Jie Fu
On Fri, 24 Sep 2021 13:36:51 GMT, Jie Fu wrote: >> Hi all, >> >> I'd like to update the testing docs for MacOS with Non-US locale. >> >> Our experiments show that the solution mentioned for Windows with Non-US >> locale also works for MacOS. >> So it would be helpful to mention MacOS explicitl

Re: RFR: 8274273: Update testing docs for MacOS with Non-US locale [v2]

2021-09-24 Thread Sergey Bylokhov
On Fri, 24 Sep 2021 13:36:51 GMT, Jie Fu wrote: >> Hi all, >> >> I'd like to update the testing docs for MacOS with Non-US locale. >> >> Our experiments show that the solution mentioned for Windows with Non-US >> locale also works for MacOS. >> So it would be helpful to mention MacOS explicitl

Re: RFR: 8274273: Update testing docs for MacOS with Non-US locale [v2]

2021-09-24 Thread Erik Joelsson
On Fri, 24 Sep 2021 13:36:51 GMT, Jie Fu wrote: >> Hi all, >> >> I'd like to update the testing docs for MacOS with Non-US locale. >> >> Our experiments show that the solution mentioned for Windows with Non-US >> locale also works for MacOS. >> So it would be helpful to mention MacOS explicitl

Re: RFR: 8274273: Update testing docs for MacOS with Non-US locale [v2]

2021-09-24 Thread Jie Fu
> Hi all, > > I'd like to update the testing docs for MacOS with Non-US locale. > > Our experiments show that the solution mentioned for Windows with Non-US > locale also works for MacOS. > So it would be helpful to mention MacOS explicitly. > > FYI: changes in doc/testing.html was made by `mak

Re: RFR: 8274273: Update testing docs for MacOS with Non-US locale [v2]

2021-09-24 Thread Jie Fu
On Fri, 24 Sep 2021 13:06:55 GMT, Erik Joelsson wrote: > The actual change is ok, but it seems your version of pandoc is creating a > lot of spurious changes throughout the html version. Since this change is so > small, maybe you could just manually revert everything but the actual text > addi

Re: RFR: 8274273: Update testing docs for MacOS with Non-US locale

2021-09-24 Thread Erik Joelsson
On Fri, 24 Sep 2021 09:50:19 GMT, Jie Fu wrote: > Hi all, > > I'd like to update the testing docs for MacOS with Non-US locale. > > Our experiments show that the solution mentioned for Windows with Non-US > locale also works for MacOS. > So it would be helpful to mention MacOS explicitly. > >

Re: RFR: JDK-8274170: Add hooks for custom makefiles to augment jtreg test execution

2021-09-24 Thread Erik Joelsson
On Thu, 23 Sep 2021 22:02:07 GMT, Mikhailo Seledtsov wrote: > Please review this small change that adds hook for custom makefiles to > augment parameters for jtreg test execution. Marked as reviewed by erikj (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5666

Re: RFR: 8274083: Update testing docs to mention tiered testing [v6]

2021-09-24 Thread Lance Andersen
On Fri, 24 Sep 2021 06:12:20 GMT, Aleksey Shipilev wrote: >> Now that OpenJDK has more or less complete `tier{1,2,3,4}` definitions, >> let's mention them in `testing.md`. >> >> Current patch is my braindump, I am open for suggestions :) > > Aleksey Shipilev has updated the pull request increm

RFR: 8274273: Update testing docs for MacOS with Non-US locale

2021-09-24 Thread Jie Fu
Hi all, I'd like to update the testing docs for MacOS with Non-US locale. Our experiments show that the solution mentioned for Windows with Non-US locale also works for MacOS. So it would be helpful to mention MacOS explicitly. FYI: changes in doc/testing.html was made by `make update-build-doc

Integrated: 8274083: Update testing docs to mention tiered testing

2021-09-24 Thread Aleksey Shipilev
On Tue, 21 Sep 2021 14:52:26 GMT, Aleksey Shipilev wrote: > Now that OpenJDK has more or less complete `tier{1,2,3,4}` definitions, let's > mention them in `testing.md`. > > Current patch is my braindump, I am open for suggestions :) This pull request has now been integrated. Changeset: 971a