Re: RFR: 8275449: Add linux-aarch64-zero build profile

2021-10-19 Thread Erik Joelsson
On Tue, 19 Oct 2021 23:22:06 GMT, Mikhailo Seledtsov wrote: > Please review this small change that adds the linux-aarch64 zero build > profile. Looks good otherwise. make/autoconf/lib-ffi.m4 line 152: > 150: AC_MSG_ERROR([Could not locate libffi.so.? for bundling]) > 151:

Re: RFR: 8275449: Add linux-aarch64-zero build profile

2021-10-19 Thread Mikhailo Seledtsov
On Tue, 19 Oct 2021 23:22:06 GMT, Mikhailo Seledtsov wrote: > Please review this small change that adds the linux-aarch64 zero build > profile. Testing: - linux-aarch64 zero build - PASS - major platform builds: linux-x64, linux-aarch64, windows-x64, macosx-x64, macosx-aarch64 - PASS ---

RFR: 8275449: Add linux-aarch64-zero build profile

2021-10-19 Thread Mikhailo Seledtsov
Please review this small change that adds the linux-aarch64 zero build profile. - Commit messages: - Add linux-aarch64-zero to jib build profiles - Add aarch64 as target CPU for libffi lookup Changes: https://git.openjdk.java.net/jdk/pull/6024/files Webrev: https://webrevs.openjdk

Re: RFR: 8248584: Enable CHECK_UNHANDLED_OOPS for Windows fastdebug builds

2021-10-19 Thread Erik Joelsson
On Tue, 19 Oct 2021 19:21:24 GMT, Harold Seigel wrote: > Please review this small change to enable CHECK_UNHANDLED_OOPs for Windows > fastdebug builds. The change was tested by running Mach5 tiers 1-6 on > Windows-x64-debug. > > Thanks, Harold Looks good to me. - Marked as revi

Re: RFR: 8248584: Enable CHECK_UNHANDLED_OOPS for Windows fastdebug builds

2021-10-19 Thread David Holmes
On Tue, 19 Oct 2021 19:21:24 GMT, Harold Seigel wrote: > Please review this small change to enable CHECK_UNHANDLED_OOPs for Windows > fastdebug builds. The change was tested by running Mach5 tiers 1-6 on > Windows-x64-debug. > > Thanks, Harold Seems fine to me. Thanks, David -

Integrated: 8275512: Upgrade required version of jtreg to 6.1

2021-10-19 Thread Weijun Wang
On Tue, 19 Oct 2021 13:51:45 GMT, Weijun Wang wrote: > As a follow up of JEP 411, we will soon disallow security manager by default. > jtreg 6.1 does not set its own security manager if JDK version is >= 18. This pull request has now been integrated. Changeset: c24fb852 Author:Weijun Wang

RFR: 8248584: Enable CHECK_UNHANDLED_OOPS for Windows fastdebug builds

2021-10-19 Thread Harold Seigel
Please review this small change to enable CHECK_UNHANDLED_OOPs for Windows fastdebug builds. The change was tested by running Mach5 tiers 1-6 on Windows-x64-debug. Thanks, Harold - Commit messages: - 8248584: Enable CHECK_UNHANDLED_OOPS for Windows fastdebug builds Changes: http

Re: RFR: 8275512: Upgrade required version of jtreg to 6.1 [v2]

2021-10-19 Thread Mandy Chung
On Tue, 19 Oct 2021 17:24:17 GMT, Weijun Wang wrote: >> As a follow up of JEP 411, we will soon disallow security manager by >> default. jtreg 6.1 does not set its own security manager if JDK version is >> >= 18. > > Weijun Wang has updated the pull request incrementally with one additional >

Integrated: 8275252: Migrate cacerts from JKS to password-less PKCS12

2021-10-19 Thread Weijun Wang
On Thu, 14 Oct 2021 13:36:19 GMT, Weijun Wang wrote: > The cacerts file is now a password-less PKCS12 file. This make sure old code > that uses a JKS KeyStore object can continuously load it using a null > password (in fact, any password) and see all certificates inside. This pull request has

Re: RFR: 8275512: Upgrade required version of jtreg to 6.1 [v2]

2021-10-19 Thread Jonathan Gibbons
On Tue, 19 Oct 2021 17:24:17 GMT, Weijun Wang wrote: >> As a follow up of JEP 411, we will soon disallow security manager by >> default. jtreg 6.1 does not set its own security manager if JDK version is >> >= 18. > > Weijun Wang has updated the pull request incrementally with one additional >

Re: RFR: 8275252: Migrate cacerts from JKS to password-less PKCS12 [v2]

2021-10-19 Thread Weijun Wang
On Tue, 19 Oct 2021 18:49:11 GMT, Sean Mullan wrote: >> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> use a standard name > > make/jdk/src/classes/build/tools/generatecacerts/GenerateCacerts.java line 54: > >> 52: publ

Re: RFR: 8275252: Migrate cacerts from JKS to password-less PKCS12 [v2]

2021-10-19 Thread Sean Mullan
On Tue, 19 Oct 2021 19:48:23 GMT, Weijun Wang wrote: >> The cacerts file is now a password-less PKCS12 file. This make sure old code >> that uses a JKS KeyStore object can continuously load it using a null >> password (in fact, any password) and see all certificates inside. > > Weijun Wang has

Re: RFR: 8275252: Migrate cacerts from JKS to password-less PKCS12 [v2]

2021-10-19 Thread Weijun Wang
> The cacerts file is now a password-less PKCS12 file. This make sure old code > that uses a JKS KeyStore object can continuously load it using a null > password (in fact, any password) and see all certificates inside. Weijun Wang has updated the pull request incrementally with one additional c

Re: RFR: 8275512: Upgrade required version of jtreg to 6.1 [v2]

2021-10-19 Thread Lance Andersen
On Tue, 19 Oct 2021 17:24:17 GMT, Weijun Wang wrote: >> As a follow up of JEP 411, we will soon disallow security manager by >> default. jtreg 6.1 does not set its own security manager if JDK version is >> >= 18. > > Weijun Wang has updated the pull request incrementally with one additional >

Re: RFR: JDK-8275406: Add copy-to-clipboard feature to snippet UI

2021-10-19 Thread Erik Joelsson
On Tue, 19 Oct 2021 13:51:03 GMT, Hannes Wallnöfer wrote: > Please review a change to add a copy-to-clipboard feature to snippets. I took > special care to make the feature usable on mobile devices. Sample output can > be viewed and tested here: > > http://cr.openjdk.java.net/~hannesw/8275406/

Re: RFR: 8275512: Upgrade required version of jtreg to 6.1 [v2]

2021-10-19 Thread Joe Wang
On Tue, 19 Oct 2021 17:24:17 GMT, Weijun Wang wrote: >> As a follow up of JEP 411, we will soon disallow security manager by >> default. jtreg 6.1 does not set its own security manager if JDK version is >> >= 18. > > Weijun Wang has updated the pull request incrementally with one additional >

Re: RFR: 8275512: Upgrade required version of jtreg to 6.1 [v2]

2021-10-19 Thread Weijun Wang
> As a follow up of JEP 411, we will soon disallow security manager by default. > jtreg 6.1 does not set its own security manager if JDK version is >= 18. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: upgrade the version in GHA conf

Re: RFR: JDK-8275406: Add copy-to-clipboard feature to snippet UI

2021-10-19 Thread Pavel Rappo
On Tue, 19 Oct 2021 13:51:03 GMT, Hannes Wallnöfer wrote: > Please review a change to add a copy-to-clipboard feature to snippets. I took > special care to make the feature usable on mobile devices. Sample output can > be viewed and tested here: > > http://cr.openjdk.java.net/~hannesw/8275406/

Re: RFR: 8275512: Upgrade required version of jtreg to 6.1

2021-10-19 Thread Igor Ignatyev
On Tue, 19 Oct 2021 13:51:45 GMT, Weijun Wang wrote: > As a follow up of JEP 411, we will soon disallow security manager by default. > jtreg 6.1 does not set its own security manager if JDK version is >= 18. LGTM - Marked as reviewed by iignatyev (Reviewer). PR: https://git.openj

RFR: JDK-8275406: Add copy-to-clipboard feature to snippet UI

2021-10-19 Thread Hannes Wallnöfer
Please review a change to add a copy-to-clipboard feature to snippets. I took special care to make the feature usable on mobile devices. Sample output can be viewed and tested here: http://cr.openjdk.java.net/~hannesw/8275406/api.00/java.base/java/lang/Throwable.html#printStackTrace() -

Re: RFR: 8275512: Upgrade required version of jtreg to 6.1

2021-10-19 Thread Magnus Ihse Bursie
On Tue, 19 Oct 2021 13:51:45 GMT, Weijun Wang wrote: > As a follow up of JEP 411, we will soon disallow security manager by default. > jtreg 6.1 does not set its own security manager if JDK version is >= 18. LGTM - Marked as reviewed by ihse (Reviewer). PR: https://git.openjdk.ja

RFR: 8275512: Upgrade required version of jtreg to 6.1

2021-10-19 Thread Weijun Wang
As a follow up of JEP 411, we will soon disallow security manager by default. jtreg 6.1 does not set its own security manager if JDK version is >= 18. - Commit messages: - 8275512: Upgrade required version of jtreg to 6.1 Changes: https://git.openjdk.java.net/jdk/pull/6012/files W

Integrated: 8245095: Implementation of JEP 408: Simple Web Server

2021-10-19 Thread Julia Boes
On Tue, 14 Sep 2021 08:52:37 GMT, Julia Boes wrote: > This change implements a simple web server that can be run on the > command-line with `java -m jdk.httpserver`. > > This is facilitated by adding an entry point for the `jdk.httpserver` module, > an implementation class whose main method is