On Tue, 9 Nov 2021 20:47:29 GMT, Anirvan Sarkar wrote:
> Use version `3.2.0` of `cygwin` instead of latest version `3.3.2` on GitHub
> Actions.
> `make` SEGVs on the latest version.
>
> Version number format obtained from
> https://cygwin.com/packages/summary/cygwin.html
The patch looks okay.
On Tue, 9 Nov 2021 20:47:29 GMT, Anirvan Sarkar wrote:
> Use version `3.2.0` of `cygwin` instead of latest version `3.3.2` on GitHub
> Actions.
> `make` SEGVs on the latest version.
>
> Version number format obtained from
> https://cygwin.com/packages/summary/cygwin.html
This pull request has
On Wed, 10 Nov 2021 00:55:13 GMT, Yasumasa Suenaga wrote:
>> JDK-8275128 introduced new Makefile for hsdis to integrate it to normal
>> build system, however it does not work on WSL 1 Ubuntu 20.04 and MinGW from
>> Ubuntu.
>>
>> Hsdis.gmk has two problems:
>>
>> 1. MinGW version is fixed to "
> JDK-8275128 introduced new Makefile for hsdis to integrate it to normal build
> system, however it does not work on WSL 1 Ubuntu 20.04 and MinGW from Ubuntu.
>
> Hsdis.gmk has two problems:
>
> 1. MinGW version is fixed to "9.2.0"
> 2. Assumes sysroot for MinGW is located at /usr/$MINGW_BASE/s
> JDK-8275128 introduced new Makefile for hsdis to integrate it to normal build
> system, however it does not work on WSL 1 Ubuntu 20.04 and MinGW from Ubuntu.
>
> Hsdis.gmk has two problems:
>
> 1. MinGW version is fixed to "9.2.0"
> 2. Assumes sysroot for MinGW is located at /usr/$MINGW_BASE/s
On Tue, 9 Nov 2021 15:06:05 GMT, Magnus Ihse Bursie wrote:
>> JDK-8275128 introduced new Makefile for hsdis to integrate it to normal
>> build system, however it does not work on WSL 1 Ubuntu 20.04 and MinGW from
>> Ubuntu.
>>
>> Hsdis.gmk has two problems:
>>
>> 1. MinGW version is fixed to
On Tue, 9 Nov 2021 20:47:29 GMT, Anirvan Sarkar wrote:
> Use version `3.2.0` of `cygwin` instead of latest version `3.3.2` on GitHub
> Actions.
> `make` SEGVs on the latest version.
>
> Version number format obtained from
> https://cygwin.com/packages/summary/cygwin.html
Cool. Thanks for doin
Use version `3.2.0` of `cygwin` instead of latest version `3.3.2` on GitHub
Actions.
`make` SEGVs on the latest version.
Version number format obtained from
https://cygwin.com/packages/summary/cygwin.html
-
Commit messages:
- Use cygwin version 3.2.0 on GitHub Actions
Changes: ht
On Tue, 9 Nov 2021 17:26:05 GMT, Erik Joelsson wrote:
>> @erikj79 so had a bit of a think, and part of the unzipping.. then
>> re-gen'ing is not having to load all the entries into memory. You can't
>> guarantee the order "zip" has created them in, so realistically i'd have to
>> read all the
On Tue, 9 Nov 2021 12:59:17 GMT, Andrew Leonard wrote:
> This PR adds a new openjdk build tool GenerateZip, which generates a final
> "zip" file from an input folder, and creates it in a deterministic way,
> ensuring ordering and timestamps are set as specified.
>
> Using this tool in ZipArchi
On Tue, 9 Nov 2021 14:45:56 GMT, Aleksey Shipilev wrote:
> Current GHA runs at 17 GA, which misses fixes from 17.0.1.
>
> Additional testing:
> - [x] GHA builds are fine
> - [ ] GHA tests are fine
Marked as reviewed by erikj (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/
On Tue, 9 Nov 2021 14:55:52 GMT, Andrew Leonard wrote:
>> make/common/ZipArchive.gmk line 178:
>>
>>> 176:(cd $$(SUPPORT_OUTPUTDIR)/ziptmp/$1/files && \
>>> 177: $(RM) $$@ && \
>>> 178: $(UNZIP) -q $$(SUPPORT_OUTPUTDIR)/ziptmp/$1/tmp.zip && \
>>
>> Having to
Current GHA runs at 17 GA, which misses fixes from 17.0.1.
Additional testing:
- [x] GHA builds are fine
- [ ] GHA tests are fine
-
Commit messages:
- Fix
Changes: https://git.openjdk.java.net/jdk/pull/6314/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6314&rang
On Tue, 9 Nov 2021 14:57:52 GMT, Magnus Ihse Bursie wrote:
> We already have an --enable-reproducible-builds. If (and I say if) we need to
> turn this on/off with a flag, this would to fine.
>
> However, as I have said previously in a private discussion with Andrew, I
> prefer it if we can mak
On Tue, 9 Nov 2021 15:00:59 GMT, Magnus Ihse Bursie wrote:
> And have you verified that running with `zip -X` is not enough? I remember
> checking into this before, but I don't remember the conclusions. The purpose
> is to leave out some extra information, such as time stamps, but it might not
On Fri, 5 Nov 2021 03:03:55 GMT, Yasumasa Suenaga wrote:
> JDK-8275128 introduced new Makefile for hsdis to integrate it to normal build
> system, however it does not work on WSL 1 Ubuntu 20.04 and MinGW from Ubuntu.
>
> Hsdis.gmk has two problems:
>
> 1. MinGW version is fixed to "9.2.0"
> 2.
On Tue, 9 Nov 2021 12:59:17 GMT, Andrew Leonard wrote:
> This PR adds a new openjdk build tool GenerateZip, which generates a final
> "zip" file from an input folder, and creates it in a deterministic way,
> ensuring ordering and timestamps are set as specified.
>
> Using this tool in ZipArchi
On Tue, 9 Nov 2021 13:58:24 GMT, Erik Joelsson wrote:
>> This PR adds a new openjdk build tool GenerateZip, which generates a final
>> "zip" file from an input folder, and creates it in a deterministic way,
>> ensuring ordering and timestamps are set as specified.
>>
>> Using this tool in ZipA
On Tue, 9 Nov 2021 06:36:53 GMT, Yasumasa Suenaga wrote:
> Now OpenJDK supports VS 2017 and 2019 for building.
> VS 2022 has been released in Nov. 2021, so I want to add VS 2022 to build
> system for Windows.
This pull request has now been integrated.
Changeset: f65db88b
Author:Yasumasa Su
On Tue, 9 Nov 2021 14:04:27 GMT, Erik Joelsson wrote:
> I think it would it make sense add a configure parameter to to enable/disable
> this new functionality. I think developers would want to opt out of extra
> unnecessary build steps when building and testing locally. Not sure what the
> def
On Tue, 9 Nov 2021 13:58:24 GMT, Erik Joelsson wrote:
>> This PR adds a new openjdk build tool GenerateZip, which generates a final
>> "zip" file from an input folder, and creates it in a deterministic way,
>> ensuring ordering and timestamps are set as specified.
>>
>> Using this tool in ZipA
On Fri, 5 Nov 2021 03:03:55 GMT, Yasumasa Suenaga wrote:
> JDK-8275128 introduced new Makefile for hsdis to integrate it to normal build
> system, however it does not work on WSL 1 Ubuntu 20.04 and MinGW from Ubuntu.
>
> Hsdis.gmk has two problems:
>
> 1. MinGW version is fixed to "9.2.0"
> 2.
On Tue, 9 Nov 2021 12:59:17 GMT, Andrew Leonard wrote:
> This PR adds a new openjdk build tool GenerateZip, which generates a final
> "zip" file from an input folder, and creates it in a deterministic way,
> ensuring ordering and timestamps are set as specified.
>
> Using this tool in ZipArchi
On Tue, 9 Nov 2021 06:36:53 GMT, Yasumasa Suenaga wrote:
> Now OpenJDK supports VS 2017 and 2019 for building.
> VS 2022 has been released in Nov. 2021, so I want to add VS 2022 to build
> system for Windows.
Marked as reviewed by ihse (Reviewer).
-
PR: https://git.openjdk.java.ne
On Tue, 9 Nov 2021 06:36:53 GMT, Yasumasa Suenaga wrote:
> Now OpenJDK supports VS 2017 and 2019 for building.
> VS 2022 has been released in Nov. 2021, so I want to add VS 2022 to build
> system for Windows.
Marked as reviewed by erikj (Reviewer).
-
PR: https://git.openjdk.java.n
This PR adds a new openjdk build tool GenerateZip, which generates a final
"zip" file from an input folder, and creates it in a deterministic way,
ensuring ordering and timestamps are set as specified.
Using this tool in ZipArchive.gmk will ensure src.zip is then created
deterministically.
Sig
Now OpenJDK supports VS 2017 and 2019 for building.
VS 2022 has been released in Nov. 2021, so I want to add VS 2022 to build
system for Windows.
-
Commit messages:
- 8276841: Add support for Visual Studio 2022
Changes: https://git.openjdk.java.net/jdk/pull/6304/files
Webrev: http
27 matches
Mail list logo
