On Thu, 11 Nov 2021 15:32:01 GMT, Jayathirth D V wrote:
>> When JDK is built on BigSur with Xcode12.5 and used to run jtreg tests in
>> macOS10.15 with Xcode <=12.4 we are getting compilation error. We dont set
>> any deployment target when when we use xcrun to create .air file and this
>> iss
On Fri, 12 Nov 2021 18:29:01 GMT, Daniel D. Daugherty
wrote:
> This reverts commit aeba65303479130d9bab74484accad5d7d116a40.
This pull request has now been integrated.
Changeset: 74f3e69d
Author:Daniel D. Daugherty
URL:
https://git.openjdk.java.net/jdk/commit/74f3e69dc888685558408e
On Fri, 12 Nov 2021 18:38:42 GMT, Erik Joelsson wrote:
>> This reverts commit aeba65303479130d9bab74484accad5d7d116a40.
>
> Marked as reviewed by erikj (Reviewer).
@erikj79 - Thanks for the fast review!
-
PR: https://git.openjdk.java.net/jdk/pull/6370
On Fri, 12 Nov 2021 18:29:01 GMT, Daniel D. Daugherty
wrote:
> This reverts commit aeba65303479130d9bab74484accad5d7d116a40.
Marked as reviewed by erikj (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/6370
This reverts commit aeba65303479130d9bab74484accad5d7d116a40.
-
Commit messages:
- JDK-8277071 [BACKOUT] JDK-8276743 Make openjdk build Zip Archive generation
"reproducible"
Changes: https://git.openjdk.java.net/jdk/pull/6370/files
Webrev: https://webrevs.openjdk.java.net/?repo=jd
On Fri, 12 Nov 2021 17:45:09 GMT, Phil Race wrote:
> My understanding is that the flag here affects ONLY the metal compiler - for
> compiling metal shaders. And if you don't specify -Dsun.java2d.metal=true
> (since metal is off by defau�lt) its a 100% no-op for the rest of the JDK.
> And alrea
On Thu, 11 Nov 2021 15:32:01 GMT, Jayathirth D V wrote:
>> When JDK is built on BigSur with Xcode12.5 and used to run jtreg tests in
>> macOS10.15 with Xcode <=12.4 we are getting compilation error. We dont set
>> any deployment target when when we use xcrun to create .air file and this
>> iss
On Fri, 12 Nov 2021 16:18:04 GMT, Alan Hayward wrote:
>> PAC is an optional feature in AArch64 8.3 and is compulsory in v9. One
>> of its uses is to protect against ROP based attacks. This is done by
>> signing the Link Register whenever it is stored on the stack, and
>> authenticating the value
On Fri, 12 Nov 2021 14:55:24 GMT, Magnus Ihse Bursie wrote:
> If we leave -mmacosx-version-min unspecified, will metal pick another value
> by default silently? And if so, might we be actually lowering the min version
> even if specifying 10.14?
I'm not sure how Xcode picks the default target,
On Thu, 11 Nov 2021 08:48:07 GMT, Alan Hayward wrote:
>> PAC is an optional feature in AArch64 8.3 and is compulsory in v9. One
>> of its uses is to protect against ROP based attacks. This is done by
>> signing the Link Register whenever it is stored on the stack, and
>> authenticating the value
> PAC is an optional feature in AArch64 8.3 and is compulsory in v9. One
> of its uses is to protect against ROP based attacks. This is done by
> signing the Link Register whenever it is stored on the stack, and
> authenticating the value when it is loaded back from the stack. If an
> attacker were
On Thu, 11 Nov 2021 15:32:01 GMT, Jayathirth D V wrote:
>> When JDK is built on BigSur with Xcode12.5 and used to run jtreg tests in
>> macOS10.15 with Xcode <=12.4 we are getting compilation error. We dont set
>> any deployment target when when we use xcrun to create .air file and this
>> iss
On Thu, 11 Nov 2021 15:32:01 GMT, Jayathirth D V wrote:
>> When JDK is built on BigSur with Xcode12.5 and used to run jtreg tests in
>> macOS10.15 with Xcode <=12.4 we are getting compilation error. We dont set
>> any deployment target when when we use xcrun to create .air file and this
>> iss
On Tue, 9 Nov 2021 12:59:17 GMT, Andrew Leonard wrote:
> This PR adds a new openjdk build tool MakeZipReproducible, which if
> ENABLE_REPRODUCIBLE_BUILD is enabled, generates a final "zip" file in a
> deterministic way, ensuring ordering and timestamps are set as specified.
>
> Using this tool
On Fri, 12 Nov 2021 14:34:50 GMT, Erik Joelsson wrote:
>> Sorry, I'm mis-reading the lines here. It's of course for docs-zip. Then
>> it's perfectly in order! :-)
>
> It's using JarArchive.gmk, which is a similar, but different and probably
> also needs the same treatment. We should probably sh
On Fri, 12 Nov 2021 14:28:31 GMT, Magnus Ihse Bursie wrote:
>> make/Main.gmk line 511:
>>
>>> 509: MAKEFILE := Docs, \
>>> 510: TARGET := docs-zip, \
>>> 511: DEPS := docs-jdk buildtools-jdk, \
>>
>> Is this really needed? I did not think jrtfs-jar used zip?
>
> Sorry, I'm mis-read
On Fri, 12 Nov 2021 14:24:00 GMT, Magnus Ihse Bursie wrote:
>> Andrew Leonard has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8276743: Make openjdk build Zip Archive generation "reproducible"
>>
>> Signed-off-by: Andrew Leonard
>
>
On Fri, 12 Nov 2021 08:24:13 GMT, Andrew Leonard wrote:
>> This PR adds a new openjdk build tool MakeZipReproducible, which if
>> ENABLE_REPRODUCIBLE_BUILD is enabled, generates a final "zip" file in a
>> deterministic way, ensuring ordering and timestamps are set as specified.
>>
>> Using thi
On Fri, 12 Nov 2021 08:24:13 GMT, Andrew Leonard wrote:
>> This PR adds a new openjdk build tool MakeZipReproducible, which if
>> ENABLE_REPRODUCIBLE_BUILD is enabled, generates a final "zip" file in a
>> deterministic way, ensuring ordering and timestamps are set as specified.
>>
>> Using thi
On Fri, 12 Nov 2021 08:24:13 GMT, Andrew Leonard wrote:
>> This PR adds a new openjdk build tool MakeZipReproducible, which if
>> ENABLE_REPRODUCIBLE_BUILD is enabled, generates a final "zip" file in a
>> deterministic way, ensuring ordering and timestamps are set as specified.
>>
>> Using thi
On Fri, 12 Nov 2021 14:22:09 GMT, Magnus Ihse Bursie wrote:
>> @erikj79 all tests pass, ready for re-review please, thanks
>
> @andrew-m-leonard Yes, pushing an empty commit is much better. The Skara
> tooling will automatically squash all commits in the PR when it is
> integrated, so it will b
On Fri, 12 Nov 2021 11:15:30 GMT, Andrew Leonard wrote:
>>> I think that the post-processing of the zip file can be dependent on this
>>> variable and that it serves no purpose to introduce a separate variable
>>> ENABLE_REPRODUCIBLE_ZIP that is set to the same value as
>>> ENABLE_REPRODUCIBLE
On Thu, 11 Nov 2021 15:37:09 GMT, Emmanuel Bourg wrote:
>> The copyright headers are generated at build time, and the year inserted in
>> the template depends on the current date. This means the headers are not
>> reproducible if the project is built a year later. The year in the headers
>> co
On Thu, 11 Nov 2021 15:32:01 GMT, Jayathirth D V wrote:
>> When JDK is built on BigSur with Xcode12.5 and used to run jtreg tests in
>> macOS10.15 with Xcode <=12.4 we are getting compilation error. We dont set
>> any deployment target when when we use xcrun to create .air file and this
>> iss
On Thu, 11 Nov 2021 14:32:18 GMT, Magnus Ihse Bursie wrote:
> I ran bin/blessed-modifier-order.sh on source code in src/utils. This scripts
> verifies that modifiers are in the "blessed" order, and fixes it otherwise. I
> have manually checked the changes made by the script to make sure they ar
On Wed, 10 Nov 2021 14:39:09 GMT, Erik Joelsson wrote:
>> @erikj79 The flag --enable-reproducible-builds sets
>> ENABLE_REPRODUCIBLE_BUILD in spec.gmk. This is set by our JIB profiles. I
>> propose that we also turn it on for GHA builds.
>>
>> I think that the post-processing of the zip file
> This PR contains the API and implementation changes for JEP-419 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/419
Maurizio Cimadamore has updated the pull request
On Thu, 11 Nov 2021 14:32:18 GMT, Magnus Ihse Bursie wrote:
> I ran bin/blessed-modifier-order.sh on source code in src/utils. This scripts
> verifies that modifiers are in the "blessed" order, and fixes it otherwise. I
> have manually checked the changes made by the script to make sure they ar
> This PR adds a new openjdk build tool GenerateZip, which generates a final
> "zip" file from an input folder, and creates it in a deterministic way,
> ensuring ordering and timestamps are set as specified.
>
> Using this tool in ZipArchive.gmk will ensure src.zip is then created
> determinist
On Thu, 11 Nov 2021 19:48:04 GMT, Andrew Leonard wrote:
>> This PR adds a new openjdk build tool GenerateZip, which generates a final
>> "zip" file from an input folder, and creates it in a deterministic way,
>> ensuring ordering and timestamps are set as specified.
>>
>> Using this tool in Zi
30 matches
Mail list logo
