Re: RFR: 8276905: Use appropriate macosx_version_minimum value while compiling metal shaders [v4]

2021-11-15 Thread Phil Race
On Mon, 15 Nov 2021 14:00:59 GMT, Jayathirth D V wrote: >> When JDK is built on BigSur with Xcode12.5 and used to run jtreg tests in >> macOS10.15 with Xcode <=12.4 we are getting compilation error. We dont set >> any deployment target when when we use xcrun to create .air file and this >> iss

Re: RFR: 8276905: Use appropriate macosx_version_minimum value while compiling metal shaders [v4]

2021-11-15 Thread Jayathirth D V
On Mon, 15 Nov 2021 14:33:21 GMT, Magnus Ihse Bursie wrote: > Looks good to me also. Please let Phil have a say as well before integrating. Thanks Magnus for the review. Yes i have already Re-Requested review from Phil on latest patch. Also i am waiting on Vitaly(JBS submitter) to verify the la

Re: RFR: 8276905: Function frag_col has a deployment target which is incompatible with this OS [v4]

2021-11-15 Thread Magnus Ihse Bursie
On Mon, 15 Nov 2021 14:00:59 GMT, Jayathirth D V wrote: >> When JDK is built on BigSur with Xcode12.5 and used to run jtreg tests in >> macOS10.15 with Xcode <=12.4 we are getting compilation error. We dont set >> any deployment target when when we use xcrun to create .air file and this >> iss

Re: RFR: 8277089: Use system binutils to build hsdis [v2]

2021-11-15 Thread Magnus Ihse Bursie
On Mon, 15 Nov 2021 13:19:56 GMT, Yasumasa Suenaga wrote: >> hsdis requires binutils source tree for building. Most of Linux distros >> provide binutils package. (e.g. binutils-devel from Fedora, binutils-dev >> from Ubuntu) >> It would be nice to be able to use them like zlib and lcms. >> >>

Re: RFR: 8276905: Function frag_col has a deployment target which is incompatible with this OS [v3]

2021-11-15 Thread Jayathirth D V
On Mon, 15 Nov 2021 13:46:29 GMT, Kevin Rushforth wrote: >> Jayathirth D V has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Use 10.14 macOS version > > make/modules/java.desktop/lib/Awt2dLibraries.gmk line 844: > >> 842: # for aarch64 is

Re: RFR: 8276905: Function frag_col has a deployment target which is incompatible with this OS [v3]

2021-11-15 Thread Kevin Rushforth
On Mon, 15 Nov 2021 13:44:11 GMT, Jayathirth D V wrote: >> When JDK is built on BigSur with Xcode12.5 and used to run jtreg tests in >> macOS10.15 with Xcode <=12.4 we are getting compilation error. We dont set >> any deployment target when when we use xcrun to create .air file and this >> iss

Re: RFR: 8276905: Function frag_col has a deployment target which is incompatible with this OS [v4]

2021-11-15 Thread Erik Joelsson
On Mon, 15 Nov 2021 13:57:25 GMT, Jayathirth D V wrote: >> When JDK is built on BigSur with Xcode12.5 and used to run jtreg tests in >> macOS10.15 with Xcode <=12.4 we are getting compilation error. We dont set >> any deployment target when when we use xcrun to create .air file and this >> iss

Re: RFR: 8276905: Function frag_col has a deployment target which is incompatible with this OS [v2]

2021-11-15 Thread Jayathirth D V
On Mon, 15 Nov 2021 13:28:30 GMT, Kevin Rushforth wrote: > The JDK itself has a minimum version of 11.0 on macOS aarch64 systems > (because apple only supports it on macOS >= 11), so it probably doesn't > matter much. You might wish to file a low-priority follow-up issue to change > the runtim

Re: RFR: 8276905: Function frag_col has a deployment target which is incompatible with this OS [v4]

2021-11-15 Thread Kevin Rushforth
On Mon, 15 Nov 2021 13:57:25 GMT, Jayathirth D V wrote: >> When JDK is built on BigSur with Xcode12.5 and used to run jtreg tests in >> macOS10.15 with Xcode <=12.4 we are getting compilation error. We dont set >> any deployment target when when we use xcrun to create .air file and this >> iss

Re: RFR: 8276905: Function frag_col has a deployment target which is incompatible with this OS [v4]

2021-11-15 Thread Jayathirth D V
> When JDK is built on BigSur with Xcode12.5 and used to run jtreg tests in > macOS10.15 with Xcode <=12.4 we are getting compilation error. We dont set > any deployment target when when we use xcrun to create .air file and this > issue looks similar to https://developer.apple.com/forums/thread/

Re: RFR: 8264130: PAC-RET protection for Linux/AArch64 [v4]

2021-11-15 Thread Alan Hayward
On Mon, 15 Nov 2021 11:54:09 GMT, Andrew Dinn wrote: > pauth_strip_verifiable That name works for me. - PR: https://git.openjdk.java.net/jdk/pull/6334

Re: RFR: 8277089: Use system binutils to build hsdis

2021-11-15 Thread Yasumasa Suenaga
On Mon, 15 Nov 2021 10:23:48 GMT, Magnus Ihse Bursie wrote: >> hsdis requires binutils source tree for building. Most of Linux distros >> provide binutils package. (e.g. binutils-devel from Fedora, binutils-dev >> from Ubuntu) >> It would be nice to be able to use them like zlib and lcms. >> >

Re: RFR: 8276905: Function frag_col has a deployment target which is incompatible with this OS [v3]

2021-11-15 Thread Jayathirth D V
> When JDK is built on BigSur with Xcode12.5 and used to run jtreg tests in > macOS10.15 with Xcode <=12.4 we are getting compilation error. We dont set > any deployment target when when we use xcrun to create .air file and this > issue looks similar to https://developer.apple.com/forums/thread/

Re: RFR: 8276905: Function frag_col has a deployment target which is incompatible with this OS [v2]

2021-11-15 Thread Erik Joelsson
On Mon, 15 Nov 2021 07:17:45 GMT, Jayathirth D V wrote: > A question popped up while doing this. By making 11.0 as minimum macosx > version on aarch64, are we not restricting metal to be used only on >=11.0 on > aarch 64? Correct, but there are no older versions of Macos on aarch64, so this is

Re: RFR: 8276905: Function frag_col has a deployment target which is incompatible with this OS [v2]

2021-11-15 Thread Kevin Rushforth
On Thu, 11 Nov 2021 15:32:01 GMT, Jayathirth D V wrote: >> When JDK is built on BigSur with Xcode12.5 and used to run jtreg tests in >> macOS10.15 with Xcode <=12.4 we are getting compilation error. We dont set >> any deployment target when when we use xcrun to create .air file and this >> iss

Re: RFR: 8277089: Use system binutils to build hsdis [v2]

2021-11-15 Thread Yasumasa Suenaga
> hsdis requires binutils source tree for building. Most of Linux distros > provide binutils package. (e.g. binutils-devel from Fedora, binutils-dev from > Ubuntu) > It would be nice to be able to use them like zlib and lcms. > > Unfortunately bfdver.h would not be provided because it is not inc

Re: RFR: 8264130: PAC-RET protection for Linux/AArch64 [v4]

2021-11-15 Thread Andrew Dinn
On Mon, 15 Nov 2021 11:08:57 GMT, Andrew Haley wrote: >>>whether this function authenticates or strips the address depends only on >>>debugging? >> >> Yes. We only need to strip the value, because we're not jumping to the lr >> value, only viewing it. >> >> The interface is different to a str

Re: RFR: 8264130: PAC-RET protection for Linux/AArch64 [v4]

2021-11-15 Thread Alan Hayward
On Mon, 15 Nov 2021 11:30:35 GMT, Andrew Haley wrote: >> In the original code: >> *save r0 to the lr location on the stack >> *restore_live_registers >> *Standard return: remove stack frame, load lr and fp off the stack, jump to >> lr. >> >> With PAC it would now be: >> *Sign r0 then save it t

Re: RFR: 8264130: PAC-RET protection for Linux/AArch64 [v4]

2021-11-15 Thread Andrew Haley
On Mon, 15 Nov 2021 11:21:37 GMT, Alan Hayward wrote: >> src/hotspot/cpu/aarch64/c1_Runtime1_aarch64.cpp line 452: >> >>> 450: // patch the return address, this stub will directly return to the >>> exception handler >>> 451: __ str(r0, Address(rfp, 1*BytesPerWord)); >>> 452: >> >> Please

Re: RFR: 8264130: PAC-RET protection for Linux/AArch64 [v4]

2021-11-15 Thread Alan Hayward
On Mon, 15 Nov 2021 10:15:41 GMT, Andrew Haley wrote: >> Alan Hayward has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains eight commits: >> >> - Merge master >> - Document pauth functions && remove OS split >> - Update UseROPProtec

Re: RFR: 8264130: PAC-RET protection for Linux/AArch64 [v4]

2021-11-15 Thread Andrew Haley
On Mon, 15 Nov 2021 10:58:06 GMT, Alan Hayward wrote: >> src/hotspot/cpu/aarch64/pauth_aarch64.hpp line 132: >> >>> 130: // Authenticate or strip a return value. Use for efficiency and only >>> when the safety of the data >>> 131: // isn't an issue - for example when viewing the stack. >>> 132:

Re: RFR: 8264130: PAC-RET protection for Linux/AArch64 [v4]

2021-11-15 Thread Alan Hayward
On Mon, 15 Nov 2021 10:20:15 GMT, Andrew Haley wrote: >whether this function authenticates or strips the address depends only on >debugging? Yes. We only need to strip the value, because we're not jumping to the lr value, only viewing it. The interface is different to a strip (as we need to p

Re: RFR: 8264130: PAC-RET protection for Linux/AArch64 [v4]

2021-11-15 Thread Alan Hayward
On Wed, 10 Nov 2021 15:01:51 GMT, Alan Hayward wrote: >> src/hotspot/os_cpu/bsd_aarch64/pauth_bsd_aarch64.inline.hpp line 25: >> >>> 23: */ >>> 24: >>> 25: #ifndef OS_CPU_BSD_AARCH64_PAUTH_BSD_AARCH64_INLINE_HPP >> >> Are these two files different enough to separate them for BSD and Linux? >

Re: RFR: 8264130: PAC-RET protection for Linux/AArch64 [v4]

2021-11-15 Thread Andrew Dinn
On Mon, 15 Nov 2021 09:07:11 GMT, Alan Hayward wrote: >> PAC is an optional feature in AArch64 8.3 and is compulsory in v9. One >> of its uses is to protect against ROP based attacks. This is done by >> signing the Link Register whenever it is stored on the stack, and >> authenticating the value

Re: RFR: 8277089: Use system binutils to build hsdis

2021-11-15 Thread Magnus Ihse Bursie
On Sat, 13 Nov 2021 08:08:53 GMT, Yasumasa Suenaga wrote: > hsdis requires binutils source tree for building. Most of Linux distros > provide binutils package. (e.g. binutils-devel from Fedora, binutils-dev from > Ubuntu) > It would be nice to be able to use them like zlib and lcms. > > Unfort

Re: RFR: 8264130: PAC-RET protection for Linux/AArch64 [v4]

2021-11-15 Thread Andrew Haley
On Mon, 15 Nov 2021 09:07:11 GMT, Alan Hayward wrote: >> PAC is an optional feature in AArch64 8.3 and is compulsory in v9. One >> of its uses is to protect against ROP based attacks. This is done by >> signing the Link Register whenever it is stored on the stack, and >> authenticating the value

Re: RFR: 8264130: PAC-RET protection for Linux/AArch64 [v4]

2021-11-15 Thread Andrew Haley
On Mon, 15 Nov 2021 09:07:11 GMT, Alan Hayward wrote: >> PAC is an optional feature in AArch64 8.3 and is compulsory in v9. One >> of its uses is to protect against ROP based attacks. This is done by >> signing the Link Register whenever it is stored on the stack, and >> authenticating the value

Re: RFR: 8264130: PAC-RET protection for Linux/AArch64 [v4]

2021-11-15 Thread Andrew Haley
On Mon, 15 Nov 2021 09:07:11 GMT, Alan Hayward wrote: >> PAC is an optional feature in AArch64 8.3 and is compulsory in v9. One >> of its uses is to protect against ROP based attacks. This is done by >> signing the Link Register whenever it is stored on the stack, and >> authenticating the value

Re: RFR: 8264130: PAC-RET protection for Linux/AArch64 [v4]

2021-11-15 Thread Andrew Dinn
On Mon, 15 Nov 2021 09:07:11 GMT, Alan Hayward wrote: >> PAC is an optional feature in AArch64 8.3 and is compulsory in v9. One >> of its uses is to protect against ROP based attacks. This is done by >> signing the Link Register whenever it is stored on the stack, and >> authenticating the value

Re: RFR: 8264130: PAC-RET protection for Linux/AArch64 [v4]

2021-11-15 Thread Alan Hayward
> PAC is an optional feature in AArch64 8.3 and is compulsory in v9. One > of its uses is to protect against ROP based attacks. This is done by > signing the Link Register whenever it is stored on the stack, and > authenticating the value when it is loaded back from the stack. If an > attacker were