Re: RFR: 8275771: JDK source code contains redundant boolean operations in jdk.compiler and langtools

2021-11-29 Thread PROgrm_JARvis
On Mon, 29 Nov 2021 19:54:02 GMT, Joe Darcy wrote: >> Hi, >> >> Please review this PR which is basically rewriting some redundant boolean >> expressions in the compiler. >> >> TIA > > make/langtools/tools/compileproperties/CompileProperties.java line 187: > >> 185: } >> 186:

Re: RFR: 8275771: JDK source code contains redundant boolean operations in jdk.compiler and langtools

2021-11-29 Thread PROgrm_JARvis
On Mon, 29 Nov 2021 19:05:59 GMT, Vicente Romero wrote: > Hi, > > Please review this PR which is basically rewriting some redundant boolean > expressions in the compiler. > > TIA Changes requested by jarviscr...@github.com (no known OpenJDK username). src/jdk.compiler/share/classes/com/sun/t

Re: RFR: 8275771: JDK source code contains redundant boolean operations in jdk.compiler and langtools

2021-11-29 Thread Joe Darcy
On Mon, 29 Nov 2021 19:05:59 GMT, Vicente Romero wrote: > Hi, > > Please review this PR which is basically rewriting some redundant boolean > expressions in the compiler. > > TIA make/langtools/tools/compileproperties/CompileProperties.java line 187: > 185: } > 186:

Re: RFR: JDK-8273146: Start of release updates for JDK 19 [v5]

2021-11-29 Thread Iris Clark
On Mon, 29 Nov 2021 18:38:35 GMT, Joe Darcy wrote: >> The time to get JDK 19 underway draws nigh, please review this usual set of >> start-of-release updates, including CSRs for the javac and javax.lang.model >> updates: >> >> JDK-8277512: Add SourceVersion.RELEASE_19 >> https://bugs.openjdk.j

RFR: 8275771: JDK source code contains redundant boolean operations in jdk.compiler and langtools

2021-11-29 Thread Vicente Romero
Hi, Please review this PR which is basically rewriting some redundant boolean expressions in the compiler. TIA - Commit messages: - 8275771: JDK source code contains redundant boolean operations in jdk.compiler and langtools Changes: https://git.openjdk.java.net/jdk/pull/6599/fi

Re: RFR: JDK-8273146: Start of release updates for JDK 19 [v5]

2021-11-29 Thread Joe Darcy
> The time to get JDK 19 underway draws nigh, please review this usual set of > start-of-release updates, including CSRs for the javac and javax.lang.model > updates: > > JDK-8277512: Add SourceVersion.RELEASE_19 > https://bugs.openjdk.java.net/browse/JDK-8277512 > > JDK-8277514: Add source 19

Re: RFR: 8277944: JDK 18 - update GA Release Date

2021-11-29 Thread Sean Coffey
On Mon, 29 Nov 2021 16:19:12 GMT, Pavel Kharskii wrote: > 8277944: JDK 18 - update GA Release Date Marked as reviewed by coffeys (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6596

Re: RFR: 8277459: Add jwebserver tool [v6]

2021-11-29 Thread Julia Boes
> This change introduces jwebserver, a dedicated JDK tool for the Simple Web > Server. > > A description is provided in a follow-up comment. Julia Boes has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 16 commits: - Merge branch 'ma

Integrated: 8277944: JDK 18 - update GA Release Date

2021-11-29 Thread Pavel Kharskii
On Mon, 29 Nov 2021 16:19:12 GMT, Pavel Kharskii wrote: > 8277944: JDK 18 - update GA Release Date This pull request has now been integrated. Changeset: 825e633e Author:Pavel Kharskii Committer: Sean Coffey URL: https://git.openjdk.java.net/jdk/commit/825e633e71ca942fe88c509e7f951f

RFR: 8277944: JDK 18 - update GA Release Date

2021-11-29 Thread Pavel Kharskii
8277944: JDK 18 - update GA Release Date - Commit messages: - 8277944: JDK 18 - update GA Release Date Changes: https://git.openjdk.java.net/jdk/pull/6596/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6596&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-827

Re: RFR: 8277459: Add jwebserver tool [v3]

2021-11-29 Thread Julia Boes
On Thu, 25 Nov 2021 10:09:21 GMT, Daniel Fuchs wrote: >> Julia Boes has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fix whitespace error, add missing code tag > > src/jdk.httpserver/share/classes/sun/net/httpserver/simpleserver/Main.java

Re: RFR: 8277459: Add jwebserver tool [v5]

2021-11-29 Thread Daniel Fuchs
On Mon, 29 Nov 2021 13:57:13 GMT, Julia Boes wrote: >> This change introduces jwebserver, a dedicated JDK tool for the Simple Web >> Server. >> >> A description is provided in a follow-up comment. > > Julia Boes has updated the pull request incrementally with one additional > commit since the

Re: RFR: 8277459: Add jwebserver tool [v5]

2021-11-29 Thread Julia Boes
> This change introduces jwebserver, a dedicated JDK tool for the Simple Web > Server. > > A description is provided in a follow-up comment. Julia Boes has updated the pull request incrementally with one additional commit since the last revision: update comment about exit code

Re: RFR: 8277459: Add jwebserver tool [v3]

2021-11-29 Thread Daniel Fuchs
On Wed, 24 Nov 2021 17:29:40 GMT, Julia Boes wrote: >> This change introduces jwebserver, a dedicated JDK tool for the Simple Web >> Server. >> >> A description is provided in a follow-up comment. > > Julia Boes has updated the pull request incrementally with one additional > commit since the

Re: RFR: 8277459: Add jwebserver tool [v4]

2021-11-29 Thread Julia Boes
On Wed, 24 Nov 2021 14:05:03 GMT, Julia Boes wrote: >> src/jdk.httpserver/share/classes/com/sun/net/httpserver/SimpleFileServer.java >> line 110: >> >>> 108: * >>> 109: * A simple HTTP file server implementation is provided via the >>> 110: * {@code jwebserver} tool. >> >> Maybe an `@toolGu

Re: RFR: 8277459: Add jwebserver tool [v4]

2021-11-29 Thread Julia Boes
> This change introduces jwebserver, a dedicated JDK tool for the Simple Web > Server. > > A description is provided in a follow-up comment. Julia Boes has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 14 commits: - add toolGuide ta

Integrated: 8277847: Support toolGuide tag in class-level documentation

2021-11-29 Thread Julia Boes
On Thu, 25 Nov 2021 15:58:58 GMT, Julia Boes wrote: > This change adds support for the `@toolGuide` tag in class-level API > documentation. > > (A use case is the jwebserver tool, where the > com.sun.net.httpserver.SimpleFileServer class provides API points for > extension and customization