RFR: 8244602: Add JTREG_REPEAT_COUNT to repeat execution of a test

2021-12-06 Thread Aleksey Shipilev
This adds the test repeat feature in the build system. This is convenient to follow-up on intermittently failing tests: the `REPEAT_COUNT > 0` would run the test multiple times, until we run out of repeats or the tests fail. With this sample test: /* * @test * @run driver IntermittentTest *

Re: RFR: 8278251: Enable "missing-explicit-ctor" check in the jdk.unsupported.desktop module

2021-12-06 Thread Magnus Ihse Bursie
On Fri, 3 Dec 2021 20:55:23 GMT, Sergey Bylokhov wrote: > The "missing-explicit-ctor" check was disabled by the > [JDK-8071961](https://bugs.openjdk.java.net/browse/JDK-8071961) and later was > fixed by the [JDK-8250853](https://bugs.openjdk.java.net/browse/JDK-8250853). > So we can re-enable

Re: RFR: JDK-8278273: Remove unnecessary exclusion of doclint accessibility checks

2021-12-06 Thread Magnus Ihse Bursie
On Sun, 5 Dec 2021 23:45:32 GMT, Joe Darcy wrote: > Exploratory builds indicate it is not currently necessary to exclude the > doclint accessibility checks; this patch enables them. > > (Enabling the reference checks is left for future work.) 🎉 - Marked as reviewed by ihse (Revie

Re: RFR: 8244602: Add JTREG_REPEAT_COUNT to repeat execution of a test

2021-12-06 Thread Magnus Ihse Bursie
On Mon, 6 Dec 2021 11:12:22 GMT, Aleksey Shipilev wrote: > This adds the test repeat feature in the build system. This is convenient to > follow-up on intermittently failing tests: the `REPEAT_COUNT > 0` would run > the test multiple times, until we run out of repeats or the tests fail. > > Wi

Re: RFR: 8244602: Add JTREG_REPEAT_COUNT to repeat execution of a test

2021-12-06 Thread Erik Joelsson
On Mon, 6 Dec 2021 11:12:22 GMT, Aleksey Shipilev wrote: > This adds the test repeat feature in the build system. This is convenient to > follow-up on intermittently failing tests: the `REPEAT_COUNT > 0` would run > the test multiple times, until we run out of repeats or the tests fail. > > Wi

Integrated: JDK-8278273: Remove unnecessary exclusion of doclint accessibility checks

2021-12-06 Thread Joe Darcy
On Sun, 5 Dec 2021 23:45:32 GMT, Joe Darcy wrote: > Exploratory builds indicate it is not currently necessary to exclude the > doclint accessibility checks; this patch enables them. > > (Enabling the reference checks is left for future work.) This pull request has now been integrated. Changes

Re: RFR: 8278251: Enable "missing-explicit-ctor" check in the jdk.unsupported.desktop module

2021-12-06 Thread Phil Race
On Fri, 3 Dec 2021 20:55:23 GMT, Sergey Bylokhov wrote: > The "missing-explicit-ctor" check was disabled by the > [JDK-8071961](https://bugs.openjdk.java.net/browse/JDK-8071961) and later was > fixed by the [JDK-8250853](https://bugs.openjdk.java.net/browse/JDK-8250853). > So we can re-enable

Re: RFR: 8278251: Enable "missing-explicit-ctor" check in the jdk.unsupported.desktop module

2021-12-06 Thread Joe Darcy
On Fri, 3 Dec 2021 20:55:23 GMT, Sergey Bylokhov wrote: > The "missing-explicit-ctor" check was disabled by the > [JDK-8071961](https://bugs.openjdk.java.net/browse/JDK-8071961) and later was > fixed by the [JDK-8250853](https://bugs.openjdk.java.net/browse/JDK-8250853). > So we can re-enable

Re: RFR: JDK-8273146: Start of release updates for JDK 19 [v9]

2021-12-06 Thread Joe Darcy
> The time to get JDK 19 underway draws nigh, please review this usual set of > start-of-release updates, including CSRs for the javac and javax.lang.model > updates: > > JDK-8277512: Add SourceVersion.RELEASE_19 > https://bugs.openjdk.java.net/browse/JDK-8277512 > > JDK-8277514: Add source 19

Re: RFR: JDK-8272945: Use snippets in java.compiler documentation

2021-12-06 Thread Jonathan Gibbons
On Fri, 3 Dec 2021 13:47:05 GMT, Erik Joelsson wrote: >> make/modules/java.compiler/Java.gmk line 30: >> >>> 28: >>> 29: EXCLUDES += \ >>> 30: javax/tools/snippet-files \ >> >> You can put this just on a single line :-). >> >> And I'm frankly not sure if make is happy about having a trai

Re: RFR: JDK-8272945: Use snippets in java.compiler documentation

2021-12-06 Thread Jonathan Gibbons
On Fri, 3 Dec 2021 00:40:03 GMT, Magnus Ihse Bursie wrote: >> Please review a patch to use snippets in the `java.compiler` documentation, >> instead of a mix of raw HTML and/or `{@code ...}`. The change is just about >> the presentation of the code fragments; there are no changes to the >> no

Re: RFR: JDK-8272945: Use snippets in java.compiler documentation [v2]

2021-12-06 Thread Jonathan Gibbons
> Please review a patch to use snippets in the `java.compiler` documentation, > instead of a mix of raw HTML and/or `{@code ...}`. The change is just about > the presentation of the code fragments; there are no changes to the normative > specifications for the module. > > One of the examples w