Re: RFR: 8280032: Update jib-profiles.js to use JMH 1.34 devkit

2022-01-14 Thread Iris Clark
On Fri, 14 Jan 2022 17:05:45 GMT, Claes Redestad wrote: > Change so that jib users pick up and use the latest JMH devkit. > > Testing: verified locally Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7090

Re: RFR: 8280032: Update jib-profiles.js to use JMH 1.34 devkit

2022-01-14 Thread Erik Joelsson
On Fri, 14 Jan 2022 17:05:45 GMT, Claes Redestad wrote: > Change so that jib users pick up and use the latest JMH devkit. > > Testing: verified locally Marked as reviewed by erikj (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7090

RFR: 8280032: Update jib-profiles.js to use JMH 1.34 devkit

2022-01-14 Thread Claes Redestad
Change so that jib users pick up and use the latest JMH devkit. Testing: verified locally - Commit messages: - Update jib-profile to use JMH 1.34 Changes: https://git.openjdk.java.net/jdk/pull/7090/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=7090&range=00 Issue:

Re: RFR: 8203290: [PPC64, s390] Check functionality of JDK-8199712 (Flight Recorder) [v8]

2022-01-14 Thread Tyler Steele
On Wed, 12 Jan 2022 15:18:46 GMT, Tyler Steele wrote: >> Just in time for the holidays I have completed an implementation of the JFR >> functionality for AIX. As a side note, this is my first submission to >> OpenJDK ๐Ÿ‘‹ >> >> ### Implementation notes and alternatives considered >> >> After mod

Re: RFR: 8203290: [PPC64, s390] Check functionality of JDK-8199712 (Flight Recorder) [v7]

2022-01-14 Thread Erik Gahlin
On Fri, 14 Jan 2022 16:18:37 GMT, Tyler Steele wrote: > > I'm looking for some clarification on the purpose > > TestNativeLibrariesEvent.java. Currently it fails with "Missing > > libraries:libjvm.so, libjava.so, libzip.so: expected true, was false". I > > find those libs in my build directory

Re: RFR: 8203290: [PPC64, s390] Check functionality of JDK-8199712 (Flight Recorder) [v7]

2022-01-14 Thread Tyler Steele
On Tue, 11 Jan 2022 16:56:15 GMT, Tyler Steele wrote: > I'm looking for some clarification on the purpose > TestNativeLibrariesEvent.java. Currently it fails with "Missing > libraries:libjvm.so, libjava.so, libzip.so: expected true, was false". I find > those libs in my build directory, and ev

Re: RFR: 8203290: [PPC64, s390] Check functionality of JDK-8199712 (Flight Recorder) [v8]

2022-01-14 Thread Tyler Steele
On Wed, 12 Jan 2022 15:18:46 GMT, Tyler Steele wrote: >> Just in time for the holidays I have completed an implementation of the JFR >> functionality for AIX. As a side note, this is my first submission to >> OpenJDK ๐Ÿ‘‹ >> >> ### Implementation notes and alternatives considered >> >> After mod

Re: RFR: 8258240: make vscode-project on Windows generates jdk.code-workspace file with unescaped '\' in paths

2022-01-14 Thread Erik Joelsson
On Fri, 14 Jan 2022 13:45:51 GMT, Daniel Jelinski wrote: > Backslashes in `sed` replacement string are interpreted by `sed`. In order to > output the strings we want, the replacement text needs to be escaped again. > See https://stackoverflow.com/a/2705678 > > Verified that with this patch VSC

[jdk18] Integrated: 8279702: [macosx] ignore xcodebuild warnings on M1

2022-01-14 Thread Johannes Bechberger
On Wed, 12 Jan 2022 09:42:07 GMT, Johannes Bechberger wrote: > Simple change to `make/autoconf/toolchain.m4` to fix the bug as described in > its title and description. This pull request has now been integrated. Changeset: 4b520f00 Author:Johannes Bechberger Committer: Christoph Langer

RFR: 8258240: make vscode-project on Windows generates jdk.code-workspace file with unescaped '\' in paths

2022-01-14 Thread Daniel Jelinski
Backslashes in `sed` replacement string are interpreted by `sed`. In order to output the strings we want, the replacement text needs to be escaped again. See https://stackoverflow.com/a/2705678 Verified that with this patch VSCode is able to open the workspace, and all files are visible in "Exp

Re: [jdk18] RFR: 8279702: [macosx] ignore xcodebuild warnings on M1

2022-01-14 Thread Erik Joelsson
On Wed, 12 Jan 2022 09:42:07 GMT, Johannes Bechberger wrote: > Simple change to `make/autoconf/toolchain.m4` to fix the bug as described in > its title and description. Marked as reviewed by erikj (Reviewer). - PR: https://git.openjdk.java.net/jdk18/pull/95

Re: [jdk18] RFR: 8279702: [macosx] ignore xcodebuild warnings on M1

2022-01-14 Thread Andrew Haley
On Fri, 14 Jan 2022 09:18:43 GMT, Johannes Bechberger wrote: >> make/autoconf/toolchain.m4 line 237: >> >>> 235: if test -n "$XCODEBUILD"; then >>> 236: # On Mac OS X, default toolchain to clang after Xcode 5 >>> 237: XCODE_VERSION_OUTPUT=`"$XCODEBUILD" -version 2>&1 | $HEAD -n

Re: Heads up: planned Harfbuzz update in jdk11u-dev

2022-01-14 Thread Severin Gehwolf
On Fri, 2022-01-14 at 09:19 +, Baesken, Matthias wrote: > For one of the next jdk11 updates, an update to a more recent harfbuzz > version is planned. > This has been done already in jdk/jdk some time ago, and was backported > recently to jdk13, > please see the harfbuzz 2.7.2 / 2.8.0 related

Re: [jdk18] RFR: 8279702: [macosx] ignore xcodebuild warnings on M1

2022-01-14 Thread Johannes Bechberger
On Fri, 14 Jan 2022 09:06:47 GMT, Andrew Haley wrote: >> Simple change to `make/autoconf/toolchain.m4` to fix the bug as described in >> its title and description. > > make/autoconf/toolchain.m4 line 237: > >> 235: if test -n "$XCODEBUILD"; then >> 236: # On Mac OS X, default toolchai

Re: [jdk18] RFR: 8279702: [macosx] ignore xcodebuild warnings on M1

2022-01-14 Thread Andrew Haley
On Wed, 12 Jan 2022 09:42:07 GMT, Johannes Bechberger wrote: > Simple change to `make/autoconf/toolchain.m4` to fix the bug as described in > its title and description. make/autoconf/toolchain.m4 line 237: > 235: if test -n "$XCODEBUILD"; then > 236: # On Mac OS X, default toolchain

Re: [jdk18] RFR: 8279702: [macosx] ignore xcodebuild warnings on M1

2022-01-14 Thread Johannes Bechberger
On Fri, 14 Jan 2022 07:47:19 GMT, Christoph Langer wrote: >> Simple change to `make/autoconf/toolchain.m4` to fix the bug as described in >> its title and description. > > Youโ€™re too quick. This needs a review from somebody in the build group. @RealCLanger thanks, I'm new to the process. -