Re: Segfault when building openjdk13 with openjdk12

2022-02-01 Thread David Holmes
On 2/02/2022 3:53 pm, Abigail G wrote: On Wed, 2022-02-02 at 15:48 +1000, David Holmes wrote: Hi Abigail, On 2/02/2022 3:01 pm, Abigail G wrote: Hello, I'm working on packaging several openjdk versions for Void Linux. When I build jdk13 with jdk12 as the boot jdk, I get a segfault very soon

Re: Segfault when building openjdk13 with openjdk12

2022-02-01 Thread Abigail G
On Wed, 2022-02-02 at 15:48 +1000, David Holmes wrote: > Hi Abigail, > > On 2/02/2022 3:01 pm, Abigail G wrote: > > Hello, > > > > I'm working on packaging several openjdk versions for Void Linux. > > > > When I build jdk13 with jdk12 as the boot jdk, I get a segfault > > very > > soon into the

Re: Segfault when building openjdk13 with openjdk12

2022-02-01 Thread David Holmes
Hi Abigail, On 2/02/2022 3:01 pm, Abigail G wrote: Hello, I'm working on packaging several openjdk versions for Void Linux. When I build jdk13 with jdk12 as the boot jdk, I get a segfault very soon into the build. I am not a java developer, so I'm not quite sure what to make of the log, trace,

Re: RFR: 8203290: [PPC64, s390] Check functionality of JDK-8199712 (Flight Recorder) [v16]

2022-02-01 Thread Tyler Steele
On Sat, 29 Jan 2022 06:51:59 GMT, Thomas Stuefe wrote: >> Tyler Steele has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Changes macoss -> macosx in problem list >> - Refactors loadlib_aix: Removes redundant c++ class > > src/hotspot/os

Re: RFR: 8203290: [PPC64, s390] Check functionality of JDK-8199712 (Flight Recorder) [v17]

2022-02-01 Thread Tyler Steele
> Just in time for the holidays I have completed an implementation of the JFR > functionality for AIX. As a side note, this is my first submission to OpenJDK > 👋 > > ### Implementation notes and alternatives considered > > After modifying the build system to allow the --enable-jvm-feature-jfr t

Re: RFR: 8277204: Implementation of JEP 8264130: PAC-RET protection for Linux/AArch64 [v14]

2022-02-01 Thread Andrew Haley
On Tue, 1 Feb 2022 12:42:26 GMT, David Holmes wrote: >> As per this conversation: >> https://github.com/openjdk/jdk/pull/6334#discussion_r791722292 >> >> The idea was, the user is explicitly asking for asking for pac-ret so we >> should honour that. Whereas standard would only enable what is s

Re: RFR: 8277204: Implementation of JEP 8264130: PAC-RET protection for Linux/AArch64 [v14]

2022-02-01 Thread Andrew Haley
On Mon, 31 Jan 2022 22:25:38 GMT, David Holmes wrote: >> Alan Hayward has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix popframe failures > > src/hotspot/cpu/aarch64/vm_version_aarch64.cpp line 417: > >> 415: // Enable PAC if this

Re: RFR: 8242181: [Linux] Show source information when printing native stack traces in hs_err files

2022-02-01 Thread Christian Hagedorn
On Mon, 31 Jan 2022 22:12:30 GMT, David Holmes wrote: > Hi Christian, > > Sorry for the delay in coming back to this, I wanted to see what other > feedback arose. No problem, thanks for your feedback David! > > > That's a valid concern. I've also asked myself this question when I had > > > i

Re: RFR: 8277204: Implementation of JEP 8264130: PAC-RET protection for Linux/AArch64 [v14]

2022-02-01 Thread Alan Hayward
On Tue, 1 Feb 2022 12:42:26 GMT, David Holmes wrote: >> As per this conversation: >> https://github.com/openjdk/jdk/pull/6334#discussion_r791722292 >> >> The idea was, the user is explicitly asking for asking for pac-ret so we >> should honour that. Whereas standard would only enable what is s

Re: RFR: 8277204: Implementation of JEP 8264130: PAC-RET protection for Linux/AArch64 [v14]

2022-02-01 Thread David Holmes
On Tue, 1 Feb 2022 11:05:46 GMT, Alan Hayward wrote: >> src/hotspot/cpu/aarch64/vm_version_aarch64.cpp line 429: >> >>> 427: #else >>> 428: warning("UseROPProtection specified, but not supported in the >>> VM."); >>> 429: #endif >> >> If we issue these warnings should `_rop_protection` sti

Re: RFR: 8277204: Implementation of JEP 8264130: PAC-RET protection for Linux/AArch64 [v14]

2022-02-01 Thread Alan Hayward
On Mon, 31 Jan 2022 22:35:35 GMT, David Holmes wrote: >> Alan Hayward has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix popframe failures > > src/hotspot/cpu/aarch64/vm_version_aarch64.cpp line 429: > >> 427: #else >> 428: warning