Re: RFR: 8282657: Code cleanup: removing double semicolons at the end of lines

On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote: > Hi > > I have reviewed the code for removing double semicolons at the end of lines > > all the best > matteo This PR changes a comment in javax/swing/RepaintManager.java. This commented out code should be removed altogether in another P

Re: RFR: 8282657: Code cleanup: removing double semicolons at the end of lines

On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote: > Hi > > I have reviewed the code for removing double semicolons at the end of lines > > all the best > matteo Nice, good work matteo Should I change the JBS issue title to match the PR title, or is it preferred for the PR title to chang

Re: RFR: 8282657: Code cleanup: removing double semicolons at the end of lines

On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote: > Hi > > I have reviewed the code for removing double semicolons at the end of lines > > all the best > matteo I eyeballed the diff file and all seems okay. Thanks, David - Marked as reviewed by dholmes (Reviewer). PR: http

Re: RFR: 8282567: Improve source-date handling in build system

On Wed, 2 Mar 2022 18:22:29 GMT, Erik Joelsson wrote: >> When doing reproducible builds, controlling the build time is imperative. To >> make this as easy as possible, some changes are needed in the build system. >> >> * If source-date is set to anything other than "updated" (meaning that it

Re: RFR: 8282567: Improve source-date handling in build system [v4]

On Fri, 4 Mar 2022 23:33:46 GMT, Magnus Ihse Bursie wrote: >> When doing reproducible builds, controlling the build time is imperative. To >> make this as easy as possible, some changes are needed in the build system. >> >> * If source-date is set to anything other than "updated" (meaning that

Re: RFR: 8282567: Improve source-date handling in build system

On Wed, 2 Mar 2022 18:09:58 GMT, Severin Gehwolf wrote: >> To clarify, the end effect of these changes is that building OpenJDK will >> basically be compliant with the method of just setting SOURCE_DATE_EPOCH. >> (The caveat is that it must be set at configure time, not build time.) So >> >> $

Re: RFR: 8282567: Improve source-date handling in build system [v4]

> When doing reproducible builds, controlling the build time is imperative. To > make this as easy as possible, some changes are needed in the build system. > > * If source-date is set to anything other than "updated" (meaning that it > should be determined at build time), then the default valu

Re: RFR: 8282567: Improve source-date handling in build system [v3]

> When doing reproducible builds, controlling the build time is imperative. To > make this as easy as possible, some changes are needed in the build system. > > * If source-date is set to anything other than "updated" (meaning that it > should be determined at build time), then the default valu

Re: RFR: 8282567: Improve source-date handling in build system [v2]

> When doing reproducible builds, controlling the build time is imperative. To > make this as easy as possible, some changes are needed in the build system. > > * If source-date is set to anything other than "updated" (meaning that it > should be determined at build time), then the default valu

Re: RFR: 8282657: Code cleanup: removing double semicolons at the end of lines

On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote: > Hi > > I have reviewed the code for removing double semicolons at the end of lines > > all the best > matteo Marked as reviewed by darcy (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7268

Re: RFR: 8282657: Code cleanup: removing double semicolons at the end of lines

On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote: > Hi > > I have reviewed the code for removing double semicolons at the end of lines > > all the best > matteo LGTM also. Similar suggestion for updating copyrights. - Marked as reviewed by wetmore (Reviewer). PR: https:/

Re: RFR: 8282657: Code cleanup: removing double semicolons at the end of lines

On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote: > Hi > > I have reviewed the code for removing double semicolons at the end of lines > > all the best > matteo Nice tidy of the code. Is there anything that can be done to prevent re-introduction of this trivial problem? Perhaps a new S

Re: RFR: 8282657: Code cleanup: removing double semicolons at the end of lines

On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote: > Hi > > I have reviewed the code for removing double semicolons at the end of lines > > all the best > matteo Marked as reviewed by rriggs (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7268

Re: RFR: 8282657: Code cleanup: removing double semicolons at the end of lines

On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote: > Hi > > I have reviewed the code for removing double semicolons at the end of lines > > all the best > matteo Marked as reviewed by prr (Reviewer). Looks like there's only one client source code file touched Most of the client changes a

Re: RFR: 8282657: Code cleanup: removing double semicolons at the end of lines

On Fri, 4 Mar 2022 17:17:12 GMT, Roger Riggs wrote: >> Hi >> >> I have reviewed the code for removing double semicolons at the end of lines >> >> all the best >> matteo > > We usually request that these be be broken up by area to attract the > appropriate reviewers and avoid eye-strain. The c

Re: RFR: 8282657: Code cleanup: removing double semicolons at the end of lines

On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote: > Hi > > I have reviewed the code for removing double semicolons at the end of lines > > all the best > matteo We usually request that these be be broken up by area to attract the appropriate reviewers and avoid eye-strain. The client mo

Re: RFR: 8282657: Code cleanup: removing double semicolons at the end of lines

On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote: > Hi > > I have reviewed the code for removing double semicolons at the end of lines > > all the best > matteo Hi Lance I can make a second commit updating the copyright year Tell me if this is necessary ciao matteo - PR:

Re: RFR: 8282657: Code cleanup: removing double semicolons at the end of lines

On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote: > Hi > > I have reviewed the code for removing double semicolons at the end of lines > > all the best > matteo The changes look OK. The copyright year probably should be updated as part of this PR - Marked as reviewed by la

Re: RFR: 8282657: Code cleanup: removing double semicolons at the end of lines

On Fri, 25 Feb 2022 15:40:09 GMT, Matteo Baccan wrote: >> Hi >> >> I have reviewed the code for removing double semicolons at the end of lines >> >> all the best >> matteo > > Hi > > I have pushed this PR about 1 month ago. Only 3 days ago OCA was accepted. > Now: what is the next step? > > T

RFR: 8282657: Code cleanup: removing double semicolons at the end of lines

Hi I have reviewed the code for removing double semicolons at the end of lines all the best matteo - Commit messages: - Removed double semicolon at the end of lines Changes: https://git.openjdk.java.net/jdk/pull/7268/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=726

Re: RFR: 8282657: Code cleanup: removing double semicolons at the end of lines

On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote: > Hi > > I have reviewed the code for removing double semicolons at the end of lines > > all the best > matteo Hi I have pushed this PR about 1 month ago. Only 3 days ago OCA was accepted. Now: what is the next step? This is a cleanup PR

Integrated: 8252769: Warn in configure if git config autocrlf has invalid value

On Fri, 4 Mar 2022 12:00:15 GMT, Magnus Ihse Bursie wrote: > Over and over again, people are running into issues when their git config has > core.autocrlf set to true or input. (This is apparently done by default by > some Windows git installations.) > > This will not work with the OpenJDK bui

Re:

Hi Eric, I see, sorry for the misunderstanding. I'm not sure if there's any practical implementation for this either, but I'll look into it more anyway best regards, Julian On Sat, Mar 5, 2022 at 12:02 AM wrote: > Hello Julian, > > You are misunderstanding Magnus here. What he means is that we

Re:

Hello Julian, You are misunderstanding Magnus here. What he means is that we are compiling the version numbers into Java classes and native libraries (through generating Java source files with the version information in them and by setting -D flags when compiling C/C++). Because of this, if w

[no subject]

Hi Magnus, While looking through the now resolved JDK-8274980 one discussed possibility in particular caught my eye: "The one thing remaining now to make me fully happy wrt version numbers, is if we could stop hard-coding them into files during bu

Re: RFR: 8252769: Warn in configure if git config autocrlf has invalid value

On Fri, 4 Mar 2022 12:00:15 GMT, Magnus Ihse Bursie wrote: > Over and over again, people are running into issues when their git config has > core.autocrlf set to true or input. (This is apparently done by default by > some Windows git installations.) > > This will not work with the OpenJDK bui

RFR: 8257589: HotSpot Style Guide should link to rfc7282

Please review this change to the link for the definition of "rough consensus". The current link is to a Wikipedia article that references rfc7282. We should instead link directly the the RFC. This change was requested during the review of JDK-8247976, but not made at that time. (I'm not sure whet

RFR: 8252577: HotSpot Style Guide should link to One-True-Brace-Style description

Please review this change to provide a link to the Wikipedia description of One-True-Brace-Style. As this is a HotSpot Style Guide change, it requires reviewers who are HotSpot Group Members, though comments from others are welcome. - Commit messages: - update html - add OTBS link

Integrated: JDK-8282532: Allow explicitly setting build platform alongside --openjdk-target

On Wed, 2 Mar 2022 08:11:51 GMT, Julian Waters wrote: > Currently the only other option for manually configuring the build platform > while cross compiling are devkits, which don't work on certain systems and > are also more focused on differentiating the build and target compilers > instead.

RFR: 8252769: Warn in configure if git config autocrlf has invalid value

Over and over again, people are running into issues when their git config has core.autocrlf set to true or input. (This is apparently done by default by some Windows git installations.) This will not work with the OpenJDK build system. We should check this at configure time and give suitable wa

Re: RFR: JDK-8282532: Allow explicitly setting build platform alongside --openjdk-target [v11]

On Fri, 4 Mar 2022 11:48:14 GMT, Julian Waters wrote: >> Currently the only other option for manually configuring the build platform >> while cross compiling are devkits, which don't work on certain systems and >> are also more focused on differentiating the build and target compilers >> inste

Re: configure misses check for linux-glibc-devel / linux-headers / kernel-headers ?

On 3/4/22 12:41, Baesken, Matthias wrote: Hi Aleksey I did not use a devkit, just installed gcc/g++ on the Alpine docker image I used . Maybe that's why I do not see this help output you added ? That might be the key. I remember testing this with vanilla Alpine 3 image. IIRC, configure wou

Re: RFR: JDK-8282532: Allow explicitly setting build platform alongside --openjdk-target [v11]

> Currently the only other option for manually configuring the build platform > while cross compiling are devkits, which don't work on certain systems and > are also more focused on differentiating the build and target compilers > instead. This patch adds the ability to explicitly set the build

RE: configure misses check for linux-glibc-devel / linux-headers / kernel-headers ?

Hi Aleksey I did not use a devkit, just installed gcc/g++ on the Alpine docker image I used . Maybe that's why I do not see this help output you added ? Best regards, Matthias >> Hi , while attempting to build jdk on an Alpine Linux I was running into the >> following issue : >> After some

Re: RFR: JDK-8282532: Allow explicitly setting build platform alongside --openjdk-target [v10]

On Fri, 4 Mar 2022 07:51:36 GMT, Julian Waters wrote: >> Currently the only other option for manually configuring the build platform >> while cross compiling are devkits, which don't work on certain systems and >> are also more focused on differentiating the build and target compilers >> inste

Re: RFR: JDK-8282532: Allow explicitly setting build platform alongside --openjdk-target [v10]

On Fri, 4 Mar 2022 07:51:36 GMT, Julian Waters wrote: >> Currently the only other option for manually configuring the build platform >> while cross compiling are devkits, which don't work on certain systems and >> are also more focused on differentiating the build and target compilers >> inste

Re: configure misses check for linux-glibc-devel / linux-headers / kernel-headers ?

On 3/4/22 10:08, Baesken, Matthias wrote: Hi , while attempting to build jdk on an Alpine Linux I was running into the following issue : After some additional package installations configure was passing successfully , however hotspot build failed with /openjdk_build/jdk_1/jdk/src/hotspot/os/