On Fri, 11 Mar 2022 07:03:00 GMT, David Holmes wrote:
> > Well, he does it for `DumpSharedSpaces` only. Are you really worried about
> > that one load+conditional jump?
>
> As I said (and I'm not the only one who says this :) ) "death by a thousand
> cuts".
Thank you, that is a good
On Thu, 10 Mar 2022 19:34:29 GMT, Ioi Lam wrote:
>> src/hotspot/share/prims/jvm.cpp line 2887:
>>
>>> 2885: return;
>>> 2886: }
>>> 2887: #endif
>>
>> Should we do this for jni_AttachCurrentThread too?
>
> This hasn't been necessary for me because jni_AttachCurrentThread is not
> called
On Fri, 11 Mar 2022 06:55:23 GMT, Ioi Lam wrote:
>> This patch makes the result of "java -Xshare:dump" deterministic:
>> - Disabled new Java threads from launching. This is harmless. See comments
>> in jvm.cpp
>> - Fixed a problem in hashtable ordering in heapShared.cpp
>> - BasicHashtableEntry
On 11/03/2022 4:50 pm, Thomas Stuefe wrote:
On Fri, 11 Mar 2022 05:59:00 GMT, David Holmes wrote:
Thanks for pointing this out. I ran more tests and found that on certain
platforms, there are other structures that have problems with uninitialized
gaps. I ended up changing `os::malloc()` to
> This patch makes the result of "java -Xshare:dump" deterministic:
> - Disabled new Java threads from launching. This is harmless. See comments in
> jvm.cpp
> - Fixed a problem in hashtable ordering in heapShared.cpp
> - BasicHashtableEntry has a gap on 64-bit platforms that may contain random
On Fri, 11 Mar 2022 06:50:00 GMT, David Holmes wrote:
> I can combine the tests for `MemTracker::tracking_level()` and
> `DumpSharedSpaces` into a single test and do more work only when the uncommon
> path is taken. This would require some refactoring of the
> MemTracker/MallocTracker code.
On Fri, 11 Mar 2022 05:59:00 GMT, David Holmes wrote:
> > Thanks for pointing this out. I ran more tests and found that on certain
> > platforms, there are other structures that have problems with uninitialized
> > gaps. I ended up changing `os::malloc()` to zero the buffer when running
> >
On 11/03/2022 4:40 pm, Ioi Lam wrote:
On Fri, 11 Mar 2022 05:59:00 GMT, David Holmes wrote:
I ended up changing `os::malloc()` to zero the buffer when running with
-Xshare:dump. Hopefully one extra check of `if (DumpSharedSpaces)` doesn't
matter too much for regular VM executions because
On Fri, 11 Mar 2022 05:59:00 GMT, David Holmes wrote:
> > I ended up changing `os::malloc()` to zero the buffer when running with
> > -Xshare:dump. Hopefully one extra check of `if (DumpSharedSpaces)` doesn't
> > matter too much for regular VM executions because `os::malloc()` already
> > has
On Fri, 11 Mar 2022 05:55:20 GMT, Kim Barrett wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> zero GC heap filler arrays
>
> src/hotspot/share/gc/shared/collectedHeap.cpp line 449:
>
>> 447:
> This patch makes the result of "java -Xshare:dump" deterministic:
> - Disabled new Java threads from launching. This is harmless. See comments in
> jvm.cpp
> - Fixed a problem in hashtable ordering in heapShared.cpp
> - BasicHashtableEntry has a gap on 64-bit platforms that may contain random
On Fri, 11 Mar 2022 04:56:23 GMT, Ioi Lam wrote:
>> This patch makes the result of "java -Xshare:dump" deterministic:
>> - Disabled new Java threads from launching. This is harmless. See comments
>> in jvm.cpp
>> - Fixed a problem in hashtable ordering in heapShared.cpp
>> - BasicHashtableEntry
I can't find this comment in the PR so replying via email ...
On 11/03/2022 9:24 am, Ioi Lam wrote:
On Wed, 9 Mar 2022 07:47:19 GMT, Thomas Stuefe wrote:
Ioi Lam has updated the pull request incrementally with one additional commit
since the last revision:
Fixed zero build
> Some of the --without options are not properly handled and will crash when
> processed (For example, --without-version-string), in other cases the
> --without-* option will actually silently produce incorrect results instead
> of actually doing what --without-* implies (For example,
> This patch makes the result of "java -Xshare:dump" deterministic:
> - Disabled new Java threads from launching. This is harmless. See comments in
> jvm.cpp
> - Fixed a problem in hashtable ordering in heapShared.cpp
> - BasicHashtableEntry has a gap on 64-bit platforms that may contain random
On Tue, 1 Mar 2022 20:18:11 GMT, Man Cao wrote:
> Hi all,
>
> Could anyone help review the addition of LICENSE file to hsdis directory?
>
> -Man
Thank you for pointing out the difference between hsdis and other 3rd party
code.
> src/java.desktop/share/native/libsplashscreen/libpng/LICENSE
On Tue, 1 Mar 2022 20:18:11 GMT, Man Cao wrote:
> Hi all,
>
> Could anyone help review the addition of LICENSE file to hsdis directory?
>
> -Man
But those are licenses for 3rd party code which we have incorporated.
hsdis is written by us. We have just chosen a different license to distribute
On Tue, 1 Mar 2022 20:18:11 GMT, Man Cao wrote:
> Hi all,
>
> Could anyone help review the addition of LICENSE file to hsdis directory?
>
> -Man
The consistency is to have the license information in its own file, like other
3rd party code in OpenJDK. There two ways:
- Add a LICENSE file or a
> This patch makes the result of "java -Xshare:dump" deterministic:
> - Disabled new Java threads from launching. This is harmless. See comments in
> jvm.cpp
> - Fixed a problem in hashtable ordering in heapShared.cpp
> - BasicHashtableEntry has a gap on 64-bit platforms that may contain random
On Wed, 9 Mar 2022 07:47:19 GMT, Thomas Stuefe wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed zero build
>
> src/hotspot/share/utilities/hashtable.hpp line 42:
>
>> 40:
>> 41: LP64_ONLY(unsigned int _gap;)
On Thu, 10 Mar 2022 14:32:31 GMT, Julian Waters wrote:
>> Some of the --without options are not properly handled and will crash when
>> processed (For example, --without-version-string), in other cases the
>> --without-* option will actually silently produce incorrect results instead
>> of
On Thu, 10 Mar 2022 11:09:55 GMT, George Adams wrote:
>> Adds Alpine build CI job to the GitHub actions submit.yml. I can add tests
>> too if people think that would be useful but for now I've left it as just
>> build.
>
> George Adams has refreshed the contents of this pull request, and
On Tue, 1 Mar 2022 20:18:11 GMT, Man Cao wrote:
> Hi all,
>
> Could anyone help review the addition of LICENSE file to hsdis directory?
>
> -Man
When you say your change "makes hsdis's license structure consistent with other
licenses in OpenJDK", what do you mean by that?
If we had random
On Tue, 1 Mar 2022 20:18:11 GMT, Man Cao wrote:
> Hi all,
>
> Could anyone help review the addition of LICENSE file to hsdis directory?
>
> -Man
The context is that Google have an automated check for license compliance for
all imported open-source software. We (Java platform team) have to
On Thu, 10 Mar 2022 19:41:03 GMT, Ioi Lam wrote:
>> I think he already did. I'm quoting:
>>
>>> However, the CDS archive also contains a heap dump, which includes Java
>>> HashMaps. If I allow those 3 Java threads to start, some HashMaps in the
>>> module graph will have unstable ordering. I
On Thu, 10 Mar 2022 13:51:56 GMT, Magnus Ihse Bursie wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed zero build
>
> I think he already did. I'm quoting:
>
>> However, the CDS archive also contains a heap dump,
On Wed, 9 Mar 2022 07:51:46 GMT, Thomas Stuefe wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed zero build
>
> src/hotspot/share/prims/jvm.cpp line 2887:
>
>> 2885: return;
>> 2886: }
>> 2887: #endif
>
>
On Thu, 10 Mar 2022 13:51:56 GMT, Magnus Ihse Bursie wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed zero build
>
> I think he already did. I'm quoting:
>
>> However, the CDS archive also contains a heap dump,
On Thu, 10 Mar 2022 12:44:07 GMT, Magnus Ihse Bursie wrote:
> Do you need to test the entire JDK, or just hotspot?
We could get away with just testing hotspot, I would reiterate my previous
comments though around ramping down some of the Linux x86 testing if you're
concerned about executor
> Some of the --without options are not properly handled and will crash when
> processed (For example, --without-version-string), in other cases the
> --without-* option will actually silently produce incorrect results instead
> of actually doing what --without-* implies (For example,
On Thu, 10 Mar 2022 11:49:06 GMT, Magnus Ihse Bursie wrote:
> If VERSION_BUILD is empty, we must still store a "0" in
> MACOSX_BUNDLE_BUILD_VERSION.
This pull request has now been integrated.
Changeset: 9c88c5bb
Author:Magnus Ihse Bursie
URL:
On Wed, 9 Mar 2022 05:10:44 GMT, Ioi Lam wrote:
>> This patch makes the result of "java -Xshare:dump" deterministic:
>> - Disabled new Java threads from launching. This is harmless. See comments
>> in jvm.cpp
>> - Fixed a problem in hashtable ordering in heapShared.cpp
>> - BasicHashtableEntry
On Thu, 10 Mar 2022 11:49:06 GMT, Magnus Ihse Bursie wrote:
> If VERSION_BUILD is empty, we must still store a "0" in
> MACOSX_BUNDLE_BUILD_VERSION.
Marked as reviewed by erikj (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/7773
On Thu, 10 Mar 2022 12:50:58 GMT, Magnus Ihse Bursie wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed zero build
>
> Well, previously we'd get different dumps on different runs. If that was an
> issue, surely it
The Skara bots messed up this one badly. It was a reply to David's
comment, not Ioi's latest push.
/Magnus
On 2022-03-10 13:56, Magnus Ihse Bursie wrote:
On Wed, 9 Mar 2022 05:10:44 GMT, Ioi Lam wrote:
This patch makes the result of "java -Xshare:dump" deterministic:
- Disabled new Java
On Wed, 9 Mar 2022 07:58:51 GMT, Thomas Stuefe wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed zero build
>
> Hi Ioi,
>
> some questions, comments inline.
>
> Like David in the comments, I am also a bit vague
On Wed, 9 Mar 2022 05:10:44 GMT, Ioi Lam wrote:
>> This patch makes the result of "java -Xshare:dump" deterministic:
>> - Disabled new Java threads from launching. This is harmless. See comments
>> in jvm.cpp
>> - Fixed a problem in hashtable ordering in heapShared.cpp
>> - BasicHashtableEntry
On Thu, 10 Mar 2022 12:11:06 GMT, Magnus Ihse Bursie wrote:
>> The "heap dump" aspect of this is not something I'm familiar with, but if
>> the threads don't affect the list of classes dumped, they surely must affect
>> what is in the heap dump otherwise their execution would not be an issue.
On Thu, 10 Mar 2022 12:42:09 GMT, Julian Waters wrote:
>> It's in make/conf/branding.conf.
>
> I don't see a VENDOR_VERSION_STRING in there though, all vendor related
> defaults I could find are
> COMPANY_NAME=N/A
> VENDOR_URL=https://openjdk.java.net/
>
On Thu, 10 Mar 2022 11:09:55 GMT, George Adams wrote:
>> Adds Alpine build CI job to the GitHub actions submit.yml. I can add tests
>> too if people think that would be useful but for now I've left it as just
>> build.
>
> George Adams has refreshed the contents of this pull request, and
On Thu, 10 Mar 2022 11:54:13 GMT, Magnus Ihse Bursie wrote:
>> I treated this differently since it didn't seem to have any default value at
>> all, as opposed to the other vendor options. I may have made a mistake while
>> looking for where the vendor version string is defined in this case
>
>
On Thu, 10 Mar 2022 11:57:13 GMT, Magnus Ihse Bursie wrote:
>> Got it, should I link JDK-8282948 into this PR while addressing this issue
>> in the meantime?
>> (On a side note the macOS tier 1 tests are also failing after this change,
>> so you may be right that the build will inevitably fail
On Thu, 10 Mar 2022 12:27:56 GMT, Magnus Ihse Bursie wrote:
> While to code itself looks like its doing what it claims to do, I wonder
> about the reason for doing this. This will slurp up even more CPU minutes
> from the individual OpenJDK contributors free GitHub allowance, and
>
On Thu, 10 Mar 2022 11:09:55 GMT, George Adams wrote:
>> Adds Alpine build CI job to the GitHub actions submit.yml. I can add tests
>> too if people think that would be useful but for now I've left it as just
>> build.
>
> George Adams has refreshed the contents of this pull request, and
On Wed, 9 Mar 2022 11:45:59 GMT, David Holmes wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed zero build
>
> The "heap dump" aspect of this is not something I'm familiar with, but if the
> threads don't affect
On Thu, 10 Mar 2022 10:31:17 GMT, Julian Waters wrote:
>> make/autoconf/jdk-version.m4 line 507:
>>
>>> 505: # Set vendor version string if --without is not passed
>>> 506: # Check not required if an empty value is passed, since
>>> VENDOR_VERSION_STRING
>>> 507: # would then be
On Thu, 10 Mar 2022 11:49:14 GMT, Julian Waters wrote:
>> Ok, now I've tried to dig through Apple's somewhat confusing documentation
>> on CFBundleVersion and CFBundleShortVersionString. My takeaway is that we
>> should either publish the build number there, or 0 if we have no build
>>
On Thu, 10 Mar 2022 05:35:39 GMT, Man Cao wrote:
>> Hi all,
>>
>> Could anyone help review the addition of LICENSE file to hsdis directory?
>>
>> -Man
>
> Any updates on whether this is acceptable?
@caoman No, I have not gotten any replies. I also fully agree with @theRealAph,
that this
If VERSION_BUILD is empty, we must still store a "0" in
MACOSX_BUNDLE_BUILD_VERSION.
-
Commit messages:
- 8282948: JDK-8274980 missed correct handling of MACOSX_BUNDLE_BUILD_VERSION
Changes: https://git.openjdk.java.net/jdk/pull/7773/files
Webrev:
On Thu, 10 Mar 2022 11:42:05 GMT, Magnus Ihse Bursie wrote:
>> Both version build and version opt have valid --without options though, if
>> both are set (As in the case of an adhoc build run with
>> --without-version-opt) that could be problematic, since the issue wouldn't
>> be stemming
On Thu, 10 Mar 2022 10:28:30 GMT, Julian Waters wrote:
>> That might be. If that is so, then you've most likely spotted a bug. In
>> practice, you're either building an official build and have a build number,
>> or an adhoc build with an opt string, so I'm not suprised noone has run into
>>
On Thu, 10 Mar 2022 05:35:39 GMT, Man Cao wrote:
> Any updates on whether this is acceptable?
What is the point of this change? It'd require legal inspection, and as far as
I can tell there is no point.
-
PR: https://git.openjdk.java.net/jdk/pull/7649
On Wed, 9 Mar 2022 07:58:51 GMT, Thomas Stuefe wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed zero build
>
> Hi Ioi,
>
> some questions, comments inline.
>
> Like David in the comments, I am also a bit vague
> Adds Alpine build CI job to the GitHub actions submit.yml. I can add tests
> too if people think that would be useful but for now I've left it as just
> build.
George Adams has refreshed the contents of this pull request, and previous
commits have been removed. The incremental views will
> Adds Alpine build CI job to the GitHub actions submit.yml. I can add tests
> too if people think that would be useful but for now I've left it as just
> build.
George Adams has updated the pull request incrementally with one additional
commit since the last revision:
change upload bundle
On Thu, 10 Mar 2022 09:40:13 GMT, Magnus Ihse Bursie wrote:
>> Julian Waters has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix syntax errors
>
> make/autoconf/jdk-version.m4 line 507:
>
>> 505: # Set vendor version string if
On Thu, 10 Mar 2022 09:58:29 GMT, Magnus Ihse Bursie wrote:
>> From what I can tell, wouldn't MACOSX_BUNDLE_BUILD_VERSION be an empty
>> string anyway if both VERSION_BUILD and VERSION_OPT = ""?
>
> That might be. If that is so, then you've most likely spotted a bug. In
> practice, you're
Adds Alpine build CI job to the GitHub actions submit.yml. I can add tests too
if people think that would be useful but for now I've left it as just build.
-
Commit messages:
- fix sha256 command
- add alpine github action
Changes: https://git.openjdk.java.net/jdk/pull/7771/files
On Thu, 10 Mar 2022 09:48:52 GMT, Julian Waters wrote:
>> make/autoconf/jdk-version.m4 line 554:
>>
>>> 552: elif test "x$with_macosx_bundle_build_version" = xno; then
>>> 553: # Interpret --without-* as empty string instead of the literal "no"
>>> 554: MACOSX_BUNDLE_BUILD_VERSION=
>>
On Thu, 10 Mar 2022 09:41:32 GMT, Magnus Ihse Bursie wrote:
>> Julian Waters has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix syntax errors
>
> make/autoconf/jdk-version.m4 line 554:
>
>> 552: elif test
On Thu, 10 Mar 2022 09:17:16 GMT, Julian Waters wrote:
>> Some of the --without options are not properly handled and will crash when
>> processed (For example, --without-version-string), in other cases the
>> --without-* option will actually silently produce incorrect results instead
>> of
> Some of the --without options are not properly handled and will crash when
> processed (For example, --without-version-string), in other cases the
> --without-* option will actually silently produce incorrect results instead
> of actually doing what --without-* implies (For example,
> Some of the --without options are not properly handled and will crash when
> processed (For example, --without-version-string), in other cases the
> --without-* option will actually silently produce incorrect results instead
> of actually doing what --without-* implies (For example,
63 matches
Mail list logo
