Re: RFR: 8285630: Fix a configure error in RISC-V cross build

2022-04-27 Thread Feilong Jiang
On Wed, 27 Apr 2022 09:50:35 GMT, Pengfei Li wrote: > We are trying to cross build a RISC-V version of OpenJDK. We specified > `--openjdk-target=riscv64-linux-gnu` after `bash configure` but got an > error message. > > > configure: error: /usr/bin/bash > /home/ent-user/jdk_src/make/autoconf/bu

Re: RFR: 8285630: Fix a configure error in RISC-V cross build

2022-04-27 Thread Fei Yang
On Wed, 27 Apr 2022 09:50:35 GMT, Pengfei Li wrote: > We are trying to cross build a RISC-V version of OpenJDK. We specified > `--openjdk-target=riscv64-linux-gnu` after `bash configure` but got an > error message. > > > configure: error: /usr/bin/bash > /home/ent-user/jdk_src/make/autoconf/bu

Re: RFR: JDK-8285730: unify _WIN32_WINNT settings

2022-04-27 Thread David Holmes
On Wed, 27 Apr 2022 14:57:41 GMT, Matthias Baesken wrote: > Currently we set _WIN32_WINNT at various places in the codebase; this is used > to target a minimum Windows version we want to support. See also for more > detailled information : > https://docs.microsoft.com/en-us/windows/win32/winpro

Re: RFR: 8285755: JDK-8285093 changed the default for --with-output-sync

2022-04-27 Thread Mikael Vidstedt
On Wed, 27 Apr 2022 19:16:48 GMT, Erik Joelsson wrote: > The make option '--output-sync recurse' can be useful in certain situations, > especially when dealing with very verbose output from makefiles and you want > to parse them after the fact. However, when running make interactively on the >

RFR: 8285755: JDK-8285093 changed the default for --with-output-sync

2022-04-27 Thread Erik Joelsson
The make option '--output-sync recurse' can be useful in certain situations, especially when dealing with very verbose output from makefiles and you want to parse them after the fact. However, when running make interactively on the command line, it certainly gets in the way, as output from each

Re: RFR: JDK-8285730: unify _WIN32_WINNT settings

2022-04-27 Thread Erik Joelsson
On Wed, 27 Apr 2022 14:57:41 GMT, Matthias Baesken wrote: > Currently we set _WIN32_WINNT at various places in the codebase; this is used > to target a minimum Windows version we want to support. See also for more > detailled information : > https://docs.microsoft.com/en-us/windows/win32/winpro

Re: RFR: JDK-8285730: unify _WIN32_WINNT settings

2022-04-27 Thread Phil Race
On Wed, 27 Apr 2022 14:57:41 GMT, Matthias Baesken wrote: > Currently we set _WIN32_WINNT at various places in the codebase; this is used > to target a minimum Windows version we want to support. See also for more > detailled information : > https://docs.microsoft.com/en-us/windows/win32/winpro

Re: build issues with BusyBox tar on Alpine

2022-04-27 Thread erik . joelsson
On 2022-04-27 06:55, Baesken, Matthias wrote: Hi, today I was running into build problems with busybox tar on Alpine Linux . When building “product-bundles” I get : /bin/tar: unrecognized option: I BusyBox v1.34.1 (2022-04-04 10:19:27 UTC) multi-call binary Usage: tar c|x|t [-ZzJjahmvokO]

Re: RFR: 8285630: Fix a configure error in RISC-V cross build

2022-04-27 Thread Erik Joelsson
On Wed, 27 Apr 2022 09:50:35 GMT, Pengfei Li wrote: > We are trying to cross build a RISC-V version of OpenJDK. We specified > `--openjdk-target=riscv64-linux-gnu` after `bash configure` but got an > error message. > > > configure: error: /usr/bin/bash > /home/ent-user/jdk_src/make/autoconf/bu

Integrated: JDK-8236128: Allow jpackage create installers for services

2022-04-27 Thread Alexey Semenyuk
On Fri, 11 Mar 2022 23:37:06 GMT, Alexey Semenyuk wrote: > Implementation of [JDK-8275062: "Allow jpackage create installers for > services"](https://bugs.openjdk.java.net/browse/JDK-8275062) > CSR This pull request has now been integrated. Changeset: b675c597 Author:Alexey Semenyuk URL:

Re: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v33]

2022-04-27 Thread Maurizio Cimadamore
> This PR contains the API and implementation changes for JEP-424 [1]. A more > detailed description of such changes, to avoid repetitions during the review > process, is included as a separate comment. > > [1] - https://openjdk.java.net/jeps/424 Maurizio Cimadamore has updated the pull request

Re: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v32]

2022-04-27 Thread Maurizio Cimadamore
> This PR contains the API and implementation changes for JEP-424 [1]. A more > detailed description of such changes, to avoid repetitions during the review > process, is included as a separate comment. > > [1] - https://openjdk.java.net/jeps/424 Maurizio Cimadamore has updated the pull request

Re: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v31]

2022-04-27 Thread Maurizio Cimadamore
> This PR contains the API and implementation changes for JEP-424 [1]. A more > detailed description of such changes, to avoid repetitions during the review > process, is included as a separate comment. > > [1] - https://openjdk.java.net/jeps/424 Maurizio Cimadamore has updated the pull request

RFR: 8285630: Fix a configure error in RISC-V cross build

2022-04-27 Thread Pengfei Li
We are trying to cross build a RISC-V version of OpenJDK. We specified `--openjdk-target=riscv64-linux-gnu` after `bash configure` but got an error message. configure: error: /usr/bin/bash /home/ent-user/jdk_src/make/autoconf/build-aux/config.sub riscv64-linux-gnu failed configure exiting with

Re: zlib before 1.2.12 allows memory corruption (CVE-2018-25032)

2022-04-27 Thread Volker Simonis
Hi Bernd, Vitaly, Amazon Corretto [1] also includes the fixes for CVE-2018-25032. This is our statement: "Based upon our analysis, OpenJDK/Corretto is not affected by CVE-2018-25032, because the zlib "memLevel" parameter is not settable and is fixed at 8, and the usage of the Z_FIXED strategy is