On Wed, 4 May 2022 03:06:44 GMT, Yasumasa Suenaga wrote:
> We can specify `git` binary via `GIT` in configure script, but it does not
> affect in SourceRevision.gmk .
This pull request has now been integrated.
Changeset: d43ae723
Author:Yasumasa Suenaga
URL:
https://git.openjdk.jav
On Wed, 4 May 2022 23:29:53 GMT, Maurizio Cimadamore
wrote:
>> Good points. Regarding `ClassLoader` being null, I think we can still return
>> something using the `BootLoader`'s `NativeLibraries` object - that would
>> allow this method to be called internally. @mlchung Can you please confirm?
On Wed, 4 May 2022 23:20:21 GMT, Maurizio Cimadamore
wrote:
>> src/java.base/share/classes/java/lang/foreign/SymbolLookup.java line 153:
>>
>>> 151: static SymbolLookup loaderLookup() {
>>> 152: Class caller = Reflection.getCallerClass();
>>> 153: ClassLoader loader =
>>> O
> This PR contains the API and implementation changes for JEP-424 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/424
Maurizio Cimadamore has updated the pull request
On Wed, 4 May 2022 16:47:28 GMT, ExE Boss wrote:
>> Maurizio Cimadamore has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains 57 commits:
>>
>> - Merge branch 'master' into foreign-preview
>> - Update
>> src/java.base/share/classes/j
On Tue, 3 May 2022 10:40:02 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-424 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjdk
On Wed, 4 May 2022 03:06:44 GMT, Yasumasa Suenaga wrote:
> We can specify `git` binary via `GIT` in configure script, but it does not
> affect in SourceRevision.gmk .
Marked as reviewed by erikj (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/8526
On Wed, 4 May 2022 03:06:44 GMT, Yasumasa Suenaga wrote:
> We can specify `git` binary via `GIT` in configure script, but it does not
> affect in SourceRevision.gmk .
LGTM
-
Marked as reviewed by sgehwolf (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/8526
On Wed, 4 May 2022 08:34:43 GMT, David Holmes wrote:
> I'm confused.
> `src\jdk.crypto.mscapi\windows\native\libsunmscapi\security.cpp` doesn't set
> _WIN32_WINNT so how is that later API being enabled? Does this mean that not
> setting _WIN32_WINNT means :any API is allowed" ?
I found this i
On Wed, 4 May 2022 08:00:08 GMT, Matthias Baesken wrote:
>> Currently we set _WIN32_WINNT at various places in the codebase; this is
>> used to target a minimum Windows version we want to support. See also for
>> more detailled information :
>> https://docs.microsoft.com/en-us/windows/win32/win
> Currently we set _WIN32_WINNT at various places in the codebase; this is used
> to target a minimum Windows version we want to support. See also for more
> detailled information :
> https://docs.microsoft.com/en-us/windows/win32/winprog/using-the-windows-headers?redirectedfrom=MSDN#setting-winv
On Tue, 3 May 2022 13:27:41 GMT, David Holmes wrote:
> I agree with Erik - the source locations need to be modified to not define
> it. If we want to keep a record perhaps add an assertion that the value is
> what was expected?
>
> I still feel we have a disconnect between this and an actual c
On Tue, 3 May 2022 07:10:58 GMT, Matthias Baesken wrote:
>> Currently we set _WIN32_WINNT at various places in the codebase; this is
>> used to target a minimum Windows version we want to support. See also for
>> more detailled information :
>> https://docs.microsoft.com/en-us/windows/win32/win
13 matches
Mail list logo
