Re: RFR: 8287366: Improve test failure reporting in GHA

2022-06-06 Thread Magnus Ihse Bursie
On Mon, 6 Jun 2022 12:57:25 GMT, Jaikiran Pai wrote: >> It is currently both tricky and tedious to figure out what went wrong when a >> jtreg test fails in GHA. >> >> We should utilize the full potential of GitHub Action summaries and error >> annotations to make finding failures easier and mo

Re: RFR: 8287745 jni/nullCaller/NullCallerTest.java fails with "exitValue = 1"

2022-06-06 Thread Tim Prinzing
On Mon, 6 Jun 2022 07:45:16 GMT, David Holmes wrote: > Hi Tim, > > Sorry but I have to ask why this test was created as a C++ program instead of > keeping it as a C program likes it predecessors? No need for C++ libs or > special exception handling flags in that case. The idea was to reduce d

Re: RFR: 8287828: Fix so that one can select jtreg test case by ID from make

2022-06-06 Thread Ioi Lam
On Mon, 6 Jun 2022 10:48:05 GMT, David Holmes wrote: > Let me ask the obvious "dumb" question ... why does this have to be so > complicated? Why isn't the name of the test simply passed through to jtreg as > typed? Is it because `#` is treated as comment by the shell? Could it be encoded by s

Re: RFR: 8287811: JFR: jfr configure error message should not print stack trace

2022-06-06 Thread Markus Grönlund
On Fri, 3 Jun 2022 15:54:47 GMT, Erik Gahlin wrote: > Could I have a review of PR that removes a printStackTrace() for the jfr > tool. > > Testing: jdk/jfr/tool > > Thanks > Erik Marked as reviewed by mgronlun (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/9018

Re: RFR: 8287366: Improve test failure reporting in GHA

2022-06-06 Thread Jaikiran Pai
On Thu, 26 May 2022 12:04:41 GMT, Magnus Ihse Bursie wrote: > With this PR, the overview of failures are presented on the "Summary" page > for the action (the top-most line to the left, with the outline house icon). @magicus, thank you. This is really useful. I didn't even know that this "Summ

Re: RFR: 8287828: Fix so that one can select jtreg test case by ID from make

2022-06-06 Thread David Holmes
On Sat, 4 Jun 2022 01:51:20 GMT, Leo Korinth wrote: > One can select a testcase by ID when running a jtreg test case directly from > jtreg (using the testcase.java#testID syntax). However, this has not been > possible to do when launching jtreg indirectly from make. > > This fix attempts to ad

Re: RFR: 8287828: Fix so that one can select jtreg test case by ID from make

2022-06-06 Thread Erik Joelsson
On Sat, 4 Jun 2022 01:51:20 GMT, Leo Korinth wrote: > One can select a testcase by ID when running a jtreg test case directly from > jtreg (using the testcase.java#testID syntax). However, this has not been > possible to do when launching jtreg indirectly from make. > > This fix attempts to ad

Re: RFR: 8287745 jni/nullCaller/NullCallerTest.java fails with "exitValue = 1"

2022-06-06 Thread David Holmes
On Fri, 3 Jun 2022 07:56:38 GMT, Tim Prinzing wrote: > Fixed JtregNativeJdk.gmk to include c++ libs for NullCallerTest Hi Tim, Sorry but I have to ask why this test was created as a C++ program instead of keeping it as a C program likes it predecessors? No need for C++ libs or special excepti